Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5701593yba; Thu, 11 Apr 2019 04:03:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3XNGfSym54aHF/j02OEFLezg1uyBTlwIqdUCDW4UfhY+2dRclb0emNcsvwr/S0Rv6/dB/ X-Received: by 2002:a62:61c2:: with SMTP id v185mr49542894pfb.117.1554980623454; Thu, 11 Apr 2019 04:03:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554980623; cv=none; d=google.com; s=arc-20160816; b=insVpabHCexBPyVRkN6yh1LHgayJTgcOcRRihjKG/FZVr0TAD3VrCmrAJr3AqiHVPn c2onrBibtYtI4poxunl063BO81cSrvVD9MU2LfjD//WqbVRrD6oO2XjLBnsJT0Iz6Fb1 Y7Rp2luhltIv5VcPd711txMYtrdkrkS2qG3JDfw5kGtTZI8Bg9RJefVhqjsZUK9AzSch ktqhPLj4DlBng+vUe6gtFD2y5GpJP7Xu+SDbEpZojpimZ9Q+2m0pOK/I7I2+qRRSj80Z wTfCXHc+tUWNkbLKwVP8+QugLLmR6B9fov7BlWn9mIDoeJZo4AitmsnIBkOa7fpQCMBM wirA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=/tVC0+/t6dWdZ0BHs6lF7YjbUT0mzK7G42y/he8P1Dc=; b=bnPBRj0F+FJxBc1z3M3ijGkxHALd+mCF1agigkR9+4Oyi8WCxuaqiuefLNR5Ci7B/K oNlZOa+ByapWwUV0LpAT5Vam6FRRcm5sy+/nI7OSMf0YZK2yB1pC+TCnamH8pAF+Mh1p wIb9fk6IaCEYH8xKiMwn1hPm1FKKf/rAy2tN33DQJ/EvuMgFy4SrMYotgeF/fADHdW8K 2uKKvPJHf5cI139p+B8ZJACUf8IRld5tosNkO19rhoANvPETuymLC8r2Xuzrnvjyzg69 3NbQQz4kEzySURc270wr2SWdb8GaBAygD+8dN6Smi6YZuhxGf4AX8jdTWnG1a5CeVy1U pndw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si18299966pld.94.2019.04.11.04.03.27; Thu, 11 Apr 2019 04:03:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbfDKLBX (ORCPT + 99 others); Thu, 11 Apr 2019 07:01:23 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:40637 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726026AbfDKLBX (ORCPT ); Thu, 11 Apr 2019 07:01:23 -0400 X-UUID: c2c7b295e387456dbb5d0f87b239a639-20190411 X-UUID: c2c7b295e387456dbb5d0f87b239a639-20190411 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1999337745; Thu, 11 Apr 2019 19:01:18 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Apr 2019 19:01:15 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 11 Apr 2019 19:01:15 +0800 Message-ID: <1554980474.27008.6.camel@mtksdaap41> Subject: Re: [PATCH v2 15/25] drm/mediatek: add function to background color input select for ovl/ovl_2l direct link From: CK Hu To: CC: , , , , , , , , , , , Date: Thu, 11 Apr 2019 19:01:14 +0800 In-Reply-To: <1553667561-25447-16-git-send-email-yongqiang.niu@mediatek.com> References: <1553667561-25447-1-git-send-email-yongqiang.niu@mediatek.com> <1553667561-25447-16-git-send-email-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang.niu@mediatek.com wrote: > From: Yongqiang Niu > > This patch add function to background color input select for ovl/ovl_2l direct link > for ovl/ovl_2l direct link usecase, we need set background color > input select for these hardware. > this is preparation patch for ovl/ovl_2l usecase > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > index b76b663..20e8061 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > @@ -92,6 +92,9 @@ struct mtk_ddp_comp_funcs { > struct mtk_plane_state *state); > void (*gamma_set)(struct mtk_ddp_comp *comp, > struct drm_crtc_state *state); > + void (*bgclr_in_on)(struct mtk_ddp_comp *comp, > + enum mtk_ddp_comp_id prev); > + void (*bgclr_in_off)(struct mtk_ddp_comp *comp); > }; > > struct mtk_ddp_comp { > @@ -173,6 +176,19 @@ static inline void mtk_ddp_gamma_set(struct mtk_ddp_comp *comp, > comp->funcs->gamma_set(comp, state); > } > > +static inline void mtk_ddp_comp_bgclr_in_on(struct mtk_ddp_comp *comp, > + enum mtk_ddp_comp_id prev) > +{ > + if (comp->funcs && comp->funcs->bgclr_in_on) > + comp->funcs->bgclr_in_on(comp, prev); > +} > + > +static inline void mtk_ddp_comp_bgclr_in_off(struct mtk_ddp_comp *comp) > +{ > + if (comp->funcs && comp->funcs->bgclr_in_off) > + comp->funcs->bgclr_in_off(comp); I think you should use a 'tab' to replace 8 white space. Regards, CK > +} > + > int mtk_ddp_comp_get_id(struct device_node *node, > enum mtk_ddp_comp_type comp_type); > int mtk_ddp_comp_init(struct device *dev, struct device_node *comp_node,