Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Koskinen, Aaro (Nokia - FI/Espoo)" <aaro.koskinen@nokia.com>
To:     Sudeep Holla <sudeep.holla@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Aaro Koskinen <aaro.koskinen@iki.fi>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: RE: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2
Thread-Topic: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2
Thread-Index: AQHU8FISjWdUbTwX5kqSuz7S67NyXaY209/M
Date:   Thu, 11 Apr 2019 11:42:28 +0000
Message-ID: <AM0PR07MB6019AB10C7DD38F7AFECF0E0F42F0@AM0PR07MB6019.eurprd07.prod.outlook.com>
References: <20190411103346.22462-1-sudeep.holla@arm.com>
In-Reply-To: <20190411103346.22462-1-sudeep.holla@arm.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nokia.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e644f34-6634-4dbf-ac61-08d6be72c653
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2019 11:42:28.1136
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB5218
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

From: Sudeep Holla [sudeep.holla@arm.com]:
>  static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd=
)
>  {
> +       if ((reboot_mode =3D=3D REBOOT_WARM || reboot_mode =3D=3D REBOOT_=
SOFT) &&

I would omit the REBOOT_SOFT here.

> +           psci_system_reset2_supported)
> +               /*
> +                * reset_type[31] =3D 0 (architectural)
> +                * reset_type[30:0] =3D 0 (SYSTEM_WARM_RESET)
> +                * cookie =3D 0 (ignored by the implementation)
> +                */
> +               invoke_psci_fn(PSCI_FN_NATIVE(1_1, SYSTEM_RESET2), 0, 0, =
0);
> +
>        invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0);

Use else here, so that we fall back to system halt if SYSTEM_RESET2 fails.

A.