Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5837921yba; Thu, 11 Apr 2019 06:51:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqziu/r//Bwf9IarRzMVeoo0Kw+gZA7aWS/nSQTGqNVnpYAMiJ+JfeCRem64FbSjaRQ2gz36 X-Received: by 2002:a17:902:2965:: with SMTP id g92mr33391657plb.267.1554990673416; Thu, 11 Apr 2019 06:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554990673; cv=none; d=google.com; s=arc-20160816; b=QsWsPh2LgegUKpyu/Rz5xzbuiIxLYdDmMk44DsxCXYkpBxivSyTBs3izylEA5UMa8b w4SDkNIAJsHCeuV1DIKoylV0AI4rE7wpAKdJCWisY7kuTC439L3DSNdUD/KQ1vpLSOVq TE8Wh6nhLm9+M18R1n4OpE0GJKq7/EBWoj2H/QzZh8gmEn/WwV2yKUfrVHiC3vD++HeY ObldtHaOnGwFp/rAquBB4dMlKUmB3AGLkS7VvwTFKqxu07hTYwMYWu0xv819vksQGe0L m/eV5D+mvv2ZH6Ik/Vj+UbAW98j8KK4TqbDBG4TZ7fqbEjwqcrcYHKePZVJCsR3DLrsg jwtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=v4R2nON0fldrx5nngWEL1/9mxMORAgC13VD1L1J+hqE=; b=OXRwVWtNhM3zaIqDXizsa6f354wZcLUoZYf5aXyu5iGGA6ub78yW2dD1lc/W9OcfrK WfQT0s+pLRLA+hIWb2nXpHQC4SIZTEDbhL52Ifc4lVnAZaRlV7wEyJaruyLcVN43hjgL lS+z+5AW3aQS0nnY90c+z2EMDJMxSO9xNDPd3WQDZomFOoknE0DvSWg1hvfLMGot+jtp 9zVBxERn9ipwXf9xUeiialLkJsyiHWwP4K6OZJCmf076ai2MxJKaaIVqg3okusAe94JU ZIJOy6ZD5SaSkXQcEf7n9ctYsSA3cK1OWvfPZdX6yKMLQRdBW1qqaaYsen1iYGA3f85g +rrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n5tcpxay; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e15si20979242pfj.60.2019.04.11.06.50.57; Thu, 11 Apr 2019 06:51:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n5tcpxay; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbfDKNuL (ORCPT + 99 others); Thu, 11 Apr 2019 09:50:11 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:34683 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbfDKNuL (ORCPT ); Thu, 11 Apr 2019 09:50:11 -0400 Received: by mail-lj1-f194.google.com with SMTP id j89so5614604ljb.1 for ; Thu, 11 Apr 2019 06:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v4R2nON0fldrx5nngWEL1/9mxMORAgC13VD1L1J+hqE=; b=n5tcpxayQJWVkfmz544eU/QxZK23icq8z6nor0EUpI65AyurqVGjsnpdLWxaCxrcLw zjGEz4yTq6YL6JsBMgLRjeQvUISwUYiq3cGX4defR+9JDRL9oUi1fP5f3VkAqv2jJdCt b4R3K97mIvt2UZbz/xy++6ZCOTaeA2FwXQYtMEyIBFryDI5TBsWLmgrJkRVJlqdU660k ec5F6TdsVxE0ISKhTkUIgrZywqdiEaf1CFzrb0XZoAHmc5aT7uFYmxyIuSlKUw5Q8LQ7 Gu1z2iCwKcG0jc5W8074pW/NPBS5jthqetXQgvk6peGEPn9PDB9+zbQ4UpYamYdOn1GA agsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v4R2nON0fldrx5nngWEL1/9mxMORAgC13VD1L1J+hqE=; b=THOkFg2zcFI0ezGGuBHaGtMoJSq+/UDyhFr+kG64IuWZI76cvN/8opwU3IbnrK9vHK EUuCzWtr9PkqRY1TkDxOzXkKakt4I1CBnWEaYWip6UMUhBI4WTbiAIwLpZrilV/YY9SY Srh3z3M4PTuOrk4nieYFHTOxTnZC+BWUu3be3o9z+Z3i/a9y2U3yE4eGCqVw9vxqlzuD v3wrXjW+IvZTFVTONc5abqkGVsK81tQwKUB+OXeHy3zEHPcuhCnQC/RyMvE0AFXIeFyD 9Img9thTJjsH9aqmRxAJrKg4WtuqcplAtmDnijGYRM598X+6QwLLwYzNZLqQE6je70JJ 2vIQ== X-Gm-Message-State: APjAAAVYUFN0zixDQnlTGlRd1RQ3GtXDr85bnW5z2FEhEbC8/E8MXtO6 pZoh9nXUh8GF0uHvq1V1OdJVZWp+pGkJoBd6zSgdzg== X-Received: by 2002:a2e:808e:: with SMTP id i14mr28032166ljg.103.1554990609376; Thu, 11 Apr 2019 06:50:09 -0700 (PDT) MIME-Version: 1.0 References: <20190410103926.8781-1-alexandre.belloni@bootlin.com> <20190410103926.8781-2-alexandre.belloni@bootlin.com> In-Reply-To: <20190410103926.8781-2-alexandre.belloni@bootlin.com> From: Linus Walleij Date: Thu, 11 Apr 2019 15:49:58 +0200 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: gpio: lpc32xx: document interrupt bindings To: Alexandre Belloni , Marc Zyngier Cc: Bartosz Golaszewski , Vladimir Zapolskiy , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , Rob Herring Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, thanks for your patch! On Wed, Apr 10, 2019 at 12:39 PM Alexandre Belloni wrote: > Some of the LPC32xx gpios are wired directly to one of the interrupt > controllers while port 0 and port 1 share the same interrupt for their > interrupt capable gpios. > > Cc: Rob Herring > Signed-off-by: Alexandre Belloni (...) > +- interrupts: Should be the interrupt shared by port 0 and port 1 and the > + interrupts for individual pins from port 3. > +- interrupt-names : Should be the names of irq resources. The shared port > + interrupt is named "p01", the other use the pin names. The recent design pattern with hierarchical interrupts such as this one is to simply hardcode the relationship between parent interrupt controller and child interrupt controller in the driver. However you should add interrupt-controller and possibly interrupt-parent to the bindings and example. More comments in patch 2. Yours, Linus Walleij