Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5917566yba; Thu, 11 Apr 2019 08:22:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3HA8LF8Eli2qXCbd0Lars1Azy+fYZCGVHgIDayv+G8NMCILaG2rLOsMsrwXPM1FIAdvvO X-Received: by 2002:a62:571b:: with SMTP id l27mr50706197pfb.195.1554996123691; Thu, 11 Apr 2019 08:22:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554996123; cv=none; d=google.com; s=arc-20160816; b=qbfnJps7Sa/Fnt7EGXqHNhI3lIV9mvbiymtz3TmiUzYLpg6Cq3zrLfbS9+5wFUYw3r fwdka33h6L18hIvZOyeqsRyVCm+ayz/nrnTrVYLQtRDdQGBn3eQ5tDwIpbZzGgnV5xIn QlSCsLxqkwXBrC6C+7DrvCPkP0bPC67kP1OVCkiL2BKIwoMOt8sD/xaJ3sQKUSQ7E+ka pBSYFdjgkCyjAwiJpwSq9+T6AnEi/JX/Qaa1orIt0qf+m5OcXA9dT7ozWCiwbi03oV03 alPfvNdv3GXPDh65CZxHSjO0daad7H9OID08ifoYtdrMnQWrz+Jcu3kMFcs/OuNmtN3+ 0F5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/Fo5OLh3kvXp9PrAxreYlsha/YdqUWlDpuuP1QpnAT4=; b=B2c+omu6BBknjyPfqiEEn0LE4KfSGxDOkm9xztJZvn7rsFe7iHv+647I7U2rUMdmWb QRWz75YUN6i4JpUu/vJiZ7nNoWyQtqn/F8YfJnd0D++m6YAdO32LX/C34hMKk0XCp4js dPMXLM6bh1tFOzb3LHisU/+B2l5m8ZEd3MDFe446DpNaJHlGxaT0eybk+H8dnuQ7reD9 zJ1UAQq9FoDx2pr+ylaESSUUh8+4DczQuXLNTht1Co2j9lN5pW/4eoZb9xfpqUhi0s2g IRwK9mZTj+aDdSmbiqpYPntxFOPV0FMl/1y7ALQjhOQwEGLPJUGHaHpvMulU1bI1NQhA TbNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 94si35736085plc.298.2019.04.11.08.21.47; Thu, 11 Apr 2019 08:22:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbfDKPTW (ORCPT + 99 others); Thu, 11 Apr 2019 11:19:22 -0400 Received: from 8bytes.org ([81.169.241.247]:34180 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726732AbfDKPTT (ORCPT ); Thu, 11 Apr 2019 11:19:19 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 7AEA2451; Thu, 11 Apr 2019 17:19:17 +0200 (CEST) Date: Thu, 11 Apr 2019 17:19:17 +0200 From: Joerg Roedel To: Lu Baolu Cc: David Woodhouse , Alex Williamson , Kirti Wankhede , ashok.raj@intel.com, sanjay.k.kumar@intel.com, jacob.jun.pan@intel.com, kevin.tian@intel.com, Jean-Philippe Brucker , yi.l.liu@intel.com, yi.y.sun@intel.com, peterx@redhat.com, tiwei.bie@intel.com, xin.zeng@intel.com, iommu@lists.linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 0/9] vfio/mdev: IOMMU aware mediated device Message-ID: <20190411151917.GA29810@8bytes.org> References: <20190325013036.18400-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190325013036.18400-1-baolu.lu@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lu Baolu, thanks for these patches! On Mon, Mar 25, 2019 at 09:30:27AM +0800, Lu Baolu wrote: > Lu Baolu (9): > iommu: Add APIs for multiple domains per device > iommu/vt-d: Make intel_iommu_enable_pasid() more generic > iommu/vt-d: Add per-device IOMMU feature ops entries > iommu/vt-d: Move common code out of iommu_attch_device() > iommu/vt-d: Aux-domain specific domain attach/detach > iommu/vt-d: Return ID associated with an auxiliary domain I applied the patches above to my tree. The first patch is in a new branch called 'api-features' and the other are in the x86/vt-d branch. > vfio/mdev: Add iommu related member in mdev_device > vfio/type1: Add domain at(de)taching group helpers > vfio/type1: Handle different mdev isolation type Can you please address the minor concern on these patches, add all review and acks and re-send? Thanks, Joerg