Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 11 Apr 2019 10:33:32 -0500
From:   Madhumthia Prabakaran <madhumithabiw@gmail.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data
Message-ID: <20190411153331.GA8557@madhuleo>
References: <20190409161617.29871-1-madhumithabiw@gmail.com>
 <20190410064954.GE6095@kadam>
 <20190410194908.GA13242@madhuleo>
 <20190411081328.GF31633@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190411081328.GF31633@kadam>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 11, 2019 at 11:13:28AM +0300, Dan Carpenter wrote:
> On Wed, Apr 10, 2019 at 02:49:09PM -0500, Madhumthia Prabakaran wrote:
> > On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote:
> > > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote:
> > > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
> > > > index bafb2c30e7fb..b0623c936940 100644
> > > > --- a/drivers/staging/rtl8723bs/include/drv_types.h
> > > > +++ b/drivers/staging/rtl8723bs/include/drv_types.h
> > > > @@ -220,7 +220,7 @@ struct registry_priv
> > > >  #define BSSID_SZ(field)   sizeof(((struct wlan_bssid_ex *) 0)->field)
> > > >  
> > > >  #include <drv_types_sdio.h>
> > > > -#define INTF_DATA SDIO_DATA
> > > > +#define INTF_DATA struct sdio_data
> > > >  
> > > 
> > > Just get rid of INTF_DATA data as well.  It's only used once a bit lower
> > > in the file.  (Get rid of the ifdef around it).
> > 
> > But, reference of INTF_DATA is also included in file 
> > ./drivers/staging/rtl8723bs/include/drv_types.h:487:
> > return &dvobj->intf_data.func->dev;
> > 
> 
> Actually, I maybe misunderstood your email.  I'm not sure what you mean
> about "&dvobj->intf_data.func->dev;".  I just meant to replace
> INTF_DATA with "struct sdio_data".

Sorry, I wasn't able to align my thoughts over ifdef. Thus, the
confusion in fixing it.

However, I edited it now.

Thanks,
Madhumitha


> 
> regards,
> dan carpenter
>