Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263060AbUDAS5S (ORCPT ); Thu, 1 Apr 2004 13:57:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263061AbUDAS5S (ORCPT ); Thu, 1 Apr 2004 13:57:18 -0500 Received: from fw.osdl.org ([65.172.181.6]:34993 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S263060AbUDAS5M (ORCPT ); Thu, 1 Apr 2004 13:57:12 -0500 Date: Thu, 1 Apr 2004 10:55:53 -0800 From: Andrew Morton To: Olof Johansson Cc: manfred@colorfullife.com, torvalds@osdl.org, linux-kernel@vger.kernel.org, anton@samba.org Subject: Re: Oops in get_boot_pages at reboot Message-Id: <20040401105553.38468a64.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 19 Olof Johansson wrote: > > So __pollwait() calls __get_free_page(), system_running is 0 so > get_boot_pages is called. Since get_boot_pages is labeled __init, badness > happens. > > How about checking against mem_init_done instead of system_running? It > helps against the oops, but there might be some good reason not to do > it. I don't claim to know the intrisic details about the MM. :-) Do we really need to clear system_running at reboot? I'd always viewed it as "everything is initialised and usable", and that's generally true at reboot time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/