Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6004175yba; Thu, 11 Apr 2019 10:01:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2oZ2yC6JnvXdyI+ruUCLr4iU7hV41jxKxu7tEWo5Eu3/FmsIceSGvw5YBgeTF+ZIMeBNb X-Received: by 2002:a63:6a44:: with SMTP id f65mr15192874pgc.354.1555002106259; Thu, 11 Apr 2019 10:01:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555002106; cv=none; d=google.com; s=arc-20160816; b=DxG1AitXU6pTT5LG3Ct6XyVqZNhgJ8vSO/lrPn/sWV0KRq76Ugfo0/Hrnua7hi3v4J FsEWjsq4pl2hNAqnkp4sk+EsXOg/u7mnUrn+gd2jAyNNHa6ZpPJE8IboLFq3kwsHJotQ l2fdrGtpPhK3xIa/kty/T51YmNHu0Q558AplfqZ/xgpN13L9qBzuRxqRJWGUvd+0HTFF 8vd+DgNkhrGq6yOFOoILIK45CDk1hyRai2QG9fQZNz+B12A6SA+wdJ4P/95n6onIUSoc oK+pQWuz+IuHaODaQfrlH5qRTw1t9FxpP1vkhccqKQwKxbKDMznwMeWUuibzzcPa6rsH 2JkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=PL+/ApLhDtv/wuvORoq89qLIs51XROLHFnFu0SSGf9A=; b=dN/88AJhUSq4EcHngqZGCgy8m7HB74/6AKSEyUWfmRUmjR2jLQG/eLGqCvZv0ROUGe pPOT/1cGoxEysAHeBLnPNxSefjgzU2tAx9jG8eeFrn26KOifhMa3RD8YR/8pfUScv3c1 US8ks7/FZRN5dYEn2KscuK/YHuc4oHXtN3N94SiWh4JeSyLGlnoXnrVtXlX3eJGDgfRp Rq9kJj/VNUxm2TbbBfE4DsdSZV9ztcEjsK/te0JLl/3CSj4B00z8fSYt9VIprhLyKsV/ djXD9/su9L4Brc827atT6lJbfEVs5/Q4u3b46RqcWlFP6Knsks1Aa6LlgQPPzbWKRzLE 2SAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nArkzuvO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s9si35178322pgr.443.2019.04.11.10.01.30; Thu, 11 Apr 2019 10:01:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nArkzuvO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726861AbfDKRAi (ORCPT + 99 others); Thu, 11 Apr 2019 13:00:38 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:35939 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbfDKRAh (ORCPT ); Thu, 11 Apr 2019 13:00:37 -0400 Received: by mail-vs1-f67.google.com with SMTP id n4so3913904vsm.3 for ; Thu, 11 Apr 2019 10:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PL+/ApLhDtv/wuvORoq89qLIs51XROLHFnFu0SSGf9A=; b=nArkzuvOWz6ap6xqQ7o4EL4Pj4K5clN+0yGEVjAynJHikPUUMmeE24oEmeGQBKodA6 V81t5+MrdU9vD1lRQhVXrFeOkz6KrQpWLK7rXWl/4QY55WClp86EeACiDxPF91ji4mQZ tM0wF2tqj6OUD5DxCGsABtDJw58PU39ITFxJw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PL+/ApLhDtv/wuvORoq89qLIs51XROLHFnFu0SSGf9A=; b=gsZ6eNrMvrE1WQpQQclaSE0lSGgUKXHquU7lTBaHVTrZ5HqwPP4V/DA4CcGhAt8ynN ye180YKpmEc1jML/19LvA7RH/SB5TnIbhrfHTTph3Vt1MQC1edsKsW8t6Jlk7rhulnNd m6LUEO06+Had2GnmjJDvGiW5RVZjcBIb8qKqdcJsSGJBvIW9fG736rkyNsa1VeOtk+Sj o2dLBGUHUhPMZ11/pCKtmrxh29QZ5/OQ3oi+bemZrQDHAS9qQ18amEHlhACX+jWrSbKa BO+owjwU0kzeO32BWh+Kw05tgPmtOao1+FRWlGQlcm/m3k5kTMTWg8W0A+uEcpuQS8ev ufEg== X-Gm-Message-State: APjAAAVxEnn7oJMtA1mEmB9XTyN+mLDH1lsl7nsb1KDp/6nzzSMf+C5A 686B07LxsIiQ6cjWqoE0b4BxxD5nAEo= X-Received: by 2002:a67:f256:: with SMTP id y22mr12439651vsm.19.1555002036914; Thu, 11 Apr 2019 10:00:36 -0700 (PDT) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com. [209.85.221.172]) by smtp.gmail.com with ESMTPSA id x80sm9585893vkd.22.2019.04.11.10.00.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 10:00:36 -0700 (PDT) Received: by mail-vk1-f172.google.com with SMTP id g24so1534553vki.2 for ; Thu, 11 Apr 2019 10:00:36 -0700 (PDT) X-Received: by 2002:a1f:264b:: with SMTP id m72mr17588022vkm.43.1555002035746; Thu, 11 Apr 2019 10:00:35 -0700 (PDT) MIME-Version: 1.0 References: <20190411005634.8495-1-okaya@kernel.org> In-Reply-To: From: Kees Cook Date: Thu, 11 Apr 2019 10:00:24 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default To: Masahiro Yamada , Andrew Morton Cc: Sinan Kaya , LKML , Josh Triplett , "Peter Zijlstra (Intel)" , Johannes Weiner , Nicholas Piggin , Mathieu Desnoyers , Vasily Gorbik , Adrian Reber , Richard Guy Briggs , Andy Shevchenko , Petr Mladek , Joe Lawrence , Matthew Wilcox , Randy Dunlap , Mikulas Patocka , Robin Murphy , Tetsuo Handa Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 10:34 PM Masahiro Yamada wrote: > > On Thu, Apr 11, 2019 at 11:47 AM Kees Cook wrote: > > > > On Wed, Apr 10, 2019 at 5:56 PM Sinan Kaya wrote: > > > > > > We can't seem to have a kernel with CONFIG_EXPERT set but > > > CONFIG_DEBUG_KERNEL unset these days. > > > > > > While some of the features under the CONFIG_EXPERT require > > > CONFIG_DEBUG_KERNEL, it doesn't apply for all features. > > > > > > It looks like CONFIG_KALLSYMS_ALL is the only feature that > > > requires CONFIG_DEBUG_KERNEL. > > > > > > Select CONFIG_EXPERT when CONFIG_DEBUG_KERNEL is chosen but > > > you can still choose CONFIG_EXPERT without CONFIG_DEBUG_KERNEL. > > > > > > Signed-off-by: Sinan Kaya > > > Reviewed-by: Kees Cook > > > > Masahiro, should this go via your tree, or somewhere else? > > > I think somewhere else. Okay. Andrew, can you take this? -- Kees Cook