Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6083811yba; Thu, 11 Apr 2019 11:42:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQ2vWQQWRJnPw/VcR8ZKxC6ugSxkxLuWhosviz1mdjlGS7Pg0g4RGIn+OVRSRYAqzvKPph X-Received: by 2002:a63:2bc8:: with SMTP id r191mr49136785pgr.72.1555008141530; Thu, 11 Apr 2019 11:42:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555008141; cv=none; d=google.com; s=arc-20160816; b=WONJwPtJBV2tqtPZuTq/+fun13Z5Mby0xaTWEQYZ0ODs5ZahnDK9dTZG8pph9vkymD 6qgmOHdUJF/Nv1aipRJMFk76LehQLUZyKvMtnt9H8op/+ZY5MMPTu9vpJbXaJGXslbCY Jr6tcAJdvnk0h1wn7QxicRKbX4Y7lrDo7Xv6yJOg72a/3+5q+kAtORKh4mb46ZIMr3Em qdFjKuu6iLefydfwYdnoVGlpeHsgY4kBDvGWlm33uKXBy8Qu7Jeyz961ijaFvUpcq4jo YsZJiTQDqcMEPxVQISH5aLOMu0fNYRXRElL8jEU0vhBZX2GSYaHVdwyXRHrcSMaXGvgW AABw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=CavB+E2ox56ORq2jr+cB6FiPjgd2z77R9eJIRjNV12A=; b=uQGMkHFSPFh3C67cOzibVpT0ML/6FTf+u9ivYDdwyJU6fwg4TBwacF7WR1kEKVsqHb Ma1tzEXpjsopk+sVrf/u1JtLp7hjAuKV+88OWmmSEc9rsdfVZ4QiuFIGkTkhN908UKAk 6+CNDYeuuKzE9UQV0ffRM6aSbf+4a5QFJNQv7xdemTeqK1nE3mdBKTIR9qXw36VqmJuJ BugUpnwzETOfShfcRI60T3eJL6Nr3ltZwVWkMSzfgkgxnDBwUApsbDlUutsuFeVUV5CJ JVOvxpHKL/z30lWRIYx0xjvdsMI5HcEPjwX9mZiJSHrR1ECJ2WDNNE6YDEb5VkHWJjAv Bosw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 127si35781977pgf.595.2019.04.11.11.42.05; Thu, 11 Apr 2019 11:42:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbfDKSla (ORCPT + 99 others); Thu, 11 Apr 2019 14:41:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:49014 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726603AbfDKSl3 (ORCPT ); Thu, 11 Apr 2019 14:41:29 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2F568AE47; Thu, 11 Apr 2019 18:41:28 +0000 (UTC) Date: Thu, 11 Apr 2019 20:41:26 +0200 (CEST) From: Miroslav Benes To: Joe Lawrence cc: Masahiro Yamada , Linux Kernel Mailing List , live-patching@vger.kernel.org, Linux Kbuild mailing list , Jessica Yu , Jiri Kosina , Joao Moreira , Josh Poimboeuf , Konstantin Khlebnikov , Michael Matz , Nicolai Stange , Petr Mladek Subject: Re: [PATCH v3 1/9] livepatch: Create and include UAPI headers In-Reply-To: <141bbc68-95a7-3444-08a5-3794b6dc84ce@redhat.com> Message-ID: References: <20190410155058.9437-1-joe.lawrence@redhat.com> <20190410155058.9437-2-joe.lawrence@redhat.com> <141bbc68-95a7-3444-08a5-3794b6dc84ce@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> + > >> +/* > >> + * livepatch.h - Kernel Live Patching Core > >> + * > >> + * Copyright (C) 2016 Josh Poimboeuf > >> + */ > >> + > >> +#ifndef _UAPI_LIVEPATCH_H > >> +#define _UAPI_LIVEPATCH_H > >> + > >> +#include > > > > > > Why is this include needed? > > > >> +#define KLP_RELA_PREFIX ".klp.rela." > >> +#define KLP_SYM_PREFIX ".klp.sym." > > > > These do not depend on > > > > Hmmm, types.h has been included since v1, but I just verified that removing it > results in a clean build, so you are correct that it is (now) unnecessary. Yes, I mentioned it while reviewing v2. Unfortunately, it seems to get lost due to unexplained submitting hiccups. Better to walk through my emails again and make sure nothing more falls through the cracks... Miroslav