Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/3] clocksource/drivers/timer-milbeaut: Fix to enable
 one-shot timer
To:     Sugaya Taichi <sugaya.taichi@socionext.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
Cc:     Takao Orito <orito.takao@socionext.com>,
        Kazuhiro Kasai <kasai.kazuhiro@socionext.com>,
        Shinji Kanematsu <kanematsu.shinji@socionext.com>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>
References: <1553483149-8922-1-git-send-email-sugaya.taichi@socionext.com>
 <1553483149-8922-2-git-send-email-sugaya.taichi@socionext.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <0488b22d-6e47-768a-6bde-eb2d7196f7e9@linaro.org>
Date:   Thu, 11 Apr 2019 22:08:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1553483149-8922-2-git-send-email-sugaya.taichi@socionext.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 25/03/2019 04:05, Sugaya Taichi wrote:
> Fix mlb_set_oneshot_state() to enable one-shot timer.
> The function should stop and start a timer, but "start" statement was
> dropped. Kick the register to start one-shot timer.

Can you add the "Fixes" tag please.


> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
> ---
>  drivers/clocksource/timer-milbeaut.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clocksource/timer-milbeaut.c b/drivers/clocksource/timer-milbeaut.c
> index f2019a8..9fd5d08 100644
> --- a/drivers/clocksource/timer-milbeaut.c
> +++ b/drivers/clocksource/timer-milbeaut.c
> @@ -80,6 +80,8 @@ static int mlb_set_state_oneshot(struct clock_event_device *clk)
>  	u32 val = MLB_TMR_TMCSR_CSL_DIV2;
>  
>  	writel_relaxed(val, timer_of_base(to) + MLB_TMR_EVT_TMCSR_OFS);
> +	val |= MLB_TMR_TMCSR_CNTE | MLB_TMR_TMCSR_TRG | MLB_TMR_TMCSR_INTE;
> +	writel_relaxed(val, timer_of_base(to) + MLB_TMR_EVT_TMCSR_OFS);
>  	return 0;
>  }
>  
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog