Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6247602yba; Thu, 11 Apr 2019 15:30:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwajJkVi1SBGa6k9y/G6BAi9mJEB340cDlAmwvMMiQLuR6dIcjJJPrvR5mAIqa1O4WWCUz X-Received: by 2002:a63:f40d:: with SMTP id g13mr50735748pgi.345.1555021800641; Thu, 11 Apr 2019 15:30:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555021800; cv=none; d=google.com; s=arc-20160816; b=bZa7ZP+1NrLD0p30q+vM6Su2qnhL6DHLw9Bv7WIC5GzQaPY5KnKd9nYXQ0hrfFLG6g Fiq4r9ysG6sPMF+rHqMgM8hoWRD1sglDts1TXHQQmjkQhiOdNGh5dX8svhv6pcb/ke7B WU19y53bpjcxgYN6vXcPi8AKIM4EktE/En/bY6lr+QtYlbBnf7ZiQ4pM7Cz4LaEf9kiB M8xbNYYTmNOSKDfn983mXXM5HeDIAqMiYBvZNVznlLb9Ttvu8tvLk3VnvXcGA+IDTAHC FZ98vURo8q2fEJSONWrJ8iE1DfjQvjBU9fwPf8qP1+H74O/ONEXVSFCIhdcx77HtUlfu Bpbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from:dkim-signature; bh=uTFkXkVdh/O7ixJtZ7bO2us+9D2yox0RXxQZN09Bofw=; b=zj0TXU8gV91TT/2Bm58Nu7IKPqB9FSQ7PFv5fLSoz+mAKuHC8lkprZANhTWPnv0C6x GGsmRkkP6ye/C2FIVhkvdaSKdyAUJvYflweyKB/dy6xnA7VsN096fC7vpzv68+aJ8t50 Owzd9gx1NIzXsWAcP4uumE4YYhXFfg2he0occfLg0SlRlrpqPRUfH0qSQ8I/qzJj2o1+ bpht85XzOlXeXfRb3XyX0VXjim2OXzfVBsAWRzJb1rC3/MYIC5nzwwrqPEQyPVr7ZidO +Hn+zcWJ5FOXO0XpLBaI54JWjsA5cmKDUi76SPFl2YtR4DWtYAeSfN3iqnQ2PCfU4hBb e0DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=UpfauI5G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i19si17565891pfr.246.2019.04.11.15.29.43; Thu, 11 Apr 2019 15:30:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=UpfauI5G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727129AbfDKW1J (ORCPT + 99 others); Thu, 11 Apr 2019 18:27:09 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:46573 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726629AbfDKW1I (ORCPT ); Thu, 11 Apr 2019 18:27:08 -0400 Received: by mail-qt1-f195.google.com with SMTP id z17so9030923qts.13 for ; Thu, 11 Apr 2019 15:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uTFkXkVdh/O7ixJtZ7bO2us+9D2yox0RXxQZN09Bofw=; b=UpfauI5G8dK9MFaxmZ6TrYsKjf75tbtr7Bg3NWfCQASLHnCiNQlyw4EREk5qP0tsUr uCI19XKKlKOazg9XmNum+RHN+3f3c0T53oCC4oXlhhhOtHzhGgjDrD0sH89dURTt+tsG 9eIenLt86vWkYCIzOjI20uDKXRdOrcGzG1Q54zu8tvBXBT78xzswkLWxdNgGsmRxNwuQ FF63O35kKZ49hRAm/e+XoZBo+P2FDm7DqVtRqAnW3uOcLFCS+uMrVbIy4qeQn6jFiW3j qam8/DfdjHE7dmNRi3HwLf0Fs5DDmJ+RtD4NKfYU4n6Istaz1ltVRbnO5IWYfAiz1/E7 lKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uTFkXkVdh/O7ixJtZ7bO2us+9D2yox0RXxQZN09Bofw=; b=D6AsHpQhoOLS1J6uMRq9YtFPYnPO13wy0lfKc9PpfeQUflUz7qgYDWsTZ0qIQWA4IK ZK4PiQ14b7wu0klTVzG4fHO7jkXdSykJHJdE6m7bjPv2m9lsWMNBXfDDDx9C18TeiGNT Mr0eCyE8xSOQA4yg4XRZOLfflBewh+EYzGtyHPI5btD9N98swjXSauDt0wE7TDI9DDlI uOwIb7o+UxaPPgmrZIZSf4e8fV9vTYD4b5YvBHQRoiLk/owQhjUSyyMdnVjSHnx/xKr6 DqHZ3pw7boVKJWT5TAGufglTBiQvEOQ2MaElhtqCpem7iSwmpN3nld1LGwORvTUrOyAB +fGA== X-Gm-Message-State: APjAAAX2xmgzANRVtooKK3pyLJiOx+Rr35+kNu0PhDsf8xDFTubOMfcA UNBoJElO+t+2/xQPhto9FjU= X-Received: by 2002:a0c:c988:: with SMTP id b8mr42921864qvk.33.1555021626339; Thu, 11 Apr 2019 15:27:06 -0700 (PDT) Received: from [10.84.150.23] ([167.220.148.23]) by smtp.gmail.com with ESMTPSA id u3sm24733958qtk.97.2019.04.11.15.27.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 15:27:05 -0700 (PDT) From: Sinan Kaya X-Google-Original-From: Sinan Kaya Subject: Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default To: Kees Cook , Josh Triplett Cc: LKML , Masahiro Yamada , Andrew Morton , "Peter Zijlstra (Intel)" , Johannes Weiner , Nicholas Piggin , Mathieu Desnoyers , Vasily Gorbik , Adrian Reber , Richard Guy Briggs , Petr Mladek , Andy Shevchenko , Matthew Wilcox , Joe Lawrence , Randy Dunlap , Mikulas Patocka , Robin Murphy , Tetsuo Handa , Changbin Du , Frederic Weisbecker , Sam Ravnborg , Ingo Molnar References: <20190410224213.20651-1-okaya@kernel.org> <135E84E9-F068-44CB-B4F6-A5AC2F4CDE3D@joshtriplett.org> <20190411221645.GA8692@localhost> Message-ID: Date: Thu, 11 Apr 2019 18:27:04 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/11/2019 6:21 PM, Kees Cook wrote: >> Proposed alternative plan: let's add a new symbol, something like >> DEBUG_MISC ("Miscellaneous debug code that should be under a more >> specific debug option but isn't"), make it depend on DEBUG_KERNEL and be >> "default DEBUG_KERNEL" but allow itself to be turned off, and then >> mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to >> "#ifdef CONFIG_DEBUG_MISC". >> >> Does that sound like an appropriately rapid solution for this bug? > Sure, that sounds fine to me. Sinan can you take care of that for v4? Sure, let me work on this.