Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6251888yba; Thu, 11 Apr 2019 15:35:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqx0+pkh/7dh8/PF3frD2l/FSnNyb2dpIBBBbvhdrVvEaBIjz6ftyWaQ7rPgufOBeJyVam6e X-Received: by 2002:a17:902:d70c:: with SMTP id w12mr53720286ply.198.1555022135480; Thu, 11 Apr 2019 15:35:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555022135; cv=none; d=google.com; s=arc-20160816; b=sm0qYiQ7mj1OJKPTR0KlWwqVVRMsL/8Nvm/Lic9aTsCHrQbedJsMh7Va1b3qMHljGq F5d8C5j0RNo+0WAAE/QV8+MTGOSbEyyz5YjSXn28HPUNswTyTBJzExvrqOO1z9ig19J5 qPj3nhLA9sSXfCgCKBDKdIaLDayGwz/nlBS9LDlmTmgodVC/E6EpelC/uk25Hj2MTEkL jeLKF6nkEW3q5mhwl8w9BHrZSoCJ+Fu9T4dm70cBjJtTZt91sUmX07K0tpGtW+A2yWtS jCD1HHzfS3GCX2rjwUXaCKC+adU79yJpNleoD97mPEIRW1UxC2aEzuweMAEq+uacuIyc tedA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+BQLuPKpgrv/fvtIvXuJr8bJZIobXfM98Yw9Y3gqJMU=; b=wsJ0C4D8cVIcxVDBPmZzABwKRUmtmLxqCVUDXD9OHtQav2e8gh7W6GzcRblIN0SMh0 leeE8Q02+T8eznDDuDokK4mmcT5GVOGgkpaQ7qgsAT9RrD1SQv8siCfAzcMOzHW77X3o mps3qb0tLLaxnpJ+xdDlkX1HGETHaBKfUrRarWco5bVGpavdx+ILhB6y6pt6bldjPnav KPwIdT/3ietdqIsF2BnBZ/VDsdfpVvqJf8wQGLnxjOg+NTXMsrn+HjpVMY3Tfn+jZt0/ nGHzKeOAFKUDvVOMGL0UfukGecnaASpN4vhd3DPxJIJi6o6B8bvs73fu3eGD2fTcgd8n cFTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v124si34594586pgb.475.2019.04.11.15.35.18; Thu, 11 Apr 2019 15:35:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbfDKWeg (ORCPT + 99 others); Thu, 11 Apr 2019 18:34:36 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:50693 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726677AbfDKWeg (ORCPT ); Thu, 11 Apr 2019 18:34:36 -0400 Received: from localhost (unknown [134.134.139.76]) (Authenticated sender: josh@joshtriplett.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id B1810200008; Thu, 11 Apr 2019 22:34:26 +0000 (UTC) Date: Thu, 11 Apr 2019 15:34:24 -0700 From: Josh Triplett To: Sinan Kaya Cc: Kees Cook , LKML , Masahiro Yamada , Andrew Morton , "Peter Zijlstra (Intel)" , Johannes Weiner , Nicholas Piggin , Mathieu Desnoyers , Vasily Gorbik , Adrian Reber , Richard Guy Briggs , Petr Mladek , Andy Shevchenko , Matthew Wilcox , Joe Lawrence , Randy Dunlap , Mikulas Patocka , Robin Murphy , Tetsuo Handa , Changbin Du , Frederic Weisbecker , Sam Ravnborg , Ingo Molnar Subject: Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default Message-ID: <20190411223423.GD8692@localhost> References: <20190410224213.20651-1-okaya@kernel.org> <135E84E9-F068-44CB-B4F6-A5AC2F4CDE3D@joshtriplett.org> <20190411221645.GA8692@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 11, 2019 at 06:27:04PM -0400, Sinan Kaya wrote: > On 4/11/2019 6:21 PM, Kees Cook wrote: > > > Proposed alternative plan: let's add a new symbol, something like > > > DEBUG_MISC ("Miscellaneous debug code that should be under a more > > > specific debug option but isn't"), make it depend on DEBUG_KERNEL and be > > > "default DEBUG_KERNEL" but allow itself to be turned off, and then > > > mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to > > > "#ifdef CONFIG_DEBUG_MISC". > > > > > > Does that sound like an appropriately rapid solution for this bug? > > Sure, that sounds fine to me. Sinan can you take care of that for v4? > > Sure, let me work on this. Thank you both! I really appreciate that.