Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp196285yba; Fri, 12 Apr 2019 01:33:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcecT36VvYvxbQZa42rri6YyP6mfS1kbtgAKB7JK7OYqAM3CpJ2AkkRtmGsIY+HhbI6OI8 X-Received: by 2002:a17:902:8d97:: with SMTP id v23mr21354002plo.298.1555058000877; Fri, 12 Apr 2019 01:33:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555058000; cv=none; d=google.com; s=arc-20160816; b=si/t6TvKkErvlJKhoM+6cowkaJftl4HMXNtJk6w0FVd7WEcCrUKZ7cO6irCbaAEcBj Yfe5EJG7g3fJwIJLVVOV1xCYM7qbrzPN+nPRejRIVmk4Wr7oHpBuIYsYQQEhka3YrKyd /nkI+8z79ZqtYjEx+Pbh4js5yQSMhFrbjLA1sJLTPihTgTeib/IG6v19RmsvtHb1xFHk W+AAQAj+iSJDEkPrv2jbnOyENJtJJ5bgO2uuqC5xczJuNdXZRrL30eHsQhLnaXcb92h/ z6z9oW8Hww5qq33AYc0PSv/SbHs4oyTWaWZCHJM7zkHklOwGHgPpMHQx43gFYh0I4U4o 96AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TCN170+E5a0K5AvAV4xKi9fyH/NfQmKuYSXlGug6uWM=; b=nmMnK3B5Ym+HvxeUO8pJ3hABqOUWEYtFFY1V1PP6jfmZbmTsnNfEMb4B0yW8tLttRy 6XDcK4X+haENeLXyPoc3aOkaqlGm2hlTWHwVHpshNPd9t1f3HNZ/Mq99yIhCZBanaCqZ 4DpnMt3IOx9zS3jJ4nXGj1vDf4GBL1bjgJzH2MwVG2MaRbtMuwtsObLJeNrcDC7Ig1qb 3Xq9qX+EYSxtbMWbCJ6BLpZVRfpgRDLMffKv9O4/7OK8HDbXHZNxPB/+nBx7i6OXvc4N T0SzvaynT6FGPs3QEvTuJwfEElp6IW9THinqEahUHrmnVjuwwJ/4xmHJzm9shRLwMICO +iQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gHSpe3J5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11si39457944plk.270.2019.04.12.01.33.05; Fri, 12 Apr 2019 01:33:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gHSpe3J5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727361AbfDLIbw (ORCPT + 99 others); Fri, 12 Apr 2019 04:31:52 -0400 Received: from mail.skyhub.de ([5.9.137.197]:41594 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbfDLIbw (ORCPT ); Fri, 12 Apr 2019 04:31:52 -0400 Received: from zn.tnic (p200300EC2F0884007C96562F0B339423.dip0.t-ipconnect.de [IPv6:2003:ec:2f08:8400:7c96:562f:b33:9423]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2D35C1EC0429; Fri, 12 Apr 2019 10:31:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1555057911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TCN170+E5a0K5AvAV4xKi9fyH/NfQmKuYSXlGug6uWM=; b=gHSpe3J5a+HzlVQ/cpF45vG014cY36f5o1QhaW3qLYD7SRs34HYh85iMWF9ZFnsMrznV1X Pv9QQyl2NW6JUQd1ZJcktFPW7Lh6D58RRizYAcg5fv/R72z6+JtgOex0zUHsFHd4zq9Qjk OTbYVWMpffy/o5ggZgJKzDoXU+/qQ7E= Date: Fri, 12 Apr 2019 10:31:47 +0200 From: Borislav Petkov To: "Zhao, Yakui" Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, Jason Chen CJ Subject: Re: [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector Message-ID: <20190412083147.GB19808@zn.tnic> References: <1554711131-21514-1-git-send-email-yakui.zhao@intel.com> <1554711131-21514-4-git-send-email-yakui.zhao@intel.com> <20190408150011.GH15689@zn.tnic> <36ff9827-da90-0736-f0a4-2f38b9c8bf3b@intel.com> <20190411135547.GH30080@zn.tnic> <1aaea739-ded7-13da-c2d0-54423de0eab0@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1aaea739-ded7-13da-c2d0-54423de0eab0@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 12, 2019 at 09:00:10AM +0800, Zhao, Yakui wrote: > This is not a problem. > I take a look at the header file of mshyperv.h and xen/events.h. > It seems that they have no such extra conditional definition. > To follow the same style, I will remove it. Yes, the less ifdeffery the better. If it is not really needed. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.