Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp197881yba; Fri, 12 Apr 2019 01:35:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfpEAi731G2tMS2Q2ctj1DlnQFjMa1PwE0Fsnf4wlgB8zFmSOex29XBy4P0HOSkmF9eO08 X-Received: by 2002:a62:14c3:: with SMTP id 186mr56015961pfu.21.1555058133790; Fri, 12 Apr 2019 01:35:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555058133; cv=none; d=google.com; s=arc-20160816; b=STdZD0kVtavv3su3hZ2l325dzRPDWEZqqLUAnC80gu/mTYX7Ka6BeHKk3n+4VFm8dZ QUK17BrBevUl8XH3ZphcfAItV0fH845jVuKKI67pbG856ra/LoAYYnrPr2dSYyz5tncJ 4r5yaIT8HqIKqQZ1vpybmXWRwetWW1xFd6isAZ2PhVUTeXRg+AMWBhMSqDhkY/vySPNY wipigbfuLlazOirithq5smASpgGXXD+st9uRe5rdwsO325+ZHCwvKKjQICodVDfDYWrC W4MNwBH6pYxNnGJOkZnVv7yguTmgiK9NQk/kcxhsq+DGK/664y6u2u2h6qequeZWxRM6 vXBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=IyfiXB13zMaNq8Y+lbFCdTBUGePS14GavTmNYcUEELA=; b=w6as7TzU5I/GQVeskuJ3OOBWQvAXIM8HEkjWSy2A1TiyLXsLdFFvyYtg4GaNcJOd1P 3MoFgXyrYseWs5ilBKqLN+eEPsRXqX1pA2D3swHSxbVlB/ehUUFq2eVYmDHbK6Md6jIJ TXMIH2u5B4oYXoUK2m3qIuIK6SyuUl2PCRCQs+C/+DB+nVxCL9X1GYnqdbREy+nvKR7J ucokCUH4jM/cRdhlV3Gxtgo+DPdSdEKPINYnsCoLkL6cbiIKjHzOFYC1f12lnagu7QiB e0M/67K7L+17T1wNR7NluKJ8jI7Z+T00st2RZyhdlBhR0dhDntnxCJt4E6a7nYASvFge BCsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z13si22624225pgv.334.2019.04.12.01.35.17; Fri, 12 Apr 2019 01:35:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727361AbfDLIeR (ORCPT + 99 others); Fri, 12 Apr 2019 04:34:17 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37847 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbfDLIeR (ORCPT ); Fri, 12 Apr 2019 04:34:17 -0400 X-Originating-IP: 109.213.33.177 Received: from localhost (alyon-652-1-42-177.w109-213.abo.wanadoo.fr [109.213.33.177]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C2CC9C000A; Fri, 12 Apr 2019 08:34:14 +0000 (UTC) Date: Fri, 12 Apr 2019 10:34:14 +0200 From: Alexandre Belloni To: Anson Huang Cc: "a.zummo@towertech.it" , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH] rtc: mxc_v2: use dev_pm_set_wake_irq() to simplify code Message-ID: <20190412083414.GR3578@piout.net> References: <1554948890-21635-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1554948890-21635-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2019 02:19:48+0000, Anson Huang wrote: > With calling dev_pm_set_wake_irq() to set MXC_V2 RTC as wakeup source > for suspend, generic wake irq mechanism will automatically enable > it as wakeup source when suspend, then the suspend/resume callback > which are ONLY for enabling/disabling irq wake can be removed, it > simplifies the code. > > Signed-off-by: Anson Huang > --- > drivers/rtc/rtc-mxc_v2.c | 29 ++++------------------------- > 1 file changed, 4 insertions(+), 25 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com