Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp217725yba; Fri, 12 Apr 2019 02:05:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzaI215WvOIw/u5i2tWv+28KhhTXVA+5bbYpx4Cd7zsn0XRajTZqBz0m0WP0eIktIGYqptM X-Received: by 2002:a63:158:: with SMTP id 85mr52367483pgb.351.1555059911202; Fri, 12 Apr 2019 02:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555059911; cv=none; d=google.com; s=arc-20160816; b=lmyJdilC6KOBfFsFiEnH7kT7164hrfzFetu/wyrAyMgvT5qM+wwArAk0buwXczU14v WyFnywxvLv54L7fu5lNCp8xqBaueMEj4eDU+xj7orG6xgNMoOSY0r7HOhJ8ur1iaxxcp KxSBVV5ZLgxSV5p7jaXIbeEaUmkDoWTG9pNAO+o0McTYqJ79rjTPJRtkVVUbGRPPouFe JKnG8A9LdL+kUEMctIap5bV0KYzCzVMpwcec+2qjhDkhKBVJSLnEcmhN5AtCnBfH/7h8 x+IWrVvRu6WsJV+Regn5orfpKRqMyum4KNHv3ioRaytAR+/sDRPYubNxdlbvAM/gdDFr zKOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=uMd83dbYtT6gk+9SJEBQvS+KS0710Op2qq0zGZyT64U=; b=eWsH0bMIZwytUBYJtelPVIXlK4ciS3gSmNRW6aOa1Cl7crxYRZNk2XphwCXOoTStpr w5f5SDMKn24YqZVYTIfdaBVbhoJd7IYpjvyQgF7zrqpcFE2QfwRQ+BoLaHoNms4AW8lK EbeKOiDFehHAM3E+B3zQxk2w8Een04JQ66YFpu+UGLFkVZGtNcGXBsqF4DqljLxn+D2g f1JB2JE2ZkqxYULr/z4dGXbHgHGYk6DfH/xIlqT9Twk8IeLsvZ+q0mAAYNovqXK+JyYs kvXUEBhY9QGlRHF+ebJMV1+xxEaH66y7vg1soLJfbTBdDh/6dYt9Cry529UuOFYRPmEa Modg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i19si18847540pfr.246.2019.04.12.02.04.54; Fri, 12 Apr 2019 02:05:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbfDLJCl (ORCPT + 99 others); Fri, 12 Apr 2019 05:02:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:40666 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726987AbfDLJCl (ORCPT ); Fri, 12 Apr 2019 05:02:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A553AAE67; Fri, 12 Apr 2019 09:02:39 +0000 (UTC) Date: Fri, 12 Apr 2019 11:02:37 +0200 (CEST) From: Miroslav Benes To: Joe Lawrence cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, linux-kbuild@vger.kernel.org, Jessica Yu , Jiri Kosina , Joao Moreira , Josh Poimboeuf , Konstantin Khlebnikov , Masahiro Yamada , Michael Matz , Nicolai Stange , Petr Mladek Subject: Re: [PATCH v3 3/9] livepatch: Add klp-convert tool In-Reply-To: <20190410182220.GB13083@redhat.com> Message-ID: References: <20190410155058.9437-1-joe.lawrence@redhat.com> <20190410155058.9437-4-joe.lawrence@redhat.com> <20190410182220.GB13083@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Apr 2019, Joe Lawrence wrote: > On Wed, Apr 10, 2019 at 11:50:52AM -0400, Joe Lawrence wrote: > > > > [ ... snip ... ] > > > > diff --git a/scripts/livepatch/klp-convert.c b/scripts/livepatch/klp-convert.c > > new file mode 100644 > > index 000000000000..62bd26941081 > > --- /dev/null > > +++ b/scripts/livepatch/klp-convert.c > > > > [ ... snip ... ] > > > > + if (argc != 4) { > > + WARN("Usage: %s ", argv[0]); > ^^^^^^^^^^ > nit: since we're using .klp.o prefix, should this be "input.klp.o" I'd leave input.ko there. It is clear then that it is an ordinary kernel module and nothing special, but it is up to you. I would change out.ko to output.ko for consistency. Miroslav