Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp338464yba; Fri, 12 Apr 2019 04:45:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwlwBABPwFV9YU1KB2jDzsEJFLA2YoEWfSPAFcBJFfJO+rsJdElxFfWH19b/AO15I4pkinr X-Received: by 2002:a62:184a:: with SMTP id 71mr37473952pfy.1.1555069556668; Fri, 12 Apr 2019 04:45:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555069556; cv=none; d=google.com; s=arc-20160816; b=agbsdnFhMl70MxGutQsB+b1EEwT/Q6iuYjaHlyuUnEh5Fx9eDmKxzFRj15CHVpux91 r/9hIPKvldLtPtgYXdVOS4keFH97zlrMVxGhFlfdi4Bv/rbHHm8K61tNKMW7GSE8UAkY gcNHrxurymC7CFyszwqKpkWrOD3zbS3aV4XChTH9MSrMSRxcSZ6FZphEGq8+zkdXPSPY m6dHDkrFl8CdYKKFmSRq6XlJmVKY0+bdsdB2qG9CpNXf9xEDwKPgvosTvw+AM1rQ3jX/ 658bvDgvqlXqLNE/cUcgfc9TbfEU+cuRJxBfXY73g+mpo1sElQBF+8S+AVohpP7S//Fa VoWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=MmdEM0VOtK5V8lgasVnZw+dYzJVl2pWF/XZFWknP6dg=; b=zevkDtMeRWFBtC4GBYHY1INSq3EzYC7C0XPIdvIwA5uUHs7zTud/f/5omIOPY7XTWG 5KAMwdGJyPedeq8JHzFCsDpPRcsazoN4fwMoDue2Uz6f5g8/Uec2XPJxMsJkllCptVNi h7ix6ourflfdvSlNG/9SvSmmEFBm7vzUdKgJHVN2P04U4wYK+N1KPd95YO9NgK6WUXdd 8igmxQSgRiowIySnmkuf+1By2POetmXtLBckGIUk71k2v/+MDFpiSiZ/zJ23Y71+8h9c 7QH3TEw8jDp0XK5mQL99HA1wA0rkg8mWGrvCTzk06jKXlogPvI189hWTFQDclkz+tbpE EnGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7si28990046pgc.307.2019.04.12.04.45.40; Fri, 12 Apr 2019 04:45:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbfDLLpG convert rfc822-to-8bit (ORCPT + 99 others); Fri, 12 Apr 2019 07:45:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:40246 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726714AbfDLLpF (ORCPT ); Fri, 12 Apr 2019 07:45:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 780D8AC89; Fri, 12 Apr 2019 11:45:04 +0000 (UTC) Date: Fri, 12 Apr 2019 13:44:59 +0200 From: Thomas Bogendoerfer To: Alexandre Belloni Cc: Joshua Kinard , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] rtc: ds1685: use correct device struct to get platform device struct Message-Id: <20190412134459.446ef705c86aa1c7b926abc7@suse.de> In-Reply-To: <20190412101106.GU3578@piout.net> References: <20190411143323.20945-1-tbogendoerfer@suse.de> <20190411143323.20945-2-tbogendoerfer@suse.de> <20190412101106.GU3578@piout.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Apr 2019 12:11:06 +0200 Alexandre Belloni wrote: > Every patch need a commit message. Maybe you could indicate that this > never gave any issue because parent is the first member of struct > device. I'll update the commit message, I get a nice stacktrace because of that bug, so the path from work_queue calling ds1685_rtc_poweroff never worked. Thomas. -- SUSE Linux GmbH GF: Felix Imend?rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N?rnberg)