Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190411093024.23555-1-brgl@bgdev.pl> <20190411093024.23555-4-brgl@bgdev.pl>
 <4a022050-73ad-cbed-bf30-416abb2196e0@ti.com>
In-Reply-To: <4a022050-73ad-cbed-bf30-416abb2196e0@ti.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Fri, 12 Apr 2019 14:12:36 +0200
Message-ID: <CAMRc=MeCxEM+q2m55_2LV6C9kLxJqZqtQytNrsdO5AiV6rT8gA@mail.gmail.com>
Subject: Re: [PATCH v4 3/6] usb: ohci-da8xx: disable the regulator if the
 overcurrent irq fired
To:     Sekhar Nori <nsekhar@ti.com>
Cc:     Kevin Hilman <khilman@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-usb@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

pt., 12 kwi 2019 o 12:39 Sekhar Nori <nsekhar@ti.com> napisa=C5=82(a):
>
> Hi Bartosz,
>
> On 11/04/19 3:00 PM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Historically the power supply management in this driver has been handle=
d
> > in two separate places in parallel. Device-tree users simply defined an
> > appropriate regulator, while two boards with no DT support (da830-evm a=
nd
> > omapl138-hawk) passed functions defined in their respective board files
> > over platform data. These functions simply used legacy GPIO calls to
> > watch the oc GPIO for interrupts and disable the vbus GPIO when the irq
> > fires.
> >
> > Commit d193abf1c913 ("usb: ohci-da8xx: add vbus and overcurrent gpios")
> > updated these GPIO calls to the modern API and moved them inside the
> > driver.
> >
> > This however is not the optimal solution for the vbus GPIO which should
> > be modeled as a fixed regulator that can be controlled with a GPIO.
> >
> > In order to keep the overcurrent protection available once we move the
> > board files to using fixed regulators we need to disable the enable_reg
> > regulator when the overcurrent indicator interrupt fires. Since we
> > cannot call regulator_disable() from interrupt context, we need to
> > switch to using a oneshot threaded interrupt.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> I thought a bit on whether it makes sense to merge this patch into 6/6
> since that is modifying some code you introduce here. But I think its
> probably better to keep it separate like you have it now.
>
> 6/6 is about dropping support for vbus gpio, where as here you are
> letting regulator be used for handing overcurrent detected using oci gpio=
.
>
> Having it separate makes it possible to revert dropping support for vbus
> gpio while keeping this functionality ;)
>

These two changes were together in v1, but I too think that having it
separate keeps the series bisectable.

Bart

> > -static irqreturn_t ohci_da8xx_oc_handler(int irq, void *data)
> > +static irqreturn_t ohci_da8xx_oc_thread(int irq, void *data)
> >  {
> >       struct da8xx_ohci_hcd *da8xx_ohci =3D data;
> > +     struct device *dev =3D da8xx_ohci->hcd->self.controller;
> > +     int ret;
> >
> > -     if (gpiod_get_value(da8xx_ohci->oc_gpio))
> > -             gpiod_set_value(da8xx_ohci->vbus_gpio, 0);
> > +     if (gpiod_get_value_cansleep(da8xx_ohci->oc_gpio)) {
> > +             if (da8xx_ohci->vbus_gpio) {
> > +                     gpiod_set_value_cansleep(da8xx_ohci->vbus_gpio, 0=
);
> > +             } else if (da8xx_ohci->vbus_reg) {
> > +                     ret =3D regulator_disable(da8xx_ohci->vbus_reg);
> > +                     if (ret)
> > +                             dev_err(dev,
> > +                                     "Failed to disable regulator: %d\=
n",
> > +                                     ret);
> > +             }
> > +
>
> Unnecessary empty line here, that too one that introduces white space
> error. Please drop.
>
> Thanks,
> Sekhar