Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp395262yba; Fri, 12 Apr 2019 05:55:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnvu/xqabyz7BO8OjtDfApzsTM0dwiCa086EmqLVe4HteQlJ6CWkQxuq9ca8/PKF1liofL X-Received: by 2002:a62:424f:: with SMTP id p76mr56642530pfa.141.1555073737527; Fri, 12 Apr 2019 05:55:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555073737; cv=none; d=google.com; s=arc-20160816; b=Sg7nQ9eN9+ImVEY/dpQy4xrl8ZhjmzUjTuk7ui51Wk605wLWr7CAVWao8D7gzdBAyc PGiDoyWP3V0Bq8hVYgQraYSWwpJwR7hM5VWBUU6lSoT3eQHgEFBHs9kiUtzShcUFm1ay jrGOAuOfDwfR7NU+UgfkIXtzPkSkQqo74vPXWA0phrnT3x1ghcQc+2Ym5FWA46PRP3i4 wydJ3pBa1s4dcnKhll8iUtB843bs5cgdVtKSlwRE+CYOtpTcaVPtsJgrXMD9EmRojqVV 3r6TFaR+DTc41kScOYgYC9+Jl7FG9Ioi2YIyVP6P5wMTUUP9bx/olUnsrRU4b2qWNnDV /nKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=RLtemCZL9lzmYgqDcvAUxhmFKgU2R8f0ZbX40nXW48M=; b=LOLaLTln9XPcUrYhoH2NeY92CMXXoxhq/0SF+pNY+hpjm18O/d5bqpv6hbJOEjuraR gjFPD/d8xbHP3V5iCoL+7NG96/Y7Kg241RVVB16pEruu/4nS3eFywJ5rVfcgOpaF2zzL fHtH89jWWi6wYIRfBr1Rb9r6mlKdqAZLpTW1yTKbH1Aeys40GvgdJCZ9JQtQOEBdjsM0 vL/XlSjJrYb5Bru1W4TDKQlkS2Im0yvuJgvkRjjVMD90u8rrHFAd5ERHVKstyvR6BWLn iKZzGibnMadO40Rz5m4Q3D6Sg/0MEilXGHrzg2pPb08Yf8XXIjtM8m4YUrFJhLhCUUU1 lOHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b="RPj+yw/l"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si36946360plr.376.2019.04.12.05.55.21; Fri, 12 Apr 2019 05:55:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b="RPj+yw/l"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727272AbfDLMym (ORCPT + 99 others); Fri, 12 Apr 2019 08:54:42 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:38864 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726714AbfDLMym (ORCPT ); Fri, 12 Apr 2019 08:54:42 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3CCl5t4001193; Fri, 12 Apr 2019 14:54:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=STMicroelectronics; bh=RLtemCZL9lzmYgqDcvAUxhmFKgU2R8f0ZbX40nXW48M=; b=RPj+yw/lZRVNg9cq1w8AkaHVIHeS5K76CJ6ap23XdcXPevQx4UAl1wJB8dBr3+r7e1SD NG8+Ss2wNgDq/xMHQnE1C9UWvbJ+5mB2n2XXFtkBn88VHlaRGkmq4qiDo5BEdsAZTzRn RNk/Yw/Od8Ex9pCsbaGSPfBtz078TDzF2lpVDzGvj4cPnUMlNpcCniUrWKsvjlqeFcvb NPzPLpCWlqA5L7wN4CzVYrbO+J3anVGZ0CbO3gFBHqgVLvhv5TCe9Kq5j2GQSeA+ut3B JJezBSJwzjrcO6muRmji3gmDrYPOnhLuqKTULOPIlE8MK8nWkbazN36XZW2BCClhffY5 Fw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rpr7x584p-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 12 Apr 2019 14:54:33 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 39B1331; Fri, 12 Apr 2019 12:54:32 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas22.st.com [10.75.90.92]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1E1CD2520; Fri, 12 Apr 2019 12:54:32 +0000 (GMT) Received: from SAFEX1HUBCAS21.st.com (10.75.90.45) by Safex1hubcas22.st.com (10.75.90.92) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 12 Apr 2019 14:54:31 +0200 Received: from localhost (10.201.23.25) by Webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 12 Apr 2019 14:54:31 +0200 From: Fabien Dessenne To: Jiri Kosina , Benjamin Tissoires , , CC: Fabien Dessenne Subject: [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter Date: Fri, 12 Apr 2019 14:54:17 +0200 Message-ID: <1555073657-24386-1-git-send-email-fabien.dessenne@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.25] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-12_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The second parameter of devm_add_action_or_reset() shall be a function, not a function address. Signed-off-by: Fabien Dessenne --- drivers/hid/hid-rmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 9e33165..8748d4d 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -623,7 +623,7 @@ static int rmi_setup_irq_domain(struct hid_device *hdev) if (!hdata->domain) return -ENOMEM; - ret = devm_add_action_or_reset(&hdev->dev, &rmi_irq_teardown, hdata); + ret = devm_add_action_or_reset(&hdev->dev, rmi_irq_teardown, hdata); if (ret) return ret; -- 2.7.4