Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 12 Apr 2019 08:40:51 -0700
From:   Tony Lindgren <tony@atomide.com>
To:     Nathan Chancellor <natechancellor@gmail.com>
Cc:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Ladislav Michl <ladis@linux-mips.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
        Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove
 omap_dm_timer_set_load_start
Message-ID: <20190412154051.GW2839@atomide.com>
References: <20190327050126.12064-1-natechancellor@gmail.com>
 <20190327081142.GA11034@lenoch>
 <20190404141730.GE49658@atomide.com>
 <6defcea8-1e94-14ac-f9c5-e14c61ea4d99@linaro.org>
 <20190410200748.GN2839@atomide.com>
 <b8a177ee-0058-2730-4c95-56834f6bafd4@linaro.org>
 <20190411205657.GT2839@atomide.com>
 <20190412045954.GA30291@archlinux-i9>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190412045954.GA30291@archlinux-i9>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Nathan Chancellor <natechancellor@gmail.com> [190412 05:00]:
> On Thu, Apr 11, 2019 at 01:56:57PM -0700, Tony Lindgren wrote:
> > Hi,
> > 
> > * Daniel Lezcano <daniel.lezcano@linaro.org> [190411 19:21]:
> > > On 10/04/2019 22:07, Tony Lindgren wrote:
> > > > Hi,
> > > > 
> > > > * Daniel Lezcano <daniel.lezcano@linaro.org> [190410 17:02]:
> > > >> can you ask for an acked-by before pulling a patch in your tree?
> > > > 
> > > > I certainly do ask and wait for acks where possible :)
> > > 
> > > Ok, I may have missed them.
> > > 
> > > > Note that I have not applied this patch. I just added
> > > > Keerthy to Cc on this thread so maybe you misread the
> > > > message earlier. My comment "seems like no other
> > > > takers" was for Ladislav regarding somebody picking up
> > > > his earlier work, not for picking up this patch :)
> > > 
> > > Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
> > > above I could have miss your call.
> > 
> > Hmm so commit 592ea6bd1fad was part of the PWM timer series
> > that was posted several times from late 2017 to end of
> > February 2018. I did not get any timer related acks or
> > comments so I applied it together with the PWM timer
> > changes.
> > 
> > I'm guessing you may have accidentally checked out some
> > older deja-vu branch from about a year ago? Commit
> > 592ea6bd1fad is not related to this fix.. :)
> > 
> 
> Just for the record, I said this patch fixes 592ea6bd1fad because
> 592ea6bd1fad should have been marked this function as static, which
> would have exposed that this function was unused and it could have
> been removed at that time. I know it is a bit of a stretch for this
> commit (would be more appropriate for 008258d995a6 to have it) but
> that was my logic behind it. Not opposed to having it removed before
> committing.

Oh OK yes they should have all become static with the PWM
series.

Regards,

Tony