Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 12 Apr 2019 23:52:43 +0800
From:   kbuild test robot <lkp@intel.com>
To:     Nick Crews <ncrews@chromium.org>
Cc:     kbuild-all@01.org, enric.balletbo@collabora.com,
        bleung@chromium.org, sre@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, dlaurie@chromium.org,
        lamzin@google.com, bartfab@google.com, derat@google.com,
        groeck@google.com, dtor@google.com, sjg@chromium.org,
        jchwong@chromium.org, Nick Crews <ncrews@chromium.org>
Subject: [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci
 warnings
Message-ID: <20190412155243.GA26871@lkp-ivb-ep02>
References: <20190412002055.92529-2-ncrews@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190412002055.92529-2-ncrews@chromium.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: kbuild test robot <lkp@intel.com>

drivers/platform/chrome/wilco_ec/charge_config.c:173:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 08c1b2e2e50e ("power_supply: platform/chrome: wilco_ec: Add charging config driver")
CC: Nick Crews <ncrews@chromium.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-Add-more-charge-types-and-CHARGE_CONTROL_-properties/20190412-211253

 charge_config.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/platform/chrome/wilco_ec/charge_config.c
+++ b/drivers/platform/chrome/wilco_ec/charge_config.c
@@ -170,10 +170,7 @@ static int wilco_charge_probe(struct pla
 
 	psy_cfg.drv_data = ec;
 	psy = devm_power_supply_register(&pdev->dev, &wilco_ps_desc, &psy_cfg);
-	if (IS_ERR(psy))
-		return PTR_ERR(psy);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(psy);
 }
 
 static struct platform_driver wilco_charge_driver = {