Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH 0/4] mm: memcontrol: memory.stat cost & correctness
Thread-Topic: [PATCH 0/4] mm: memcontrol: memory.stat cost & correctness
Thread-Index: AQHU8UKSRitH7aU5pEyAQQGRGu7VMKY5FLwA
Date:   Fri, 12 Apr 2019 22:04:02 +0000
Message-ID: <20190412220357.GA18999@tower.DHCP.thefacebook.com>
References: <20190412151507.2769-1-hannes@cmpxchg.org>
In-Reply-To: <20190412151507.2769-1-hannes@cmpxchg.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::1:2586]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d2834e93-225c-4f32-794d-08d6bf92c5b3
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020);SRVR:BYAPR15MB2679;
x-ms-traffictypediagnostic: BYAPR15MB2679:
x-microsoft-antispam-prvs: <BYAPR15MB2679F7B13A86BB2E8B6A1E2EBE280@BYAPR15MB2679.namprd15.prod.outlook.com>
x-forefront-prvs: 0005B05917
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(376002)(136003)(396003)(39860400002)(366004)(199004)(189003)(106356001)(6246003)(105586002)(71190400001)(8936002)(229853002)(71200400001)(6506007)(386003)(7736002)(6486002)(33656002)(476003)(186003)(86362001)(486006)(446003)(68736007)(2906002)(1076003)(5660300002)(14454004)(11346002)(46003)(102836004)(99286004)(478600001)(81156014)(6916009)(52116002)(76176011)(81166006)(305945005)(8676002)(4326008)(316002)(25786009)(256004)(9686003)(6512007)(54906003)(6436002)(6116002)(53936002)(97736004);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB2679;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: Kvoj+NfNBjDXlBETeDzWIqqgsH8KbEFAt2j71KDTMrbXCNjriKjWOGd+oegkTTPjXh8TvZjJDTncvfdXcQZSpnSm8DRB2U5k/skdhSzzOHcFqw0wTZ/tu2hcZtyPPtdx0KxSzTVL5w3ykL0ZBZ5qeBDCQcUrvgsp6giHkoDOqYdeEbGlCeOKrhVtqq0ReMyruq+rxaYUboygr+N6mn6H/1IN95i8Vecb0PiznZTz5ca415RXMAVRVdMr7Gj9aIp8trW4f/xDSTzs5X7CQ8KIbzfMheWl1zLmFmV1QzWcTn7c4xGt68pwQupBz2SdDrhlGYkFZX6oXZw5ibY6z7NnYfkrrXV/7v+ieeojGfQ9boyzwNp0SIvLrI5R/xS4B1acgf4UVtCPzb8kulHNZJZ4azxI8sJPN0GxNaPc+p+8/uk=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <25150709FC40BE4791F4051712207847@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d2834e93-225c-4f32-794d-08d6bf92c5b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 22:04:02.5229
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2679
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-12_11:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 12, 2019 at 11:15:03AM -0400, Johannes Weiner wrote:
> The cgroup memory.stat file holds recursive statistics for the entire
> subtree. The current implementation does this tree walk on-demand
> whenever the file is read. This is giving us problems in production.
>=20
> 1. The cost of aggregating the statistics on-demand is high. A lot of
> system service cgroups are mostly idle and their stats don't change
> between reads, yet we always have to check them. There are also always
> some lazily-dying cgroups sitting around that are pinned by a handful
> of remaining page cache; the same applies to them.
>=20
> In an application that periodically monitors memory.stat in our fleet,
> we have seen the aggregation consume up to 5% CPU time.
>=20
> 2. When cgroups die and disappear from the cgroup tree, so do their
> accumulated vm events. The result is that the event counters at
> higher-level cgroups can go backwards and confuse some of our
> automation, let alone people looking at the graphs over time.
>=20
> To address both issues, this patch series changes the stat
> implementation to spill counts upwards when the counters change.
>=20
> The upward spilling is batched using the existing per-cpu cache. In a
> sparse file stress test with 5 level cgroup nesting, the additional
> cost of the flushing was negligible (a little under 1% of CPU at 100%
> CPU utilization, compared to the 5% of reading memory.stat during
> regular operation).
>=20
>  include/linux/memcontrol.h |  96 +++++++-------
>  mm/memcontrol.c            | 290 +++++++++++++++++++++++++++------------=
----
>  mm/vmscan.c                |   4 +-
>  mm/workingset.c            |   7 +-
>  4 files changed, 234 insertions(+), 163 deletions(-)
>=20
>=20

For the series:
Reviewed-by: Roman Gushchin <guro@fb.com>

Thanks!