Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 13 Apr 2019 10:19:41 +0200
From:   Thomas Bogendoerfer <tbogendoerfer@suse.de>
To:     Joshua Kinard <kumba@gentoo.org>
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] rtc: ds1685: use correct device struct to get
 platform device struct
Message-Id: <20190413101941.fb76cdf06f476d7353d439b7@suse.de>
In-Reply-To: <462d6bfd-c91a-3c5c-1dfd-69d8b48449e6@gentoo.org>
References: <20190411143323.20945-1-tbogendoerfer@suse.de>
        <20190411143323.20945-2-tbogendoerfer@suse.de>
        <20190412101106.GU3578@piout.net>
        <20190412134459.446ef705c86aa1c7b926abc7@suse.de>
        <462d6bfd-c91a-3c5c-1dfd-69d8b48449e6@gentoo.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 13 Apr 2019 01:17:19 -0400
Joshua Kinard <kumba@gentoo.org> wrote:

> On 4/12/2019 07:44, Thomas Bogendoerfer wrote:
> > On Fri, 12 Apr 2019 12:11:06 +0200
> > Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
> > 
> >> Every patch need a commit message. Maybe you could indicate that this
> >> never gave any issue because parent is the first member of struct
> >> device.
> > 
> > I'll update the commit message, I get a nice stacktrace because of that
> > bug, so the path from work_queue calling ds1685_rtc_poweroff never worked.
> > 
> > Thomas.
> 
> I'll wager that's why the thing stopped powering off my Octane.  It *used*
> to work when I wrote the driver, but stopped after some unidentified point,
> and I never found the time to try and track it down.

calling ds1685_rtc_poweroff with the correct platform device works, so the bug is
not in the poweroff function but in the work queue.

> Which machine are you testing on, out of curiosity?

SGI Octane but I'm not setting prepare_poweroff.

Thomas.

-- 
SUSE Linux GmbH
GF: Felix Imend?rffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG N?rnberg)