Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp310035yba; Sat, 13 Apr 2019 01:21:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfi9UzshTxak77T7ah6yKwMJz4yB8T5pjqbLK+u8BsbwU32/DuilUFceOELmqYAe61C5Ax X-Received: by 2002:aa7:8b12:: with SMTP id f18mr62193337pfd.89.1555143668216; Sat, 13 Apr 2019 01:21:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555143668; cv=none; d=google.com; s=arc-20160816; b=KJDcbvkIrKKGM6S3UtYTLSk9CX1zn70kyVPHAJaCYCdOxyk+cNPclc98m4/0G5UR/r f0vKyQ1a2YcLj1C0iw3Tf7gAosJ/jy/XLk6/t7etiQKkFZ8UBcnn6foMr7YzLiyM4QAw hlaRmh2Vorhae1r2QDrzT2Pi9v1neYv76CaIqSdfGJxhiPJ6/x6IDgVpu0KM9ZbTmOHI X0QrYF64UKY+0e5IuoaNIiEOn/DbgVpOCo34I9TO7LepfGSNZqRpiRWXyBvBqqyuBJ4b iXBpSbTWzAJZ7p7W3k+wbP9fkcyt4KH2u/K6qBA2Hw0QJEanSZKyAMU/exUDETv5LCIs rClg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=H2DDkqhBjIBIdUiGw3/juP4N20Szt0+UvvZM1/QEbtg=; b=Od/RocqpIoM4PqpMEt20vz6b+D+06XbJG5sfvI9408OQ6JBBYcBqJcgjjvV7liXfAz 0VVAABE1grRcNWRsiNCpBfehmo9A+mwn69WlY+y64bh/XqUpYGMa9uVwV6/GjD0MWdsI Y302tJjpezC5HfqMVrYkc5Rdq3QOutOzlihop0FssS70Z9SE9cSnzhPkCUH4NAN1q3r+ epaN32ztL+Hczga9XgSTrJN05IqMxwNev6L+AFvRdV/OyMtPvWSpzY8zEkwKLJEkWOkI pNBvoWYlWY3WjhsBFGIgYvrmjdrOicybY0s0k7z5dO4Md5yL07Zah6U7S6Qmly6EpEBf rihQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f69si38959309pgc.103.2019.04.13.01.20.52; Sat, 13 Apr 2019 01:21:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727144AbfDMITn convert rfc822-to-8bit (ORCPT + 99 others); Sat, 13 Apr 2019 04:19:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:41580 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725776AbfDMITn (ORCPT ); Sat, 13 Apr 2019 04:19:43 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AC0C3B02C; Sat, 13 Apr 2019 08:19:41 +0000 (UTC) Date: Sat, 13 Apr 2019 10:19:41 +0200 From: Thomas Bogendoerfer To: Joshua Kinard Cc: Alexandre Belloni , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] rtc: ds1685: use correct device struct to get platform device struct Message-Id: <20190413101941.fb76cdf06f476d7353d439b7@suse.de> In-Reply-To: <462d6bfd-c91a-3c5c-1dfd-69d8b48449e6@gentoo.org> References: <20190411143323.20945-1-tbogendoerfer@suse.de> <20190411143323.20945-2-tbogendoerfer@suse.de> <20190412101106.GU3578@piout.net> <20190412134459.446ef705c86aa1c7b926abc7@suse.de> <462d6bfd-c91a-3c5c-1dfd-69d8b48449e6@gentoo.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Apr 2019 01:17:19 -0400 Joshua Kinard wrote: > On 4/12/2019 07:44, Thomas Bogendoerfer wrote: > > On Fri, 12 Apr 2019 12:11:06 +0200 > > Alexandre Belloni wrote: > > > >> Every patch need a commit message. Maybe you could indicate that this > >> never gave any issue because parent is the first member of struct > >> device. > > > > I'll update the commit message, I get a nice stacktrace because of that > > bug, so the path from work_queue calling ds1685_rtc_poweroff never worked. > > > > Thomas. > > I'll wager that's why the thing stopped powering off my Octane. It *used* > to work when I wrote the driver, but stopped after some unidentified point, > and I never found the time to try and track it down. calling ds1685_rtc_poweroff with the correct platform device works, so the bug is not in the poweroff function but in the work queue. > Which machine are you testing on, out of curiosity? SGI Octane but I'm not setting prepare_poweroff. Thomas. -- SUSE Linux GmbH GF: Felix Imend?rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N?rnberg)