Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] block, Kconfig.iosched: set default value of IOSCHED_BFQ
 to yes
To:     Paolo Valente <paolo.valente@linaro.org>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        ulf.hansson@linaro.org, linus.walleij@linaro.org,
        broonie@kernel.org, bfq-iosched@googlegroups.com,
        oleksandr@natalenko.name, Anders Roxell <anders.roxell@linaro.org>
References: <20190413091626.20286-1-paolo.valente@linaro.org>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <802d43e0-1954-ddb8-9da6-973742e1bfb6@kernel.dk>
Date:   Sat, 13 Apr 2019 07:05:54 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190413091626.20286-1-paolo.valente@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/13/19 3:16 AM, Paolo Valente wrote:
> When I added bfq to Kconfig.iosched, I forgot to add the line that
> sets to yes the default value of IOSCHED_BFQ, as it is the case for
> the other two I/O schedulers. Such a piece of information is used by
> popular build systems, when making kernel configs automatically. So,
> the lack of this line for bfq makes it hard and confusing to have bfq
> in the kernel generated by these systems.
> 
> This commit adds this missing line.

This only makes sense to do for newly introduced symbols. Apart from
that, we should not default to 'y' (or 'm' for that matter) what isn't
strictly needed. Looking at the io schedulers, kyber shouldn't have had
that added.

-- 
Jens Axboe