Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1352408yba; Sun, 14 Apr 2019 07:46:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwYPcW9iZTASt6e6ssJJzxKuWVkFv5klb2CJqZN6gO2WM3iDY/PBaR0oUokt2JY7e4lxohO X-Received: by 2002:a17:902:2b88:: with SMTP id l8mr66354225plb.262.1555253205178; Sun, 14 Apr 2019 07:46:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555253204; cv=none; d=google.com; s=arc-20160816; b=l3+M9obHEa/IrUO7ixNCw+YLRWbrMeJNUwwATVoSrk5wTX1EAAi7nYQTiJu5/g55P0 pre+dPZcqdNs5sxf+YPes03MnPEZD5kE2YLqF8BEd+DJIekUK8NBHfMACzMzgR1LIG+w D5+qtrA8OJMDfMNn++3NepHlerW6Gfvxo3QJqualla+QHVfqqz3peRLtPGlOeraK488E mO6Bm/4Y1dd7c/EHfMrWXQmzusWFWbIa/0T+x++QUtPn9TOPbW60qX0UVTAXSwFjclCU FhjcPjQiUegVL+3tTGocLf7pN1FDz2LD45WLb8tOVol2mtYtDMlSixYNK/8xp8fY6cJA 97SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:subject:references:cc:to :dkim-signature; bh=6k2VyQ2I7ERYFmptXy6cXM3R4TvH1nnPnAIhEJZ2PS8=; b=mnSM1ClN6TjznBt/WNf8UrKx3VJE9Ael9/HQBCwX59lv4t5c9aGf4AjfpyKhqfzPkU YA0mybJf/WqdURYMuVTT0DsWX2raMJOAhrwjEm8g689/MCb8FJk7JydCfXwztPPxUXMP O+G11iQeHNygDs4P0bwcm9D1X7c0hSM7KVA+gVaQfgXuoRbrnS6QMpu0zy1EEqMDtDIt r9FNW1FviXjRhEJ3t+gSkvILdKU33cikT0e3OV9p2jzJN4vb5kut4R1OU+ZKXkEc2rRj 7HvW+0sgRr9LWXjMx8S2ACwwIfWSSge+go+gXunHdFiajOhmmaN8Q4b5hkGo+uPyWqaw 7DKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=LtRGSrfw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o185si36629499pga.164.2019.04.14.07.46.14; Sun, 14 Apr 2019 07:46:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=LtRGSrfw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726695AbfDNOpS (ORCPT + 99 others); Sun, 14 Apr 2019 10:45:18 -0400 Received: from mout.web.de ([212.227.17.12]:40609 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbfDNOpS (ORCPT ); Sun, 14 Apr 2019 10:45:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1555253112; bh=3XTSfgvXmiyG+AX6BpAFsklP8la+fCQz5wb0+JB2wFE=; h=X-UI-Sender-Class:To:Cc:References:Subject:From:Date:In-Reply-To; b=LtRGSrfwklOPUMSxlYMOcflsaOOfqLSvRFhX2iWei3bb6WlmPqq82Czg9GPa7jvdX FMWlRlNo6UA6VJPrD72eETE2nigWBqaZGxOR4MbTwdiMjs+UuQ6oJZuzL03h4uk4X2 KxtOJ9ykTHIrG466asEuzK0qIh2UzOX8LztyQtbg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.133.103.133]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LgpVS-1gU1DK2j0I-00oC5I; Sun, 14 Apr 2019 16:45:12 +0200 To: Julia Lawall , Robin Murphy , linux@arm.linux.org.uk Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1550928043-14889-2-git-send-email-Julia.Lawall@lip6.fr> Subject: Re: [PATCH 01/12] arm-cci: add missing of_node_put after of_device_is_available From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <2c56bdcb-9354-c719-13df-38b5f1974f10@web.de> Date: Sun, 14 Apr 2019 16:45:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1550928043-14889-2-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:1krWaYhDgCe3xW+hUeCzrx2UavRb6uGicSKlUMnJ/oSN7K39fbG CpsL/hxu5PKBPyBDHimv6XI+TW3lbDcudbbDfGJ838T3Rpq1G7FRbrcaLGtJMmKtil/gtDj ASl0bEVmm3dOA4oXqCLQFTdgRTY+PiM9hPfLA657RUnF+AyYWmvXwwtuuX/CwQyjnz7vKgv uqJvfvBmNgllhdjGFO2uw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:c4gzb1UDss4=:uCZa4SbKOMRZSBW2/eZveS FpNLEJ/sv5Twgr4N5CSWl3BcviBdIyzx848kq8Yi1sBuwVxcgoC9gDPAQPRdh47qtWMC21W2s ReaQ1R2wfZM8RhlqMqnPWEi4wW3+/f9i3I+PkTJWBBeVxRvpLq0z1ycOlHUNSYsh+UKneGEpF w7LN0XQsgf5KFkmgDSocoC8VIwpFS1bnBmEw+PtAmbPxSu/VEVBQ1YB5046vgOEd0xkFLrK0M rtvDpG1mwqyXp9cwhCcKaO5pVUW3ekvwpSAIwwxc2yqZnr9+Zvcclao/C08EtE8CZyRzkAPB5 8Onj3PINRwZBKYlt12HfIxE6Yqw01hbe5S9IcbWsQ4RfAw4t7QX9u1vGK/7ukokFfb0XE8rsA 7xX2YAY07L14wKsZgTGwUzKOZrxAkpzeA9w3RKJAaknyzNyf6P6f6xu43Yb+PAy9bdcidYtRz fto+WBVBwexEIFajyxZSX8bEXSUmkb5JpC+c4Lk8PAJ9V2cwuZXhbkuNW2NjoTTQribBzuhWE BaGATKZ9otRow17QYuCIbgxPS3/dII++rVhBeJUsSI5rR2IoNG7W2t6/nlRH4miyppACgx1Uv G9+pugFbYVZ4LnHa6IOXlr5Ay6tXh/zSSGj0b+DlIwc0DNV3CEPmeqGb6dE0lOURcJDDPrkHT B2x2oJ1De5mI6Q1isHvZfTJMLdoA+8TAmX3ASM0gxIgJnP/N06DRii/81zUxAR5Zf9vVFTz0p THwRnMAcOCgtcWc9Kz+Zm3U6xHd0+opXhNkPculvM91iLGC7pjyqtjXEf3jT7vgRAvXw3YCti bWoZIApDJxbRonp5HywrWSemXYsGZRDITGtcZEBDApFLfm/ZH4anbEgdsWf1cbuR8EMQTFIpV b/7LQl8w+gNWvUU4RKf0jD0nZogZ/s44n89xbB8gf/ShIKYyXjXGg81bt1MzTyKO84+DIDZVE XIHuPIq4LTw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -538,8 +538,10 @@ static int cci_probe(void) > struct resource res; > > np =3D of_find_matching_node(NULL, arm_cci_matches); > - if (!of_device_is_available(np)) > + if (!of_device_is_available(np)) { > + of_node_put(np); > return -ENODEV; > + } > > ret =3D of_address_to_resource(np, 0, &res); > if (!ret) { How do you think about to move this function call to an additional jump ta= rget for the desired exception handling? Regards, Markus