Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1380938yba; Sun, 14 Apr 2019 08:29:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzLuMxKIbRHHInuiAbb5MRbYX+rHuudj2s/gFlMVzc6v6PtUh/2n18QJeo1yYHLjKPLrXAU X-Received: by 2002:a62:4649:: with SMTP id t70mr70221365pfa.100.1555255785289; Sun, 14 Apr 2019 08:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555255785; cv=none; d=google.com; s=arc-20160816; b=ZxipgoQDSDdfZOTJn2ztEZLEPxhNAqjW4l4XLWhsL9sqayPXbYhPPch6c689fW9m/O EnXfGMCmM0+w1J4OM87StIzgX1i8GPZqCalfFS/DE4GGA2T2VPa42tytCmPAILAfz3tP vIfkitecEITm6a9g7IvxlPQCEbeR+wfS97hnI2aqeqMmBDMKjPpndv6LqnFrHIKpLLHm o9E4n9gOsqXxoI49gJ01jlwhqvY8M6iS3d4EIJZnsq9tvDgC9ofsmA2tOMT3eyFpEnuU RaCk4NMZAGmErggmIvx/BalBvYt1TcKNRbocVNk2PNK4vnko80TFRdqVugrNDdX4A6SW S60A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:subject:references:cc:to :dkim-signature; bh=+Q4K8pPhSdC0LmT+BGOzU/MvLHPRSUAko26TRfyuEJ0=; b=He7xGTi2BaKauOs2CHwnsG+jOk6PITQsplnZWKjG9T76EXMxBF8T78alwquZN6/5CS zXkq7PaJ8cpI8IteZ9HpmKsRHQxzAh09CwtHyOQOb58lbmvsVhOvOdGoYaln3ytEeqta mXSig7edR5gtSHlCqVCVnR62I+zmG8H0F9u0pVPlXLD+DY/R7GYzCrEKusYyMWeeS8vI o6vIXwtesJ1lO6cPC/qkU8lbWCnxTN6Y+9WC8+1Vaqnw4/zD2UUdcDQ+YMx+H4DQ9Hiy WlOBc/HMjDr3Day72Mce0aN/MLBjWWqhr+5hb3BTvE2QqVLusIGTO2CFaR+0YxKVqfo3 ZKFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=BN7T9T5p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l10si42367589pgm.20.2019.04.14.08.29.28; Sun, 14 Apr 2019 08:29:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=BN7T9T5p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbfDNPZk (ORCPT + 99 others); Sun, 14 Apr 2019 11:25:40 -0400 Received: from mout.web.de ([212.227.17.12]:38477 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfDNPZj (ORCPT ); Sun, 14 Apr 2019 11:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1555255528; bh=R0n+sa6vrwQ6Mdaud1vHIJvajYtrYRU/YPB+qiZ0Cng=; h=X-UI-Sender-Class:To:Cc:References:Subject:From:Date:In-Reply-To; b=BN7T9T5pBMBF9i+dIcqqND+Z8Z1qKi5v0ASaUIv32TnkFppjU2/fsH62OpxIV3ss7 FP9ykNy0wjmMZuUn/L5IkUw79WVU6xYPq/jupzXxJ64GDaDEp1G9OXf7fYo1c+GQUz l3IlMzBxBZYBa2Hu/Dvflw4NtHDJybkulo+6YXG8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.133.103.133]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MPYJJ-1hB0BK3CSn-004iQu; Sun, 14 Apr 2019 17:25:27 +0200 To: Julia Lawall , Mukesh Ojha , Scott Wood , linuxppc-dev@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , Kumar Gala , Michael Ellerman , Paul Mackerras References: <1550928043-14889-4-git-send-email-Julia.Lawall@lip6.fr> Subject: Re: [PATCH 03/12] PowerPC-83xx: add missing of_node_put after of_device_is_available From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <7643aab3-e16c-20ba-6949-f2dea2dfa2f0@web.de> Date: Sun, 14 Apr 2019 17:25:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1550928043-14889-4-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:F3nivttGQIx5zRj8yt7d/CJ3HKnshtnmr2qS0hhgLJlvlShhzzd 6nB8cdMbivgFMYid7Grm/CetNCmPpAEMQsED9AjmIbti5E85hUw5vQOD6zCuzaUEBs2S2h5 9iYK8X+e36O22DpYvdNBYruG288xz4zZ1ziy99l+ptnGeaTkoMz1M5PjgvpOEN1xhiVaeHQ r40cZcWPbRHYb2Usfckog== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ajbRKW15zXM=:FrPpQEWymiA6SumYNt+hjB qpLVnuFciuxXioQKaqaPgkR1ie728mgxjCwFy8ckJ7O8hepgtZ+kCxz6de5btV1xiiiu7Gjp3 BqKgOzPRwT7ZG4woqHkKvaq+6ej9PTowWBdNgtc/oj3kTw3QlVmRBTpXQzNhEc/r6Gn06QPqR HV2q7zxtdP10da+5xOGPbYrkMiR9xigZxGIW55qWLPWQRpbys+NPVhph5w+x6AksqC6OvYcGr 7z+T3Og/p8TYQw6aY3kewO2OxtstaVdNGAu07z/P4pt4U4Is5HbWEK2tx83RwcJVbSE+1woES sPqfadyWI2CmYxcHGVBoi+ha8tnQD+AdjcZnAkM9ajPU1spA717c6uL4pmbIWuyVuBeb2zsPM PmNHzy/8AsUtLBexpwtix4lGB6aV1Otc0Tr9rEDXQetqux0oD0T+i1guK1fYqV35Z4olzB5G5 uK5gySOO9CptnPt+U+mRY2JJI2MI8N3WTuZy8k1p6GLppGKcQyZKx4H7EZVPdBgL9zGB+IHqq Dj1hX8cDxb7tglYBrB4edNMUra8GwDxl+B3gDFIC+E/tkoZ70YGiEeNBGlk008IbAS20APJEu K/4gYFoAE6UsFeLR83ko+JmorKM4V9eHcdaoy9dVjQRBBPiYezNi7lmGy8oDJNw1adObrBmv0 D6RIh/u6Bvbv2PHu65BivEl5QuPp2JHkOkmIHMAea3uKUlzjC1A6TM9M00piid0x8Ynul/2Y3 58I4PzACHelaHswEOqQcApURIYbrS55fXLm+w3UkcNFH8E41VBH6e6dRnvMYo0CiyhS+Q8TyE N/61AudoFjs5FOSI7N60rcIIHopsrD/xKXd4FpXuS37xLndEBnIpnb1XqR9xfDN4/mriAZrxT /vqzFPoIQtzMQRDXFiBSOOtc2Jr31I2RQ2BG3cO91rg3Uy7oEQMs4RLIQjt93NzU9JuK6Xz42 ejEDZ8SOs5g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -221,8 +221,10 @@ int mpc837x_usb_cfg(void) > int ret =3D 0; > > np =3D of_find_compatible_node(NULL, NULL, "fsl-usb2-dr"); > - if (!np || !of_device_is_available(np)) > + if (!np || !of_device_is_available(np)) { > + of_node_put(np); > return -ENODEV; > + } > prop =3D of_get_property(np, "phy_type", NULL); > > if (!prop || (strcmp(prop, "ulpi") && strcmp(prop, "serial"))) { How do you think about to adjust the exception handling in this function implementation a bit more according to the Linux coding style? Regards, Markus