Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Jens Axboe <axboe@kernel.dk>,
        "open list:BLOCK LAYER" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 2/3] blk-mq.c: Rework documention of blk_mq_init_sq_queue
 function
Thread-Topic: [PATCH 2/3] blk-mq.c: Rework documention of blk_mq_init_sq_queue
 function
Thread-Index: AQHU8m/QnMu0zSMJMUiIqzfjhj8aFA==
Date:   Sun, 14 Apr 2019 21:02:13 +0000
Message-ID: <SN6PR04MB4527248A7EC22784AE6C0836862A0@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <20190414031055.26350-1-marcos.souza.org@gmail.com>
 <20190414031055.26350-2-marcos.souza.org@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e701d00-e94a-47c0-57ed-08d6c11c77d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2019 21:02:13.2185
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4639
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/13/19 8:11 PM, Marcos Paulo de Souza wrote:=0A=
> Describing better what the function does, and what the arguments are=0A=
> meant for.=0A=
> =0A=
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>=0A=
> ---=0A=
>   block/blk-mq.c | 17 ++++++++++++++---=0A=
>   1 file changed, 14 insertions(+), 3 deletions(-)=0A=
> =0A=
> diff --git a/block/blk-mq.c b/block/blk-mq.c=0A=
> index 4a8277a54c03..fd0bf89b8a73 100644=0A=
> --- a/block/blk-mq.c=0A=
> +++ b/block/blk-mq.c=0A=
> @@ -2675,9 +2675,20 @@ struct request_queue *blk_mq_init_queue(struct blk=
_mq_tag_set *set)=0A=
>   }=0A=
>   EXPORT_SYMBOL(blk_mq_init_queue);=0A=
>   =0A=
> -/*=0A=
> - * Helper for setting up a queue with mq ops, given queue depth, and=0A=
> - * the passed in mq ops flags.=0A=
> +/**=0A=
Is following line beyond 80 columns ?=0A=
> + * blk_mq_init_sq_queue - Create a new request queue with a SQ queue and=
 tag set=0A=
It will be great if we describe what SQ in the above line, otherwise we =0A=
stating just obvious here.=0A=
> + * @set: tag set to be associated by the newly created request queue=0A=
> + * @ops: operations to be associated with @set=0A=
> + * @queue_depth: number of tags of @set=0A=
> + * @set_flags: flags of @set=0A=
> + *=0A=
> + * Description:=0A=
> + * @set is initialized using @ops, @queue_depth, @set_flags, and using o=
nly one=0A=
> + * hw_queue (SQ). Later on blk_mq_alloc_tag_set() is called to validate =
and/or=0A=
> + * adjust values of the tag set. blk_mq_init_queue() is called passing @=
set as=0A=
> + * argument, returning a new request queue with @set associated.=0A=
> + *=0A=
> + * Returns the newly created request queue on success, or ERR_PTR() on f=
ailure.=0A=
>    */=0A=
>   struct request_queue *blk_mq_init_sq_queue(struct blk_mq_tag_set *set,=
=0A=
>   					   const struct blk_mq_ops *ops,=0A=
> =0A=
=0A=