Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261931AbUDBKzq (ORCPT ); Fri, 2 Apr 2004 05:55:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262497AbUDBKzq (ORCPT ); Fri, 2 Apr 2004 05:55:46 -0500 Received: from bay-bridge.veritas.com ([143.127.3.10]:56246 "EHLO MTVMIME02.enterprise.veritas.com") by vger.kernel.org with ESMTP id S261931AbUDBKzp (ORCPT ); Fri, 2 Apr 2004 05:55:45 -0500 Date: Fri, 2 Apr 2004 11:55:44 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@localhost.localdomain To: Marc-Christian Petersen cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Andrea Arcangeli , Andrew Morton , , Subject: Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix In-Reply-To: <200404021221.15197@WOLK> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 19 On Fri, 2 Apr 2004, Marc-Christian Petersen wrote: > > dunno if the below is causing your trouble, but is that intentional that > page_cache_release(page) is called twice? It's not pretty, but it is intentional and correct: the first to balance the page_cache_get higher up (well commented), the second because add_to_page_cache does a page_cache_get but remove_from_page_cache does not do the corresponding page_cache_release. Christoph's problems will be somewhere in Andrea's compound page changes. Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/