Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1847715yba; Sun, 14 Apr 2019 22:44:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzj53K1fke1yYBfqdTdt7SQ8AeVM51xrnR6K3dmMjSuN2Bv0BpRP+b++7G6xos+PyinDaBj X-Received: by 2002:a63:8e:: with SMTP id 136mr63553824pga.367.1555307092167; Sun, 14 Apr 2019 22:44:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555307092; cv=none; d=google.com; s=arc-20160816; b=dmuCifz3ubJGb0hxFscnseB+byde8pxBa4avt6enX7USTU0P07QCUSUztQq723/wd1 QeJSarBP1ICMwYqAEBz6w3pA7YcCrmMDbk44dk/+n7AlCgF51HqzlwI9IBh+0veCvE0v C9ke5kaOPsWhdGVO2w8luPCbTAhHFmyFHrlnglPCByfXyIZ/LQmK7IPbbJk0bRawsOrF ClfsmTx559sAOeMAxG2D6qQM/0hs+3un4EcV1PpAVJc0sFWzA1/kYy+XOjmUJLae5seK Baqz+5ZXlgYzCW8uu5TqKNOZIrn67X8gMDApqfnL84rH3NKDElbkcfMp4ASFRRZhPXqE HH0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=/c+Hw5+k/azU8PvnxKFqYmJEScc8yTKsIrOq90KcNSI=; b=0CUudgeTFlqQ5MUTCIHWFd25zj7ToIlphqo1fogl+Uv/PNDBNxgIaK6Hvxg7BBMh0l X++tM+bHgN8X141McyfzzH7fiEDVnHLweKG+I4bCLYO2OM7XwrJ8IYHrP2GPcbcAQkYc cs92WrROWm+pSv7hz9p94KwWYOrSPircAnazHRSgTLXl2pfrBdsjI1c6AsQ8cojIlXr5 plUpR+dHnUgLUAJq+zuAKVCU7Z7HEMz6PvTZVVH1OnuLK0n10AivDz+CrcLgnfw6iqyv Xeikjs4YvCKYLgae73COadHkY5xUzkbr6yDjLBjz023LTMd3ZT8ybowrOMo9PebefuZl R9rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ioIki42a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si44542887pfa.63.2019.04.14.22.44.35; Sun, 14 Apr 2019 22:44:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ioIki42a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbfDOFoA (ORCPT + 99 others); Mon, 15 Apr 2019 01:44:00 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40982 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbfDOFn7 (ORCPT ); Mon, 15 Apr 2019 01:43:59 -0400 Received: by mail-lf1-f66.google.com with SMTP id t30so12027006lfd.8; Sun, 14 Apr 2019 22:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/c+Hw5+k/azU8PvnxKFqYmJEScc8yTKsIrOq90KcNSI=; b=ioIki42aQJHfE8Z4YokPbljBrYNgoYz9Nf0Cc206GZusD6gjAIzI28wJbEZBUIKR0x PsSFzKpzb9INhNuwNO+nBgVpGJ1uqna8NrizyAbxNfGbUI2LkkhlraXK3tnM/qpaKrzD bGe8jQ9oRCQB5i+kZ/dwlOP62bXCQBJrNA021hAJJe78QJ/fwHvH9yf7NyGI5fPxBOty oBdQz0JqexEk5ZAzaCVCmujySd0vzIT3mi6HCeFfv9ZFsJVqV/vs7BPjstAmOy5wMd59 wbKXEEvKPJ273T+F4phTZUAiqeRrVLAAICwnq8VmmoGODBWLXdq1ITD/CZVR5fjUsKkt A+oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/c+Hw5+k/azU8PvnxKFqYmJEScc8yTKsIrOq90KcNSI=; b=Poo36XdHiCWAT7JTmJv3cjGNctUbI3jh36ge3JMGLn2qftBtXf+ZcVAyxUV0xkEDqf oP6SfYfZ7gZoSUY90HL2GSc2JXVgUQk7K3FC1WA1jkogEYXYJF+l8FHoujDSuadF3/0S u7l+KgtFxtYCS5SB2VxUs3W7sh4A4booXaZSXwlBwcfCqrB0+46YweFzPUZ4RJdIL8oh 1qN/TjQkZcvX3Vl+ERkubdMYZHB9Cv9mDGGErLb8vhQwhMpkcRH77hBOjKhQXNcBMFdE 37y3TbW6qbJRfU9DdVXB0TRpDa3RzpCsbepN4nwUEqWeNXaLUhe/M7Cl5XQuPeWuNZIa pgMw== X-Gm-Message-State: APjAAAWCggU093PIkzt617iL1vYvDIK216eOV3bQ+yMVwfJ0hcq+tEd5 4NHXP1EQf9JtawUTx1z4NG0FXgm9bnRMrNhPRRM= X-Received: by 2002:ac2:59db:: with SMTP id x27mr32758509lfn.108.1555307036239; Sun, 14 Apr 2019 22:43:56 -0700 (PDT) MIME-Version: 1.0 References: <20190414091452.22275-1-shyam.saini@amarulasolutions.com> In-Reply-To: <20190414091452.22275-1-shyam.saini@amarulasolutions.com> From: Alexei Starovoitov Date: Sun, 14 Apr 2019 22:43:44 -0700 Message-ID: Subject: Re: [PATCH 1/2] include: linux: Regularise the use of FIELD_SIZEOF macro To: Shyam Saini Cc: Kernel Hardening , LKML , Andrew Morton , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Network Development , linux-ext4@vger.kernel.org, devel@lists.orangefs.org, linux-mm , linux-sctp@vger.kernel.org, bpf , kvm@vger.kernel.org, mayhs11saini@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 14, 2019 at 2:15 AM Shyam Saini wrote: > > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets use > FIELD_SIZEOF and replace all occurrences of other two macros with this. > > For this purpose, redefine FIELD_SIZEOF in include/linux/stddef.h and > tools/testing/selftests/bpf/bpf_util.h and remove its defination from > include/linux/kernel.h > > Signed-off-by: Shyam Saini > --- > arch/arm64/include/asm/processor.h | 10 +++++----- > arch/mips/cavium-octeon/executive/cvmx-bootmem.c | 2 +- > drivers/gpu/drm/i915/gvt/scheduler.c | 2 +- > drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c | 4 ++-- > fs/befs/linuxvfs.c | 2 +- > fs/ext2/super.c | 2 +- > fs/ext4/super.c | 2 +- > fs/freevxfs/vxfs_super.c | 2 +- > fs/orangefs/super.c | 2 +- > fs/ufs/super.c | 2 +- > include/linux/kernel.h | 9 --------- > include/linux/slab.h | 2 +- > include/linux/stddef.h | 11 ++++++++++- > kernel/fork.c | 2 +- > kernel/utsname.c | 2 +- > net/caif/caif_socket.c | 2 +- > net/core/skbuff.c | 2 +- > net/ipv4/raw.c | 2 +- > net/ipv6/raw.c | 2 +- > net/sctp/socket.c | 4 ++-- > tools/testing/selftests/bpf/bpf_util.h | 11 ++++++++++- tools/ directory is for user space pieces that don't include kernel's include. I bet your pathes break the user space builds.