Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1870609yba; Sun, 14 Apr 2019 23:24:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyXILxp5w6xKmuUtDTbA5cdCuXEAfQ2qjLVEJDRNq2KQYpu8tiXQ9IDjk0CUlumftWjULMF X-Received: by 2002:a17:902:ec0c:: with SMTP id cy12mr51546726plb.291.1555309474453; Sun, 14 Apr 2019 23:24:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555309474; cv=none; d=google.com; s=arc-20160816; b=dNfCuhUuqO5MHOQPxv1Al9ofeZ9ugMFqrqCJ828+ahuTrG+bdP/36ml75Kqs3a1s+U T4RVAUH8+m6rLHZ0zfsjcjRppBIa863EKkV5vO5nd5VXVo+HQsvgDntMmf8uLVYkT6nk Uq89mt9oc8E/4awgoEyJCLPrJaXdmymiaVy7H1Ux4f8Z03M2lzF9Ow1AOogopIIlBX12 v6osRWEViTvAzX7YEPst1b67rMZeDI/hIA39f0dHgEqtF/m5XOI5CCbVMimC3un0Fj5R ZpBpG/5MlTpRS1bsqYw6DRgGoWgaswYC9kH1bTZpYZ5rJCMI+eV8btj40Qe1Tsdi49HH eubQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=iMYvlJpOrmIaz66/RQF0yiu3LcjskOwFEGg5wuRgYJc=; b=zqHOw4zSRcXQhxES4oldWMEIJKcZ/OGn6+LivOWg3Lqrj+LxbSoKA6kysNdylBofqB GgqiEhFqzG3UWSP52tyEuMdSuvQiSZQqbQ+JZ9IAbuR1siDWqF8inz5IR+Hae7v0Q4mW N3XGwLnvJF0tZq70iLlkTOwyyLTKlsaSLtHwdr/di7EpM9Sggg1klkLz7msXISH9YOtD tV+iiDSjWIvRDv23U+LJxWbkonAZzxsJ1gKrYyGoQ2i0/Fmeci6XECKu52gQk6IvBkVW RBx8cDMFQ+Vx+l9WCQa4PiXEuJPVYQAwRNNwtKTWynuamcYkS3yFfIQM/5NoxSYrDocn K1cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UmlWx3EC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f13si44662912pfh.37.2019.04.14.23.24.18; Sun, 14 Apr 2019 23:24:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UmlWx3EC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbfDOGXV (ORCPT + 99 others); Mon, 15 Apr 2019 02:23:21 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33522 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbfDOGXU (ORCPT ); Mon, 15 Apr 2019 02:23:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iMYvlJpOrmIaz66/RQF0yiu3LcjskOwFEGg5wuRgYJc=; b=UmlWx3ECj6cKii7VP6bnwCOzR j83NHFXEHCFg6N2pyMLk4bokn0Go/t76c6Wh7ez3g6xwmMrXddZNEOzpBhyL1/86AMTcR2uQKvcRk kapWU2N1ipqvngznoNLR6shJ9N1QDSayD4GwEKPFp1eJh7T6xeFh/DlJOc20L7o/ESHbyxsYB/hGb Y3v4y9DsR2b/U2+6NdCqaC68KL0e2bG255kD09E4jBqUbh7BAko2uKlkSxLMztvT/RbQohYM7qUhy fyRDbDITT6rzDrD5JbVLoJzuwaQdL1nRPO70a/8g+3eyJIupU5hwBD3wDo4KRXcDrzuxkh8uFDDY7 a9jyIkhnw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFv1Q-00077e-Qo; Mon, 15 Apr 2019 06:23:16 +0000 Date: Sun, 14 Apr 2019 23:23:16 -0700 From: Christoph Hellwig To: Tom Murphy Cc: iommu@lists.linux-foundation.org, Heiko Stuebner , Will Deacon , David Brown , linux-samsung-soc@vger.kernel.org, dima@arista.com, Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Andy Gross , Marc Zyngier , linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, murphyt7@tcd.ie, Robin Murphy Subject: Re: [PATCH 9/9] iommu/amd: Add allocated domain to global list earlier Message-ID: <20190415062316.GC18154@infradead.org> References: <20190411184741.27540-1-tmurphy@arista.com> <20190411184741.27540-10-tmurphy@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190411184741.27540-10-tmurphy@arista.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 11, 2019 at 07:47:38PM +0100, Tom Murphy via iommu wrote: > dma_ops_domain_free() expects domain to be in a global list. > Arguably, could be called before protection_domain_init(). > > Signed-off-by: Dmitry Safonov > Signed-off-by: Tom Murphy This seems like a fix to the existing code and should probably go out first.