Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2003328yba; Mon, 15 Apr 2019 02:58:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFiZ1oWywqxfcBXTfdCDxppEpdsBNisbC0Y17NCFWdh2K1B/YZied55w42RZjNUYwL7pDB X-Received: by 2002:a17:902:bc48:: with SMTP id t8mr12882389plz.65.1555322298131; Mon, 15 Apr 2019 02:58:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555322298; cv=none; d=google.com; s=arc-20160816; b=sxJzZNr3+0nQWMFaNMs5Fg18MYYfQTVOLTO5RAY4qFjQQ1eAe/xDbgV1d8T687ufdC WwCj0jAmHFlm3pTxYXDnN7kITAU7VSI0duGhGlOzu0EAXkA32a3C5RQix1oHtzblq135 T4S/No+RA1hYsCBcVCfWoZNslKFur8CmgTxBa7MncDmg8sIhR9qccyYO2rZJHcEAkFbD +WUVuJCQiKR+m3/ZEDpnMrtFUH2HjOM40wj9fuw+Fb0KPIYfrp01akg7gmr/GcKdiq9V qnQE2LqEc0HKe5HFQYOHneC1mMPZeRhYWOFjigTJw/HPZgIWdQMOGcMUTleLXPPIUdwy ux2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4dZvQl7YlF1yV7q9JfMz8fqbxH6iZxjZSrNpsjltjOU=; b=1ALtALe5C6Ezju8nz7LC39UtmjTXnPRny8xdwuofXVKUM+dwLznJ+FRalsOJOxAE0f VjMNX0aZKWjgsb4CiwDwn0iKlsB077bfswbp+HEzKTixg5CdDAW6BZ6hMwZq8VpPqjoC Zi0elMbDwwJ3AfJcCSSNi6QWPMe1icN9MWW4wwja4QqXI8r4pP0D9XibiR6950IyXcmY fx3Dk9lkLIyEt2wHbvrgT6RKTlR7bxdVYgNx+Eh47p6+jACrKlMXJMaJVnCssuKE3Da3 Dl+sKtf2M+yuvmaOxAvI/XFL/nafmtXESbNh/Jb8W16wU9qgUn/XE4AWhQQTvi3toREi hbMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=bOrVI8L6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 21si27374252pgl.340.2019.04.15.02.58.02; Mon, 15 Apr 2019 02:58:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=bOrVI8L6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbfDOJ52 (ORCPT + 99 others); Mon, 15 Apr 2019 05:57:28 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:58224 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbfDOJ52 (ORCPT ); Mon, 15 Apr 2019 05:57:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4dZvQl7YlF1yV7q9JfMz8fqbxH6iZxjZSrNpsjltjOU=; b=bOrVI8L6VnBjzWrXIpJvJBcWf y5d6so1DAotWuNuaeRYDQEn5nB/F6W3y7511gjtwGCMXnloFBK9NpxuceRTuxJrbNxbmxRt0iOGqb B1pshqDMVUiKnTmw5483fg8V78FTBXqsD916u6fStl36WvANBnU0su0Zu21cDvNrUCPzw=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hFyMY-000083-IJ; Mon, 15 Apr 2019 09:57:18 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id D0C4B11279E1; Mon, 15 Apr 2019 10:57:17 +0100 (BST) Date: Mon, 15 Apr 2019 10:57:17 +0100 From: Mark Brown To: Pascal PAILLET-LME Cc: "lgirdwood@gmail.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/2] regulator: Add support for stm32 power regulators Message-ID: <20190415095717.GA6880@sirena.org.uk> References: <1555319855-2982-1-git-send-email-p.paillet@st.com> <1555319855-2982-3-git-send-email-p.paillet@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <1555319855-2982-3-git-send-email-p.paillet@st.com> X-Cookie: There's no time like the pleasant. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 15, 2019 at 09:17:38AM +0000, Pascal PAILLET-LME wrote: > +int stm32_pwr_reg_is_ready(struct regulator_dev *rdev) > +{ > + struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev); > + u32 val; > + > + val = readl_relaxed(priv->base + REG_PWR_CR3); > + > + return (val & priv->ready_mask); > +} You should probably add a get_status() callback using this. --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAly0VX0ACgkQJNaLcl1U h9AwaAf/aToCo2Lpwde4IyVS0Xah6RImQN5eFMHjqU/CAVzhfuHyxA3nncqEftbR Ekr+CFAMrmjVYKnK4Qor47WwRDcGVkHgnlT3RqIMg7DlEUEdtgJm0ODNYQ53arhU IaBwLKcv0/swlrt7tv0Bx2nB2BjTTE1DorL6DYw2fxhJ8o28FWgL4y+J/ZD6NUQB KoiAe6vs/G1Wiyj3HRv+wd8nppNLHw6WCYdKUUOT6ApeTBfTmpMvuxGz2XLKrL3Q /Aj8MN6dy6hLwwDZWtSV7UgcFkx/GpoMDORtFadEX9lyO0KcThiXKHh24D5MVFkd mwSQr2AdZEEN8mMT8ZU8+gjOa3gVOg== =JHeU -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--