Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2019599yba; Mon, 15 Apr 2019 03:18:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyeYxUPdYEtmwowVm9PWRg+d4YmiEQJsA5SIIScSKHF3YOQbBcCBGtt6ocudLSPaR9EvUqd X-Received: by 2002:a62:2587:: with SMTP id l129mr74844200pfl.151.1555323514347; Mon, 15 Apr 2019 03:18:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555323514; cv=none; d=google.com; s=arc-20160816; b=eh4mvyo+MiihHLRVwgK7U9+R4aN5Z3rRh/qIDqr1HCBFoLeQT00tRvWDigtfxfhjRK QoCRZ8zzSb/Yo23+EEmZiHz+sL7SVs1fhus4zkVlY6NeXmySAwo8y7M/NNKdznDEag84 2Tad7QI53sXOQUMNQ+Wk/s/UJn15K7HPXnbaKhW379rzY1IxdbjQ/0m7wkQTuyewmcNo vhKMYn18VNB2g5tLclJU9IHD7aRaIyHLuuswnN0j1UIJgWYPlE7J0/h4qQhzK5kfAZDd ZnOIPqH5k43RS2wAjlj0ya4GM4zBzUDX3ZsrDUray0x2JNLVx5AahvcqOCEjMhwfOCD9 vX8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date; bh=dSxvLGpKfAHUP8g93Ui/hUUkl0TWr4wWpKVevW77r0Y=; b=vixTlw9rZla+l7vJ0mNGPZUK7tVeJ3igzaz5ukahsPPLsxF0aP7KALKVGBM+67qAyN 0FuxgioqE5XpPCi74vmH+eZr75t+JWo9QpMIPlfy/cb7WEDMKhxOZQPdXLa/FphpgUwg 08IE+4khYWlfsAk3AteZrhQm1hfMCQENXEiCxtn4l686kMdg3z1Ea+xyB3yLxqZ14/Ah US91Dc0oXBnZLt9qzfcj8y20Y3MsT2dPmZYwhsJ/MBD79M8XK9/ttQjBVzH+B91VqhOd xQ1ezQ0QQ3ooWdcB9vF0xYt9xIKdj/8gWJeAqhAUNPNn1MHwbKOn0ran3mRAc/5e+1B1 6zXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si44214027pgh.139.2019.04.15.03.18.18; Mon, 15 Apr 2019 03:18:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbfDOKRh (ORCPT + 99 others); Mon, 15 Apr 2019 06:17:37 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54192 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbfDOKRh (ORCPT ); Mon, 15 Apr 2019 06:17:37 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3FADucl077115 for ; Mon, 15 Apr 2019 06:17:36 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rvqm89h7t-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 15 Apr 2019 06:17:35 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Apr 2019 11:17:33 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 15 Apr 2019 11:17:30 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3FAHTL055181500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Apr 2019 10:17:29 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4932FAE055; Mon, 15 Apr 2019 10:17:29 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3C77BAE04D; Mon, 15 Apr 2019 10:17:29 +0000 (GMT) Received: from lynx.boeblingen.de.ibm.com (unknown [9.152.224.20]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 15 Apr 2019 10:17:29 +0000 (GMT) Received: from brueckh by lynx.boeblingen.de.ibm.com with local (Exim 4.90_1) (envelope-from ) id 1hFyg4-0001Oz-R9; Mon, 15 Apr 2019 12:17:28 +0200 Date: Mon, 15 Apr 2019 12:17:28 +0200 From: Hendrik Brueckner To: Thomas Richter Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Subject: Re: [PATCH] perf/report: Report OOM in perf report status line References: <20190415094617.30150-1-tmricht@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190415094617.30150-1-tmricht@linux.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 19041510-0020-0000-0000-0000032FEBFC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19041510-0021-0000-0000-000021822A6D Message-Id: <20190415101728.GA6966@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-15_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904150073 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas, On Mon, Apr 15, 2019 at 11:46:17AM +0200, Thomas Richter wrote: [...] > Signed-off-by: Thomas Richter > Reviewed-by: Jiri Olsa > --- > tools/perf/util/session.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index b17f1c9bc965..e89716175588 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -1930,10 +1930,10 @@ reader__process_events(struct reader *rd, struct perf_session *session, > > if (size < sizeof(struct perf_event_header) || > (skip = rd->process(session, event, file_pos)) < 0) { > - pr_err("%#" PRIx64 " [%#x]: failed to process type: %d\n", > + pr_err("%#" PRIx64 " [%#x]: failed to process type: %d [%s]\n", > file_offset + head, event->header.size, > - event->header.type); > - err = -EINVAL; > + event->header.type, strerror(-skip)); > + err = skip; > goto out; > } > Thanks for solving this issue. Reviewed-by: Hendrik Brueckner