Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2110698yba; Mon, 15 Apr 2019 05:16:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0dXuBemV+yR578ASazJIVxYY7sMBcsFt+5eUKI17UWvKdvQtuPjIkLKfh/Po/O6LZAVzf X-Received: by 2002:a17:902:2907:: with SMTP id g7mr39213105plb.238.1555330594144; Mon, 15 Apr 2019 05:16:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555330594; cv=none; d=google.com; s=arc-20160816; b=v9JlyA4RVKtwu/DvqXoZoWszRq0QQHGr6mWLOhFPx/1l+dOrJCl7vNb9oT8UxT1Anl vBEqR6KVw9MWaBQUKUdKEabjHb3QXMU/vZAaPRGa2LJvkfFIxtxVkYlK1oEReqfZLAQJ wbEH645ZcAnje2JfqUH4K3+gAbA+t9w3edSssiMNjT7k/RMCdJ/WqKjkxmQX4v3dZ8sm ykTWqO+/373czd09VZULG7UHZs2rBR7LXbk4r+Zn7us7U0Bi3YH3kxHuhW72zg+YAjA+ nMocN60IBilBUxXYwcwdGMaqZatIAIYwiNSxu77sFc54sRD/dg78+3fEcBx1AMDD5Psp GlZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=l9ir60nNJwBbII3Z7YfygeQjey9MNonvD8+mCs5l+c4=; b=cR5z/BKwwJfs++qH4sGyecR7D7EnqgsRm1QfhnXfvs7NW65m/Y8NNyY0100NlkDhjw lE8IKRLCDQY6SlZWnZk+OtsS4s6j0D0peAuGdsOm5g6+W+YNpFSlfYHDLzHCuy5tuZ9m tXtOHxvcWNOSFAJB02ZTIIfW1i8w1bKAQ+0o0MEKtYvlWZcx3o7UTi++wmM12hgx9A9u jVicSFm1Minx2Z+vWTB1Buv95Q8gjtaQ6MG5z7ypaSL5BZ6sLexzaPINX4e7RDOLjeW8 o7F1tgCug3rvQpYXU72gr4xWcmBKpII7QzECypPCRRpMdN6O8hUUfZerggzgfmZ9+Fov +bfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XZ3GWmt1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y14si42273829pll.379.2019.04.15.05.16.18; Mon, 15 Apr 2019 05:16:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XZ3GWmt1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727491AbfDOMP3 (ORCPT + 99 others); Mon, 15 Apr 2019 08:15:29 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:38375 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727483AbfDOMP0 (ORCPT ); Mon, 15 Apr 2019 08:15:26 -0400 Received: by mail-pf1-f196.google.com with SMTP id 10so8509226pfo.5 for ; Mon, 15 Apr 2019 05:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=l9ir60nNJwBbII3Z7YfygeQjey9MNonvD8+mCs5l+c4=; b=XZ3GWmt1mWC7qqDk0CPUMjbeP75BO7JsbiGnDALS1fBKvH9BaB8hWahTFAEy+c4eNd bwLKGTd3LrMkmeBsQ4r81KbvlCg4JPSsx3nPRGh29o4erxiT+uTL4DJ0Yl+J1JG0pmWV UROk08EZ3klQ2fO6BBKeLCN+dladovWVISj58XT/H0kjpcXZPMJZ0Nv/4DEpUU5b6jd4 ACocZm20dVGjbONsv8C7eLZZve99otr8o6wQDye6PjU8/eucZhH/oNQqVmCkr0Fc9YWA +mMpDMi4f6QzajlBm23N/sz1qZ39Lf2doqpQN5upgUdgSWlrEvbjM2VDL2I8dNC0aEd9 QuPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=l9ir60nNJwBbII3Z7YfygeQjey9MNonvD8+mCs5l+c4=; b=NJpuDVkAnVh7ar9/7DJbtT7YELv+B4Ifv9Iu4LHpVv+cEHfLIfOR5w7B+j3UzuSJ49 4t0w+3HyvUdeUynbbjjQgxM58mD64MS5J5tVTZzYhanw73oNp9xXk0Kje3IcOnMkMeQl 0FMCpOH0/WNmYqydbtrdCX2NFTbhnCwC5eVlnDjrV+kCe4i2mwm1gJyz/rWIUoaOpCUL TxsoM35j/qj9FP3/tubV7eTp/aSkOskZNyCpY1OT2HzSkYF5OJ7NpCCe65g0v2dZTk0+ PEqsZ/StH587BiqUISm+6w4j/1mPyl8XG+x4HrdT5b5v9l8LaMiAqGhjmLgjyza1RTGI wX2w== X-Gm-Message-State: APjAAAVcz4isiEi9Z1gbgW1jDEkfSRZe1c1LG/VqWXNFvj6ftX2OdMZv okZdjRE3J5nEs+jXiVg8Hhwbyw== X-Received: by 2002:a62:62c3:: with SMTP id w186mr42971295pfb.73.1555330525672; Mon, 15 Apr 2019 05:15:25 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id 6sm64157155pfj.95.2019.04.15.05.15.22 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 15 Apr 2019 05:15:24 -0700 (PDT) From: Baolin Wang To: dan.j.williams@intel.com, vkoul@kernel.org Cc: eric.long@unisoc.com, orsonzhai@gmail.com, zhang.lyra@gmail.com, broonie@kernel.org, baolin.wang@linaro.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] dmaengine: sprd: Fix the incorrect start for 2-stage destination channels Date: Mon, 15 Apr 2019 20:14:57 +0800 Message-Id: <035654558b82bc26ee78a815cc9287e478baac92.1555330115.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Long The 2-stage destination channel will be triggered by source channel automatically, which means we should not trigger it by software request. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- drivers/dma/sprd-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 431e289..0f92e60 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -510,7 +510,9 @@ static void sprd_dma_start(struct sprd_dma_chn *schan) sprd_dma_set_uid(schan); sprd_dma_enable_chn(schan); - if (schan->dev_id == SPRD_DMA_SOFTWARE_UID) + if (schan->dev_id == SPRD_DMA_SOFTWARE_UID && + schan->chn_mode != SPRD_DMA_DST_CHN0 && + schan->chn_mode != SPRD_DMA_DST_CHN1) sprd_dma_soft_request(schan); } -- 1.7.9.5