Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
References: <20190410140949.26716-1-yuehaibing@huawei.com>
 <20190415130009.GA12388@red-moon>
CC:     <thomas.petazzoni@bootlin.com>, <jason@lakedaemon.net>,
        <bhelgaas@google.com>, <gustavo.pimentel@synopsys.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-pci@vger.kernel.org>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <6852d7a5-3f0f-ee82-89ef-f3d5caf7bd83@huawei.com>
Date:   Mon, 15 Apr 2019 22:06:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20190415130009.GA12388@red-moon>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/4/15 21:00, Lorenzo Pieralisi wrote:
> On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> Fix sparse warning:
>>
>> drivers/pci/controller/pci-mvebu.c:557:28: warning:
>>  symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
> 
> Is Mr.Robot reachable by email ?
> 
> If it is a CI bot I doubt it is useful to leave this tag there unless
> you want it for accounting purposes, just let me know.

Yes, it is our CI bot.

> 
> Thanks,
> Lorenzo
> 
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/pci/controller/pci-mvebu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
>> index d3a0419..ed032e9 100644
>> --- a/drivers/pci/controller/pci-mvebu.c
>> +++ b/drivers/pci/controller/pci-mvebu.c
>> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
>>  	}
>>  }
>>  
>> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>>  	.write_base = mvebu_pci_bridge_emul_base_conf_write,
>>  	.read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
>>  	.write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
>> -- 
>> 2.7.4
>>
>>
> 
> .
>