Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] sched/fair: Use 'unsigned long' for
 group_shares,group_runnable
To:     Peter Zijlstra <peterz@infradead.org>
CC:     <huawei.libin@huawei.com>, <xiexiuqi@huawei.com>,
        <yangyingliang@huawei.com>, <mingo@redhat.com>,
        <linux-kernel@vger.kernel.org>,
        "chengjian (D)" <cj.chengjian@huawei.com>
References: <20190413033234.30002-1-cj.chengjian@huawei.com>
 <20190415124617.GP11158@hirez.programming.kicks-ass.net>
 <eb7dede4-9668-9252-b95a-e20e313c5890@huawei.com>
 <20190415152549.GQ11158@hirez.programming.kicks-ass.net>
From:   "chengjian (D)" <cj.chengjian@huawei.com>
Message-ID: <8c8e96d0-226b-de46-d498-0d8a6947b4c9@huawei.com>
Date:   Mon, 15 Apr 2019 23:50:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.2
MIME-Version: 1.0
In-Reply-To: <20190415152549.GQ11158@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/4/15 23:25, Peter Zijlstra wrote:
> On Mon, Apr 15, 2019 at 11:20:31PM +0800, chengjian (D) wrote:
>> Hi, Peter
>>
>>
>> On 2019/4/15 20:46, Peter Zijlstra wrote:
>>
>> I write a demo about this, which I described it as overflow.
> I'm not saying there's no overflow, I'm saying there's nothing UB about
> it.
>

Yeah. I got it.

This may not be an undefined behavior,

but rather a bug or logic error caused by overflow.


```cpp


static long calc_group_shares(struct cfs_rq *cfs_rq)
{

     // ......

     shares = (tg_shares * load);   // 1048576 * 9144968455305  = 
-8857549630719655936 (OVERFLOW)
     if (tg_weight)                         // assume tg_weight is 3
         shares /= tg_weight;         //  0xd7068dd8c2daaaab shoule be 
0x2c5be32e18300000
}

```


It will cause `se->runnable_weight` to have an incorrect value in 
reweight_entity().


Thanks.

CHENG Jian