Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190408173252.37932-1-eranian@google.com> <20190408173252.37932-3-eranian@google.com>
 <20190415155742.GI12232@hirez.programming.kicks-ass.net>
In-Reply-To: <20190415155742.GI12232@hirez.programming.kicks-ass.net>
From:   Stephane Eranian <eranian@google.com>
Date:   Mon, 15 Apr 2019 10:20:57 -0700
Message-ID: <CABPqkBQtJ81TMvjExJ3+hm1f+E1zkbTi-au-GkJRTg9ovZgEsQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] perf/x86/intel: force resched when TFA sysctl is modified
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andi Kleen <ak@linux.intel.com>,
        "Liang, Kan" <kan.liang@intel.com>, mingo@elte.hu,
        nelson.dsouza@intel.com, Jiri Olsa <jolsa@redhat.com>,
        tonyj@suse.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 15, 2019 at 8:57 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Mon, Apr 08, 2019 at 10:32:52AM -0700, Stephane Eranian wrote:
> > +static ssize_t set_sysctl_tfa(struct device *cdev,
> > +                           struct device_attribute *attr,
> > +                           const char *buf, size_t count)
> > +{
> > +     bool val;
> > +     ssize_t ret;
> > +
> > +     ret = kstrtobool(buf, &val);
> > +     if (ret)
> > +             return ret;
> > +
> > +     /* no change */
> > +     if (val == allow_tsx_force_abort)
> > +             return count;
> > +
> > +     allow_tsx_force_abort = val;
> > +
> > +     get_online_cpus();
> > +     on_each_cpu(update_tfa_sched, NULL, 1);
> > +     put_online_cpus();
> > +
> > +     return count;
> > +}
>
> So we care about concurrent writing to that file?
Not likely but we care about seeing the effects on event scheduling
before the sysctl returns.