Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2417056yba; Mon, 15 Apr 2019 11:09:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwiosyql+6TazBQf3ytWDvCxuS4C3mDAX1fgvyTK3/HYLXnS/nkjVGvB25nLsu972BiNBzm X-Received: by 2002:aa7:8818:: with SMTP id c24mr70238669pfo.129.1555351750419; Mon, 15 Apr 2019 11:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555351750; cv=none; d=google.com; s=arc-20160816; b=M8aFBNBxqIfMKfo9XgqU/kY4TirPWS/c3dSXIYuiZs4uQ0xNfXTEEnhiH4tNGuN1Fq MPs3L13NS5an8SO8n8r7Q4zfIaK10Q+w1SYdFCjtxFwx98liZT0Yqgdw9gU+Qzqn5dEx WtedyBi2zcpwUw66MNrQGmypQRuz/zErtZ2Uzvz58t2hTIFBaKDvs+7eVO/MbZJs6bUJ roE+oikRsVxu+rKrpxmdJPBxHzlTvggu8c+cjw2dTWIABNMcAJEjUlqvSZUzFVErD/LO eE2vSgvFQ5uHMAEdMjy20i0YpK9Y38OOpdBVMYbWAMsg4wmNGACjci+IWQmksrPZIj00 1gPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=EkcG1ecxbRvbtTZp8pykP1WrSpDo5FL3IoRO1jdwX4A=; b=LJgf19ltTMZo1ioJnxPNfZ0R4p5LFbtquZwBcd9ffcoM/vnQtOwfNNaONkgjYRIWJ2 PWoMRhAzKoS4WYEMoVcvMKQOgM4/bCbUfL4FEk3zfb3hp5NDBROwCgeQRJ6Nt7NPgHfW sqNjZLVS8y6NdWCVKMHLFLA4nf+ag3NP2qKHNLWMMyEX3RDEgjwQkCsV831y8brGxeEl vFz9Fbn0bp5TUytSkvJe7RRyzUFmuHlZ0JAFS4AcnzYlEAXFE0qjCpxDJF/a9nSPIhPA Jtlzs8Fkj5v1Oo98mQS1pJIv0530muydoGINn6IWeIyb8PmVhw87LRsC2Aom04aLMmNg oyoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=i3wHdbvu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si44205113pgr.253.2019.04.15.11.08.53; Mon, 15 Apr 2019 11:09:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=i3wHdbvu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbfDOSGu (ORCPT + 99 others); Mon, 15 Apr 2019 14:06:50 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39941 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727746AbfDOSGt (ORCPT ); Mon, 15 Apr 2019 14:06:49 -0400 Received: by mail-wr1-f68.google.com with SMTP id h4so23166271wre.7 for ; Mon, 15 Apr 2019 11:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EkcG1ecxbRvbtTZp8pykP1WrSpDo5FL3IoRO1jdwX4A=; b=i3wHdbvuoVxt1LC2EUpNdj3M95LS7TyzrhgbGppZWVWnHDaHBVWDrEBfZItz/IEpmj 3eCG15hLn0pJiWlrRV0+/QJzosPkdKhD8R6kRPMC3v+mXlBk/eWJiZbDkXeYXRyJgvnA kFO3X/OQADph8cOzNyl8ghHq8eNls4gmuYn3zD2caH4i6SyW+Lz1//QnXAwxHIkvF4yW 6dchgbPcTwSNCBiTbGIMuTBmkEquKlAdwic7WWO4NAIKMXyOPJrP9171Uf2VUg0A4RJs SaNGmeLRvjUCJHdxf/+If6oudX4GNonpbvKHjIGuAQV4fGGVw/oJLm0PXWjpHiFZjgfU tL9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EkcG1ecxbRvbtTZp8pykP1WrSpDo5FL3IoRO1jdwX4A=; b=jFQGdQNSEcrZbXxxRCetejXl39byvwEnF1faq98YrcukD5xdwYpnsDxu6tIKG7R1PM WjRAnfoigdP6sUpNG7gNMwiRrMAqJbittVkTQ51N4yF7G3wTm1WMdJCN9EpZQP+vzws3 OuFJHVETG6OlrWqlXiK8rOGqIZJgDdmuAilUq4HNgPuGMGYnyzUVTPdAUTW10EGeKdug VgT0du5okpuT2ysYWAoR7cwaQfcqBpDbEFqlXhzAxi3ZLA68ewLyrbsQxwi9RLcyc0Ab hfweg87+8vFWIOw0e4c8WcYXUe1nK7Pp7hXLG359dqoy4ZEc5OUIAjBX2zH+dvaU63D/ cMqw== X-Gm-Message-State: APjAAAVVVZF1psLp81uad6oN4RW4ee16k8Ef74GBlFQng0PLybsRO+Ph ktCl+/AvBgBkpPzKHpBcFdX9nbSHYZor7XD/qa/TPA== X-Received: by 2002:a5d:68cd:: with SMTP id p13mr12937108wrw.22.1555351607916; Mon, 15 Apr 2019 11:06:47 -0700 (PDT) MIME-Version: 1.0 References: <20190411184741.27540-1-tmurphy@arista.com> <20190411184741.27540-10-tmurphy@arista.com> <20190415062316.GC18154@infradead.org> In-Reply-To: <20190415062316.GC18154@infradead.org> From: Tom Murphy Date: Mon, 15 Apr 2019 19:06:36 +0100 Message-ID: Subject: Re: [PATCH 9/9] iommu/amd: Add allocated domain to global list earlier To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, Heiko Stuebner , Will Deacon , David Brown , linux-samsung-soc@vger.kernel.org, Dmitry Safonov , Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Andy Gross , Marc Zyngier , linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Murphy , Robin Murphy Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >This seems like a fix to the existing code and should probably go out first. I'll send this patch out on it's own now. On Mon, Apr 15, 2019 at 7:23 AM Christoph Hellwig wrote: > > On Thu, Apr 11, 2019 at 07:47:38PM +0100, Tom Murphy via iommu wrote: > > dma_ops_domain_free() expects domain to be in a global list. > > Arguably, could be called before protection_domain_init(). > > > > Signed-off-by: Dmitry Safonov > > Signed-off-by: Tom Murphy > > This seems like a fix to the existing code and should probably go > out first.