Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2466122yba; Mon, 15 Apr 2019 12:13:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqyV/VWu8A7/8OHnpnRj/+3LY/Rttbrbs+xE6EaSY7F+Hr4gtwY/CCJXu8xdby40OdXhiSEF X-Received: by 2002:a63:554b:: with SMTP id f11mr71663092pgm.77.1555355619191; Mon, 15 Apr 2019 12:13:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555355619; cv=none; d=google.com; s=arc-20160816; b=JpC1nix5k3t2n2R5gWrsaTtA67sTMrubfG3hcfEa8bylyArf1vm/fvf+RGzriitEpS Uw+YeAurx7r+4Xo4f+ARP6ClVOsbehm3mKNX/Y2pZz3Zh9yTWA+6UMQ7z71SkMnv095m MrLQAVoFHtXmmIxQLRPelPx75Rki00cgiRvwXvVXgOA7AH/F3AIh6ecItVa+O8ZrWKWm sp5g58DOzt3G1ztBmlMzrv30sv0r2mvUjJrD0xQymA2PEOJV4Py4hr4xDgnB80/UGbcw yEcGMud5InN7eNd+PS4S9Gi2H4WF6I16jCHa/sf7xLDs1YoskQ1VcG36IsOH+MSOjZLW 30AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=y6GonkIqKiD05ivJnq1gh8kCU72myX9cMwkzagmOygs=; b=CrKQv29H1SrR4n0RZVOZxfpocxsgyPIpoNX8SksOiudrVBwlYHV46GUDr3wJ3VDC8/ A8Nfw8C4rb8abocK2zYFmWUrv8aScYEvs7dSBrmI90X+DwSRAztvPizojSPjCibFnazc NeCWAn7X0AM4LKPWCyVkn6kEKX4bGZ750fwuKc54GzLeExKAGHaBq67xKB4sAWrPicin NRhkPc0ukN70d3Lik9jFVXYfUlJVgrGoQqnEe48UWCC/DKiZU+Wq29W8dEzBmgpR0U8V OSWhWu6HlKV4mbKGHC0Vz0zAcVDDXpITkYjvvKKHIbU067fYHC7FPkd8z/xy5zx1OjFM Rz8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=G+CbHK3g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l2si23801128pgq.416.2019.04.15.12.13.22; Mon, 15 Apr 2019 12:13:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=G+CbHK3g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731121AbfDOTKz (ORCPT + 99 others); Mon, 15 Apr 2019 15:10:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:47522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731113AbfDOTKw (ORCPT ); Mon, 15 Apr 2019 15:10:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C906F21902; Mon, 15 Apr 2019 19:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555355451; bh=EgYgkLnUqtVpIAwaB9qjdHKIqfOCQFk2iDa5+b95ydg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G+CbHK3gxnwjuGEqD/CUkcMrlzZp57bN2xQfNRKHNT1q4JFpjPbk9xCvnmY73YUhj 3R6LFykYxWtM5MXtFdiGQO+IClzXVl4JkXcV5/n03WccN1Ipz9Jm/1GyMfLmabJLzo zDcWp3w6/JbReLzkDMwupsx9wN48rCxiaassKdvY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Huy Nguyen , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.0 040/117] net/mlx5e: Update xoff formula Date: Mon, 15 Apr 2019 21:00:10 +0200 Message-Id: <20190415183747.071879739@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190415183744.887851196@linuxfoundation.org> References: <20190415183744.887851196@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5ec983e924c7978aaec3cf8679ece9436508bb20 ] Set minimum speed in xoff threshold formula to 40Gbps Fixes: 0696d60853d5 ("net/mlx5e: Receive buffer configuration") Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- .../net/ethernet/mellanox/mlx5/core/en/port_buffer.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/port_buffer.c b/drivers/net/ethernet/mellanox/mlx5/core/en/port_buffer.c index eac245a93f91..f00de0c987cd 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/port_buffer.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/port_buffer.c @@ -122,7 +122,9 @@ static int port_set_buffer(struct mlx5e_priv *priv, return err; } -/* xoff = ((301+2.16 * len [m]) * speed [Gbps] + 2.72 MTU [B]) */ +/* xoff = ((301+2.16 * len [m]) * speed [Gbps] + 2.72 MTU [B]) + * minimum speed value is 40Gbps + */ static u32 calculate_xoff(struct mlx5e_priv *priv, unsigned int mtu) { u32 speed; @@ -130,10 +132,9 @@ static u32 calculate_xoff(struct mlx5e_priv *priv, unsigned int mtu) int err; err = mlx5e_port_linkspeed(priv->mdev, &speed); - if (err) { - mlx5_core_warn(priv->mdev, "cannot get port speed\n"); - return 0; - } + if (err) + speed = SPEED_40000; + speed = max_t(u32, speed, SPEED_40000); xoff = (301 + 216 * priv->dcbx.cable_len / 100) * speed / 1000 + 272 * mtu / 100; -- 2.19.1