Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2474197yba; Mon, 15 Apr 2019 12:23:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYu+xvW0+UnUNcv+z4uYMwKowry5CDP2q9yXaxXbAhJFad+bNOHS50QuCl7jg+ybYkWkKD X-Received: by 2002:a17:902:9a4a:: with SMTP id x10mr78185040plv.113.1555356226044; Mon, 15 Apr 2019 12:23:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555356226; cv=none; d=google.com; s=arc-20160816; b=e2t80wg2/DAizaTz7lcVk2yw3qSs9ZyRBzSeJF15WPI5n4a5nBoKnaB3xFKx+A3lxS TzlNDA3CREZZbszTTPijAst1XsS1VnFNNZaUqKz+aMeuffoQAHXRzGqGlQpkc0t/9vkB kNU4RzNPYi+gV5fyaPTSD7cUvhQdmzaNAzSe1V5+Zo54hQce2He/U0xC9uQswRciDukX Qatjv4f/RSwI2cMNQhLC46pQxAZYY0f+EVBhUJuCHsRVWgWwZIy954T5R4UXK+ixGEJY JVv7IZMHYhYTMH0t8ENOSz2vJmQKnTpQMAxrgNqAkse4wVjR+rJH4ZEmmL3ZfNZHVPF6 6nXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0955EYjaU3sJG7klX+sy26Os45F5lnFDkQAJk/EE8ec=; b=YZL/znmHsLkVFWTPpR2GbyzJl4uuNBsCyOTORO10Bzq8AsIC9hrqQfwr4SFe+HR7yq AZdt5qwB+fT8B3b5k9XW9y0HGlytyBUgkmPakc08SOk5NA7B75SZeGghoWH69EbcXCM9 HM+oFr0d6S+f8U8hzx2DXXrHNExn7VnlE7kbSyQBbvJMKENDEVtmaB6VCCrGjBCVpmbC n2irz0wnQqT6mwSpoZV10fg8Ov7QVKaDXd4IRrh2vJXOECPcFMNN2WjILkC0Y016h6lr AvDQbZxtt/7ypim+8kkA1fhFG+w+VlDxL0ci+32vLJpKWcMXjNIo/dLWd11L/BD5b5ki 37VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uXlSNQEV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci5si42232587plb.145.2019.04.15.12.23.29; Mon, 15 Apr 2019 12:23:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uXlSNQEV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730455AbfDOTIY (ORCPT + 99 others); Mon, 15 Apr 2019 15:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:43668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730435AbfDOTIU (ORCPT ); Mon, 15 Apr 2019 15:08:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 296672087C; Mon, 15 Apr 2019 19:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555355299; bh=A9/sjEV9AVKH+E2s2bhSwP0CP96sR+C7eW0NZ1Red4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uXlSNQEVjdXB0uGlx//1IG4OCsZfwN6PbEzG1sfrJeLLEWyzn/B1Ai950kyFGvb1e GbHesj74+nbLDgoMfP8JbjIT+dJwZp8ClloD6XPRstMm81slZ3Qol/76DlzZG1MwAC 6dkWeyh8H4y/c+vMIflbRHQwtMWeC/1NZAL8tY/8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rasmus Villemoes , Borislav Petkov , "H. Peter Anvin" , Dan Williams , Geert Uytterhoeven , Ingo Molnar , Matthew Wilcox , Peter Zijlstra , Thomas Gleixner , x86-ml Subject: [PATCH 4.19 086/101] x86/asm: Remove dead __GNUC__ conditionals Date: Mon, 15 Apr 2019 20:59:24 +0200 Message-Id: <20190415183744.944695636@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190415183740.341577907@linuxfoundation.org> References: <20190415183740.341577907@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes commit 88ca66d8540ca26119b1428cddb96b37925bdf01 upstream. The minimum supported gcc version is >= 4.6, so these can be removed. Signed-off-by: Rasmus Villemoes Signed-off-by: Borislav Petkov Cc: "H. Peter Anvin" Cc: Dan Williams Cc: Geert Uytterhoeven Cc: Ingo Molnar Cc: Matthew Wilcox Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: x86-ml Link: https://lkml.kernel.org/r/20190111084931.24601-1-linux@rasmusvillemoes.dk Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/bitops.h | 6 ------ arch/x86/include/asm/string_32.h | 20 -------------------- arch/x86/include/asm/string_64.h | 15 --------------- 3 files changed, 41 deletions(-) --- a/arch/x86/include/asm/bitops.h +++ b/arch/x86/include/asm/bitops.h @@ -36,13 +36,7 @@ * bit 0 is the LSB of addr; bit 32 is the LSB of (addr+1). */ -#if __GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 1) -/* Technically wrong, but this avoids compilation errors on some gcc - versions. */ -#define BITOP_ADDR(x) "=m" (*(volatile long *) (x)) -#else #define BITOP_ADDR(x) "+m" (*(volatile long *) (x)) -#endif #define ADDR BITOP_ADDR(addr) --- a/arch/x86/include/asm/string_32.h +++ b/arch/x86/include/asm/string_32.h @@ -179,14 +179,7 @@ static inline void *__memcpy3d(void *to, * No 3D Now! */ -#if (__GNUC__ >= 4) #define memcpy(t, f, n) __builtin_memcpy(t, f, n) -#else -#define memcpy(t, f, n) \ - (__builtin_constant_p((n)) \ - ? __constant_memcpy((t), (f), (n)) \ - : __memcpy((t), (f), (n))) -#endif #endif #endif /* !CONFIG_FORTIFY_SOURCE */ @@ -282,12 +275,7 @@ void *__constant_c_and_count_memset(void { int d0, d1; -#if __GNUC__ == 4 && __GNUC_MINOR__ == 0 - /* Workaround for broken gcc 4.0 */ - register unsigned long eax asm("%eax") = pattern; -#else unsigned long eax = pattern; -#endif switch (count % 4) { case 0: @@ -321,15 +309,7 @@ void *__constant_c_and_count_memset(void #define __HAVE_ARCH_MEMSET extern void *memset(void *, int, size_t); #ifndef CONFIG_FORTIFY_SOURCE -#if (__GNUC__ >= 4) #define memset(s, c, count) __builtin_memset(s, c, count) -#else -#define memset(s, c, count) \ - (__builtin_constant_p(c) \ - ? __constant_c_x_memset((s), (0x01010101UL * (unsigned char)(c)), \ - (count)) \ - : __memset((s), (c), (count))) -#endif #endif /* !CONFIG_FORTIFY_SOURCE */ #define __HAVE_ARCH_MEMSET16 --- a/arch/x86/include/asm/string_64.h +++ b/arch/x86/include/asm/string_64.h @@ -32,21 +32,6 @@ static __always_inline void *__inline_me extern void *memcpy(void *to, const void *from, size_t len); extern void *__memcpy(void *to, const void *from, size_t len); -#ifndef CONFIG_FORTIFY_SOURCE -#if (__GNUC__ == 4 && __GNUC_MINOR__ < 3) || __GNUC__ < 4 -#define memcpy(dst, src, len) \ -({ \ - size_t __len = (len); \ - void *__ret; \ - if (__builtin_constant_p(len) && __len >= 64) \ - __ret = __memcpy((dst), (src), __len); \ - else \ - __ret = __builtin_memcpy((dst), (src), __len); \ - __ret; \ -}) -#endif -#endif /* !CONFIG_FORTIFY_SOURCE */ - #define __HAVE_ARCH_MEMSET void *memset(void *s, int c, size_t n); void *__memset(void *s, int c, size_t n);