Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2479453yba; Mon, 15 Apr 2019 12:30:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqwCAbYlDSHiGaOYhoNMwiKrRBvScoDrK7cVTqQ2lpsvNlPFtnP5SuuHvJDUs+hRde3LvDiv X-Received: by 2002:a65:6210:: with SMTP id d16mr69901620pgv.110.1555356651652; Mon, 15 Apr 2019 12:30:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555356651; cv=none; d=google.com; s=arc-20160816; b=pGSqqpsWXnWnG//N7DhbJv1zBctROjzi9mWs2f9QlfTEwG4BBoNXMVliV7y+drsIOw k2NaguYulB+11Uml9f+YnP2RZQeXo/G19cd1OdWHr5aiqbAFbyLLQfnMJANlo+D217xO g+sbcAB6fkUv3mCSD09pbNasXTDkRYCml6ySeceiYG5DuEe8dN2gZ/J72Ful8abpq67F UGbc1PFF+1t/3CBC/Z4kLk2+bWjAmWXgh9Fud1yEMMuTWd5g230pUW8WnMtKyeYnnI7s IEaa4uZoqxECbmnPeW7OMbWGXwEoqlwbuGv5f72PSsXHM6rp0ligO9CvkrAUnuMMiK2t 2TGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kw3bCj6xTX1UlDt3w94wYeZwL7i4WOsyyxVq2Gu9Bws=; b=DdZZ1nq+XlQFQJzAWkST+pirsuT4XWT6RTpEcbvaHXnUijy6Ue9LGPiMdvzM1NBS86 jNbKDMrfoBeouX++XlsDYpbtfk/zWfgEtHhJbdMg9oPDbqEGHAWVLVxzW4e//T/+NZW9 Ss0D6Aye8TTo29FO5adBsRhiHhYRzU9bBHqjjVyMRQwLn8Le0UlmdzJm6kf9pPl/l+LG a23MXcXM5pH1hEzb7aYACCTksWNWze5MjkLYLC10guAjfsoG8cugo4ixgE97X3XjHzn5 TJuLMpKSo1/F4gNKBveh8pMEisrj592gwi7Ti4Qg3ZLVYGwdD0BWcDCsDu1I+Ja8HDW7 WbTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kzD6673c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3si7048174plc.236.2019.04.15.12.30.35; Mon, 15 Apr 2019 12:30:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kzD6673c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728852AbfDOTCe (ORCPT + 99 others); Mon, 15 Apr 2019 15:02:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:33494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728811AbfDOTCc (ORCPT ); Mon, 15 Apr 2019 15:02:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AF6920880; Mon, 15 Apr 2019 19:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555354950; bh=QJwJzCoYrUbP4tRvZqzOepYq9OX3Sy1D5I+WuMo/gmI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kzD6673cu9LYFgaE3hrJyYiuN18pKhJTA23XEWkhA6cRhW0uuMyBEZPWXZaG7+Ol3 2tmKqH6HntHj6E3i/FZbE9OiBMhrhdZ3QrHOEzHpWUob0BKeDibXiMAqCvbtJtEZ+7 P3qrRU31lqafXqMh2C/x3Z/FDsu0mXY7F8TnQR98= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nick Desaulniers , Nathan Chancellor , Adhemerval Zanella , Arnd Bergmann , James Y Knight , Masahiro Yamada , Rasmus Villemoes , "Steven Rostedt (VMware)" , Andy Shevchenko , David Laight , Namhyung Kim , Alexander Shishkin , Dan Williams , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.14 11/69] lib/string.c: implement a basic bcmp Date: Mon, 15 Apr 2019 20:58:29 +0200 Message-Id: <20190415183729.077562051@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190415183726.036654568@linuxfoundation.org> References: <20190415183726.036654568@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5f074f3e192f10c9fade898b9b3b8812e3d83342 ] A recent optimization in Clang (r355672) lowers comparisons of the return value of memcmp against zero to comparisons of the return value of bcmp against zero. This helps some platforms that implement bcmp more efficiently than memcmp. glibc simply aliases bcmp to memcmp, but an optimized implementation is in the works. This results in linkage failures for all targets with Clang due to the undefined symbol. For now, just implement bcmp as a tailcail to memcmp to unbreak the build. This routine can be further optimized in the future. Other ideas discussed: * A weak alias was discussed, but breaks for architectures that define their own implementations of memcmp since aliases to declarations are not permitted (only definitions). Arch-specific memcmp implementations typically declare memcmp in C headers, but implement them in assembly. * -ffreestanding also is used sporadically throughout the kernel. * -fno-builtin-bcmp doesn't work when doing LTO. Link: https://bugs.llvm.org/show_bug.cgi?id=41035 Link: https://code.woboq.org/userspace/glibc/string/memcmp.c.html#bcmp Link: https://github.com/llvm/llvm-project/commit/8e16d73346f8091461319a7dfc4ddd18eedcff13 Link: https://github.com/ClangBuiltLinux/linux/issues/416 Link: http://lkml.kernel.org/r/20190313211335.165605-1-ndesaulniers@google.com Signed-off-by: Nick Desaulniers Reported-by: Nathan Chancellor Reported-by: Adhemerval Zanella Suggested-by: Arnd Bergmann Suggested-by: James Y Knight Suggested-by: Masahiro Yamada Suggested-by: Nathan Chancellor Suggested-by: Rasmus Villemoes Acked-by: Steven Rostedt (VMware) Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor Reviewed-by: Masahiro Yamada Reviewed-by: Andy Shevchenko Cc: David Laight Cc: Rasmus Villemoes Cc: Namhyung Kim Cc: Greg Kroah-Hartman Cc: Alexander Shishkin Cc: Dan Williams Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- include/linux/string.h | 3 +++ lib/string.c | 20 ++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/include/linux/string.h b/include/linux/string.h index 96115bf561b4..3d43329c20be 100644 --- a/include/linux/string.h +++ b/include/linux/string.h @@ -142,6 +142,9 @@ extern void * memscan(void *,int,__kernel_size_t); #ifndef __HAVE_ARCH_MEMCMP extern int memcmp(const void *,const void *,__kernel_size_t); #endif +#ifndef __HAVE_ARCH_BCMP +extern int bcmp(const void *,const void *,__kernel_size_t); +#endif #ifndef __HAVE_ARCH_MEMCHR extern void * memchr(const void *,int,__kernel_size_t); #endif diff --git a/lib/string.c b/lib/string.c index 5e8d410a93df..1530643edf00 100644 --- a/lib/string.c +++ b/lib/string.c @@ -865,6 +865,26 @@ __visible int memcmp(const void *cs, const void *ct, size_t count) EXPORT_SYMBOL(memcmp); #endif +#ifndef __HAVE_ARCH_BCMP +/** + * bcmp - returns 0 if and only if the buffers have identical contents. + * @a: pointer to first buffer. + * @b: pointer to second buffer. + * @len: size of buffers. + * + * The sign or magnitude of a non-zero return value has no particular + * meaning, and architectures may implement their own more efficient bcmp(). So + * while this particular implementation is a simple (tail) call to memcmp, do + * not rely on anything but whether the return value is zero or non-zero. + */ +#undef bcmp +int bcmp(const void *a, const void *b, size_t len) +{ + return memcmp(a, b, len); +} +EXPORT_SYMBOL(bcmp); +#endif + #ifndef __HAVE_ARCH_MEMSCAN /** * memscan - Find a character in an area of memory. -- 2.19.1