Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2479943yba; Mon, 15 Apr 2019 12:31:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwYZhdib/Rg0d7RXQXDJQfdwzZYY4EmD641kDWK445uYTxhZHOJ2m2ju3M4Wh17w1RJBPkX X-Received: by 2002:a17:902:9a83:: with SMTP id w3mr78416144plp.241.1555356683569; Mon, 15 Apr 2019 12:31:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555356683; cv=none; d=google.com; s=arc-20160816; b=nsC0/Q3HCawUra/PByBavvD5pY1bp+OC0d26b/OSZMvhxzjBiqDuTKLnRMjuO4RCuo 9Q9ANhZM9G/Uml6wLSqgvZLLEu/P/MscLAnmGVjuh5jgi2JVR55C/e5IipONpezvXc+v xJ0zj67g9sqN0brXOYR35CnXmI6IBxDzDLtpnGBGVw3WJspP6SbKp4pFguys5GNjd03x TXZEl0DbenR7rBxoIHC/HAkq50GYQXczyGFw5swoM5FMPC9rkrrPHhK5VH1U+TGf0frX dV3JGFWp0rI/XFp0imXeVkup+J7AzkZzeVnrPxBNspj4k0Z4XnqUXBhVKkNWxlKqOqFO 046Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PLwB9KgE+VocgX5kSmcRpccbmwbPaHsVDRnUbVW+yhs=; b=TYR/Wy7bmvfIdT8zkrX/4MkrqaqkgrRFaGTCdXyIkPYXc5AuBKEo0gru2TTkzdRvTT 3wgiEQhpPpftpaBDANZqJ8fw+fOsO9qrIILaYwCH3hgIizNljzQS8WQ51TZXuYziQRh5 VZFY3Y+PQ34O+PDLvNqpnJewzKD07dVWvcHQuXbOceanv2urw7WbkwvpSfQHHekmg+37 1Go98pDhWXKXxWEy1Tp8o30d/DiZ3vcvbQ7OxevSrSrdhm/TfXBZ+85lNe/J9GW/Bk77 JSm6KHc+NH3iZ7Oog5MvTi49sK9DkufT7uK925VhyZ65prDirHwkkKPxEHN46sM/Qy4z mRbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1VqiKokN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10si45538462plq.152.2019.04.15.12.31.07; Mon, 15 Apr 2019 12:31:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1VqiKokN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729377AbfDOT2g (ORCPT + 99 others); Mon, 15 Apr 2019 15:28:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:34610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729063AbfDOTDF (ORCPT ); Mon, 15 Apr 2019 15:03:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81710218A1; Mon, 15 Apr 2019 19:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555354985; bh=bIjtFkr6dobepKeOQyevUQ0HMBkkPzKirZY8YCnRA8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1VqiKokNBS90xgMVRvZwVjDHauozk2wRd9CsaoexB9wABitqqIEQeI7MBjoLBZmM4 DnHXz46sGowcA2aKZaGeI3F/YDFZiZFFeQv3s7eDSQk7u4oT95xlsst+tzCiH7aKr8 7TN74uIWbKZ9g64SOo4DSfxPjT4kkzAFzAF15PnM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peter Geis , Heiko Stuebner Subject: [PATCH 4.14 39/69] arm64: dts: rockchip: fix rk3328 sdmmc0 write errors Date: Mon, 15 Apr 2019 20:58:57 +0200 Message-Id: <20190415183732.516724622@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190415183726.036654568@linuxfoundation.org> References: <20190415183726.036654568@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Geis commit 09f91381fa5de1d44bc323d8bf345f5d57b3d9b5 upstream. Various rk3328 based boards experience occasional sdmmc0 write errors. This is due to the rk3328.dtsi tx drive levels being set to 4ma, vs 8ma per the rk3328 datasheet default settings. Fix this by setting the tx signal pins to 8ma. Inspiration from tonymac32's patch, https://github.com/ayufan-rock64/linux-kernel/commit/dc1212b347e0da17c5460bcc0a56b07d02bac3f8 Fixes issues on the rk3328-roc-cc and the rk3328-rock64 (as per the above commit message). Tested on the rk3328-roc-cc board. Fixes: 52e02d377a72 ("arm64: dts: rockchip: add core dtsi file for RK3328 SoCs") Cc: stable@vger.kernel.org Signed-off-by: Peter Geis Signed-off-by: Heiko Stuebner Signed-off-by: Greg Kroah-Hartman --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -1333,11 +1333,11 @@ sdmmc0 { sdmmc0_clk: sdmmc0-clk { - rockchip,pins = <1 RK_PA6 1 &pcfg_pull_none_4ma>; + rockchip,pins = <1 RK_PA6 1 &pcfg_pull_none_8ma>; }; sdmmc0_cmd: sdmmc0-cmd { - rockchip,pins = <1 RK_PA4 1 &pcfg_pull_up_4ma>; + rockchip,pins = <1 RK_PA4 1 &pcfg_pull_up_8ma>; }; sdmmc0_dectn: sdmmc0-dectn { @@ -1349,14 +1349,14 @@ }; sdmmc0_bus1: sdmmc0-bus1 { - rockchip,pins = <1 RK_PA0 1 &pcfg_pull_up_4ma>; + rockchip,pins = <1 RK_PA0 1 &pcfg_pull_up_8ma>; }; sdmmc0_bus4: sdmmc0-bus4 { - rockchip,pins = <1 RK_PA0 1 &pcfg_pull_up_4ma>, - <1 RK_PA1 1 &pcfg_pull_up_4ma>, - <1 RK_PA2 1 &pcfg_pull_up_4ma>, - <1 RK_PA3 1 &pcfg_pull_up_4ma>; + rockchip,pins = <1 RK_PA0 1 &pcfg_pull_up_8ma>, + <1 RK_PA1 1 &pcfg_pull_up_8ma>, + <1 RK_PA2 1 &pcfg_pull_up_8ma>, + <1 RK_PA3 1 &pcfg_pull_up_8ma>; }; sdmmc0_gpio: sdmmc0-gpio {