Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2506572yba; Mon, 15 Apr 2019 13:08:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqwpKXk+nkyka2pYgIuqthUsv8bAJzGHwJK0aplwDO0VGHHnJ/3gTnK/dCkzd/5mBPc8btBC X-Received: by 2002:a63:fc5a:: with SMTP id r26mr68863021pgk.97.1555358909316; Mon, 15 Apr 2019 13:08:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555358909; cv=none; d=google.com; s=arc-20160816; b=E46hQeTg/CF9zLmgSH6kJZA9xtyxdxAtrjZR0lAG88Q9wacXjqNt7vfF/kQDqZ7/v4 ftfk7J7nxetRxFDauqjcuJKnFifMEvtv/zrkSr7ldgeuUb+GKmyyJx10tBFhzW5cONLa 8gwulaSUI2tKCetbt7diBoOGdLiiLtGGtm2o+Sb8uXTFF7oDS+IJEEg8qoVY4I+aRxJH RgAVZsmtEN7kSUllgd3JBCcQ2EXorTV2mp0nsCogu5cTNZ0XVWxWB3glcnEXjVcb/y6J BlpO9ZGndlBOV2Mfw6f6cms1LbqtL55rNzTMAyIYB3ozQoiKP+NxKB75mIGJMNpBH8b5 nOgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=m5CrqpBfxX/TF2jRIVFhRigFUveOTZBrwBellhk68E8=; b=MCrkHBZXWegTZ5Hn2XQYrKnP6sw4uOh1zoVikyj58yfutwyP8ISKvGfmN2WqvsDHo5 p5mWsqHf6ApC0ZVZc74N1RuheWW7JkpkHA3yGhlRYYvCgvkERkIgnSRZKKX80MF+TyQ6 522MdMeCGc1KbSif7UOJpRxmJc85j6xmg+9BMmuMe6OiHMPbEQIE1bBYQWNknptVnSmE m7lpbs8LF2JLQOvYPzpf81VHl6a8VJA/qfumIicliN4wGC83kSdlGq/WKxrBNZL9q9eW GjeocT9kdugPhiLgWIVYVnyyBVec/3xEIwv3KseO8O828/0oVcTU6ZG5WIzHl0l+GWAs QBEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4si48291383pfj.16.2019.04.15.13.08.13; Mon, 15 Apr 2019 13:08:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729180AbfDOUH3 (ORCPT + 99 others); Mon, 15 Apr 2019 16:07:29 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40444 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728905AbfDOUH2 (ORCPT ); Mon, 15 Apr 2019 16:07:28 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 6D990808B5; Mon, 15 Apr 2019 22:07:18 +0200 (CEST) Date: Mon, 15 Apr 2019 22:07:26 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jarkko Nikula , Andy Lutomirski , "Rafael J. Wysocki" , Thomas Gleixner , Borislav Petkov , Josh Poimboeuf , Linus Torvalds , Peter Zijlstra , "Rafael J. Wysocki" , Zhang Rui , Ingo Molnar , Sasha Levin Subject: Re: [PATCH 4.14 03/69] x86/power/64: Use struct desc_ptr for the IDT in struct saved_context Message-ID: <20190415200726.GB25908@amd> References: <20190415183726.036654568@linuxfoundation.org> <20190415183726.883542005@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p4qYPpj5QlsIQJ0K" Content-Disposition: inline In-Reply-To: <20190415183726.883542005@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p4qYPpj5QlsIQJ0K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2019-04-15 20:58:21, Greg Kroah-Hartman wrote: > [ Upstream commit 090edbe23ff57940fca7f57d9165ce57a826bd7a ] >=20 > x86_64's saved_context nonsensically used separate idt_limit and > idt_base fields and then cast &idt_limit to struct desc_ptr *. >=20 > This was correct (with -fno-strict-aliasing), but it's confusing, > served no purpose, and required #ifdeffery. Simplify this by > using struct desc_ptr directly. >=20 > No change in functionality. While this is nice cleanup, I don't think it fixes real bug. I don't think it is suitable for stable. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --p4qYPpj5QlsIQJ0K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAly05H4ACgkQMOfwapXb+vI8vwCgpFPRTxX1otqogabjtE4mQxQ6 7REAoJafCSaqi+UbR69IaTdzovq5xZtA =gtHO -----END PGP SIGNATURE----- --p4qYPpj5QlsIQJ0K--