Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2524209yba; Mon, 15 Apr 2019 13:33:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQB/MLGy0LwZJDPOcmtpBeX9qcJqi+1CIllmsEtYf03HxHAn+9I47YTLIVDENdxYSLyNzr X-Received: by 2002:a63:4144:: with SMTP id o65mr68578414pga.241.1555360383705; Mon, 15 Apr 2019 13:33:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555360383; cv=none; d=google.com; s=arc-20160816; b=WOKoGd5sddiuwXboNLyuCEAeK6d7IKAyEfDBEj6uED75xejURe3QxJ1CBcjCYyeB9C rb8wt6nKVfTV3LW+dId9VUYwvkyr62fkAvTgXMF7SaPPqP6Y1pjrbz2BZYsbol6jI9Kj Hw1bzFvDt0ah59ItrMB1EX+ywjx/1porWaflwW6UJsYFghbyWmcQQf/SnvIP6eq9H7bT +S2mtG6Po5QcxC7ZKCR3R8P4KONNBwuVhMTI2RUEnZWFP4YhGiuPXkc5zyu7PDm6LWim a34S1qeIAu0TNsCH3H8HMIs7mBptA9BpShzZcGYZ+A0qe2KiVcbAXCZe2cXQbY3ckIWG Rxig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Jc0XiRTu31/pCI+0S1F9Aksj4plybQk+apIcCCTLRpw=; b=k5wM5A7odyIdBmFJFal7SjL5HPtijIHD6fJUY32V0o9dH6Y9KZNkRCnFVzw4viVU2v aDuHBCUWHw99PyCsmvDMLZYMFfVaEPHZMtgZDEznG+OFmD0Lfccia/ckvcoZosRrPLER M1t+/K/YjYbU3xIpEi9cRsq++1zOmHsQ+bary9+6l85Bg9Te6wva37ljNOIwSMPY+eLv +uEyjrBuh32CufuVZ2oTSHRH2AXSagz5KuQUga7m/J2jZjs3nn5wcn6xtui3XfBxvmVG v289dcLE5eD489fo9nXdN+1tAW6+b3pXBas3cDSj6c5UUsGtd73HToevtqHsN2EgY+UI DoGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d3p8s8iZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j91si12463288pld.199.2019.04.15.13.32.46; Mon, 15 Apr 2019 13:33:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d3p8s8iZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731446AbfDOTPZ (ORCPT + 99 others); Mon, 15 Apr 2019 15:15:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:52312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730881AbfDOTOL (ORCPT ); Mon, 15 Apr 2019 15:14:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 729DE2073F; Mon, 15 Apr 2019 19:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555355650; bh=WvdxNWhfu86TFr5kc+o9igrBs1ywMP3YufYZFiWd8R8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d3p8s8iZ2262sBCrbdwvuamdZju/LL3Vex7k6kMXXcyUjc0YiHKo5+gQS4Bmw0w3k sb09aW10/TOKWMBomMOFwTnEpzcXsMD/xBzAcsw4q5CC+b43tqq9bGJ1tEQIgjLmSd NXgsvJLcMeKwqz18EUfzHCJcV/NK5zp4o0rw8nW4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rasmus Villemoes , Borislav Petkov , "H. Peter Anvin" , Dan Williams , Geert Uytterhoeven , Ingo Molnar , Matthew Wilcox , Peter Zijlstra , Thomas Gleixner , x86-ml Subject: [PATCH 5.0 101/117] x86/asm: Remove dead __GNUC__ conditionals Date: Mon, 15 Apr 2019 21:01:11 +0200 Message-Id: <20190415183749.921875504@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190415183744.887851196@linuxfoundation.org> References: <20190415183744.887851196@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes commit 88ca66d8540ca26119b1428cddb96b37925bdf01 upstream. The minimum supported gcc version is >= 4.6, so these can be removed. Signed-off-by: Rasmus Villemoes Signed-off-by: Borislav Petkov Cc: "H. Peter Anvin" Cc: Dan Williams Cc: Geert Uytterhoeven Cc: Ingo Molnar Cc: Matthew Wilcox Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: x86-ml Link: https://lkml.kernel.org/r/20190111084931.24601-1-linux@rasmusvillemoes.dk Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/bitops.h | 6 ------ arch/x86/include/asm/string_32.h | 20 -------------------- arch/x86/include/asm/string_64.h | 15 --------------- 3 files changed, 41 deletions(-) --- a/arch/x86/include/asm/bitops.h +++ b/arch/x86/include/asm/bitops.h @@ -36,13 +36,7 @@ * bit 0 is the LSB of addr; bit 32 is the LSB of (addr+1). */ -#if __GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 1) -/* Technically wrong, but this avoids compilation errors on some gcc - versions. */ -#define BITOP_ADDR(x) "=m" (*(volatile long *) (x)) -#else #define BITOP_ADDR(x) "+m" (*(volatile long *) (x)) -#endif #define ADDR BITOP_ADDR(addr) --- a/arch/x86/include/asm/string_32.h +++ b/arch/x86/include/asm/string_32.h @@ -179,14 +179,7 @@ static inline void *__memcpy3d(void *to, * No 3D Now! */ -#if (__GNUC__ >= 4) #define memcpy(t, f, n) __builtin_memcpy(t, f, n) -#else -#define memcpy(t, f, n) \ - (__builtin_constant_p((n)) \ - ? __constant_memcpy((t), (f), (n)) \ - : __memcpy((t), (f), (n))) -#endif #endif #endif /* !CONFIG_FORTIFY_SOURCE */ @@ -282,12 +275,7 @@ void *__constant_c_and_count_memset(void { int d0, d1; -#if __GNUC__ == 4 && __GNUC_MINOR__ == 0 - /* Workaround for broken gcc 4.0 */ - register unsigned long eax asm("%eax") = pattern; -#else unsigned long eax = pattern; -#endif switch (count % 4) { case 0: @@ -321,15 +309,7 @@ void *__constant_c_and_count_memset(void #define __HAVE_ARCH_MEMSET extern void *memset(void *, int, size_t); #ifndef CONFIG_FORTIFY_SOURCE -#if (__GNUC__ >= 4) #define memset(s, c, count) __builtin_memset(s, c, count) -#else -#define memset(s, c, count) \ - (__builtin_constant_p(c) \ - ? __constant_c_x_memset((s), (0x01010101UL * (unsigned char)(c)), \ - (count)) \ - : __memset((s), (c), (count))) -#endif #endif /* !CONFIG_FORTIFY_SOURCE */ #define __HAVE_ARCH_MEMSET16 --- a/arch/x86/include/asm/string_64.h +++ b/arch/x86/include/asm/string_64.h @@ -14,21 +14,6 @@ extern void *memcpy(void *to, const void *from, size_t len); extern void *__memcpy(void *to, const void *from, size_t len); -#ifndef CONFIG_FORTIFY_SOURCE -#if (__GNUC__ == 4 && __GNUC_MINOR__ < 3) || __GNUC__ < 4 -#define memcpy(dst, src, len) \ -({ \ - size_t __len = (len); \ - void *__ret; \ - if (__builtin_constant_p(len) && __len >= 64) \ - __ret = __memcpy((dst), (src), __len); \ - else \ - __ret = __builtin_memcpy((dst), (src), __len); \ - __ret; \ -}) -#endif -#endif /* !CONFIG_FORTIFY_SOURCE */ - #define __HAVE_ARCH_MEMSET void *memset(void *s, int c, size_t n); void *__memset(void *s, int c, size_t n);