Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 5d4OUqKGhiammEIZqeTJjry5peow9nHjrwY69BMnPDCRPFAxMd1V4HWtOfB2OrQmST7WrvKX/j
 AjbaUOdTURGO9633XH6QMUe10+Ssk9F3L+EbW38bbEllsuGK+rL6Uc+XGY9SNXjEZjYD4gAQAj
 4uShfLUc8pP/meOk9XwOkvKEJ8bCrmK98VVl93ONHNiYq7HGPh7VWBTFWOItt3duXAK20FmTBU
 Cy54fAYNcB8yoqOXixtGVI4+quoBaiBMgK38qYn2k1stqW67Jh9tncmh5J8KkKJ1o/jVvWmCR3
 v7CPH0zQub8SNDaxN4iSiJc1
IronPort-SDR: EqBvw8M5kci9MXpnfo4jBCpv+opR8xO7XpQ7/+x4BwpzyBvetVMzVBUhUt3J+RpsgcbgJcAuz9
 8c55e2v7iTF27P0mAz+gXZZYj2vOLTJzmf+5fgDn+nUrBqhGzgbuT2A+k5e/v42FAIwEaBvmXQ
 dJp47lxy21l2I8EUvM9zoufcm257Vvht+H8NBcfmZOzv7hvU2D7F8sqjnAeW0qLE1IwBItAC7E
 LgXOQqAo8ikg3AkYeX9T+SKEvwPFM1b4+lpS7Cp0t6uUfTaU4e2juVa2clvwMeki2Ur70qjZXL
 uck=
Subject: Re: [RFT/RFC PATCH v3 3/5] cpu-topology: Move cpu topology code to
 common code.
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jeffrey Hugo <jhugo@codeaurora.org>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Anup Patel <anup@brainfault.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Dmitriy Cherkasov <dmitriy@oss-tech.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Jeremy Linton <jeremy.linton@arm.com>,
        Johan Hovold <johan@kernel.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Otto Sabart <ottosabart@seberm.com>,
        Palmer Dabbelt <palmer@sifive.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Will Deacon <will.deacon@arm.com>
References: <20190320234806.19748-1-atish.patra@wdc.com>
 <20190320234806.19748-4-atish.patra@wdc.com>
 <20190415152741.GA28623@e107155-lin>
From:   Atish Patra <atish.patra@wdc.com>
Message-ID: <5c5b720f-414a-706c-3415-642c27baef1f@wdc.com>
Date:   Mon, 15 Apr 2019 15:08:45 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190415152741.GA28623@e107155-lin>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/15/19 8:27 AM, Sudeep Holla wrote:
> Hi Atish,
> 
> Thanks again for doing this. Overall changes look good except a couple
> of minor nit, see below.
> 
> On Wed, Mar 20, 2019 at 04:48:04PM -0700, Atish Patra wrote:
>> Both RISC-V & ARM64 are using cpu-map device tree to describe
>> their cpu topology. It's better to move the relevant code to
>> a common place instead of duplicate code.
>>
>> Signed-off-by: Atish Patra <atish.patra@wdc.com>
>> Tested-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>>   arch/arm64/include/asm/topology.h |  23 ---
>>   arch/arm64/kernel/topology.c      | 303 +-----------------------------
>>   drivers/base/arch_topology.c      | 298 ++++++++++++++++++++++++++++-
>>   drivers/base/topology.c           |   1 +
>>   include/linux/arch_topology.h     |  28 +++
>>   5 files changed, 330 insertions(+), 323 deletions(-)
>>
> 
> [...]
> 
>> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
>> index edfcf8d9..6cc6a860 100644
>> --- a/drivers/base/arch_topology.c
>> +++ b/drivers/base/arch_topology.c
>> @@ -6,8 +6,8 @@
>>    * Written by: Juri Lelli, ARM Ltd.
>>    */
>>   
>> -#include <linux/acpi.h>
>>   #include <linux/arch_topology.h>
>> +#include <linux/acpi.h>
>>   #include <linux/cpu.h>
>>   #include <linux/cpufreq.h>
>>   #include <linux/device.h>
>> @@ -16,6 +16,11 @@
>>   #include <linux/string.h>
>>   #include <linux/sched/topology.h>
>>   #include <linux/cpuset.h>
>> +#include <linux/cpumask.h>
>> +#include <linux/init.h>
>> +#include <linux/percpu.h>
>> +#include <linux/sched.h>
>> +#include <linux/smp.h>
>>   
>>   DEFINE_PER_CPU(unsigned long, freq_scale) = SCHED_CAPACITY_SCALE;
>>   
>> @@ -278,3 +283,294 @@ static void parsing_done_workfn(struct work_struct *work)
>>   #else
>>   core_initcall(free_raw_capacity);
>>   #endif
>> +
>> +#if defined(CONFIG_ARM64) || defined(CONFIG_RISCV)
> 
> Why can't the above one be just GENERIC_ARCH_TOPOLOGY ?
> I may be missing to find it myself, but would like to know.
> 
GENERIC_ARCH_TOPOLOGY is now used for both RISCV, ARM & ARM64.
The below functions under this #ifdef have different implementation for 
ARM and ARM64.

parse_dt_topology
cpu_coregroup_mask
update_siblings_masks

While we can combine the later two functions and move them to common 
code as well, parse_dt_topology is significantly different.

That's why we need some kind of #ifdef or renaming of parse_dt_topology 
for ARM32 code.

Thanks for the review!!

Regards,
Atish
>> +
>> +#if defined(CONFIG_ARM64) || defined(CONFIG_RISCV)
> 
> Ditto.
> 
> --
> Regards,
> Sudeep
>