Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2826956yba; Mon, 15 Apr 2019 21:49:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJmg6Av9eHVUadzYpPtyd04QmAle+eIJ+74Tcqh+vrqdpzbfPmNegseFL9LWOBBtPoenLb X-Received: by 2002:a17:902:e391:: with SMTP id ch17mr81570501plb.196.1555390159338; Mon, 15 Apr 2019 21:49:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555390159; cv=none; d=google.com; s=arc-20160816; b=FnQkIKdafQWdhmRV1Sy4LlKT2kCQHjAc48AnvqVEBGMf9UctKaL8lRpjdvOmXJT7+c X5KrbMh6DFV07pijh5EBUPDE8qEtFb/DaYn3Wb9E+INQDMB4VaD3ePyPAqk0S+2AfPJa jPQZGs1e0zi736LaCc4g8G2dfzIyeeNcREzOqNNGDy2GFgnrQ7W2i6vEzgAesxuIL1Hm Ie01nQH89wjg1ugNZCqZHVntaAWAsiNaJxsQ8EMy446OiPf6OG3SKo7SqGCuFh51s87d O8nx+bPrqyI8F/ASCMMv+uHM4HpZjEQSnkKu3hOJndECTeuT61lfQQywuuiuqyv84odA y9Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:cc:subject:date:to :from; bh=+eCa+mZaJTswXKos1+GyusWZXjGVEsq3C7LOlCNpPAc=; b=ppHSuyW+5nK4qLloQ+E4grtWGdwabOFYsGMmdZaokTvhaBTCJPyAIQCogWim3e67Km N1jF2XCSfTUe0IqAME5SS4X04orO3OAmsrJqd+PeAL8zp7GF/5uGfz338ZToOFB9N1sV yAyLiGH054yPbO1oX3+7GYvjOVVylOA42ZBftET4I+RIxYi9CPvDo1oB4q0ezQIC4MF2 hyYZZ6RLgwdiINrGb8ChlW88KEmBABbdFATpsJVpnkMbgzo+WIumETYiYyIlpTrVoQY5 ey2uawP8BfXK7Ocz5E2H8sXlzPlpxeXndvEFoxk8Spsv7R/OGYc0cQ+UvpE80DXc+GrU 0RAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si44869035pgo.525.2019.04.15.21.49.03; Mon, 15 Apr 2019 21:49:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726841AbfDPEsT (ORCPT + 99 others); Tue, 16 Apr 2019 00:48:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:59514 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726783AbfDPEsS (ORCPT ); Tue, 16 Apr 2019 00:48:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2A3DCAF40; Tue, 16 Apr 2019 04:48:17 +0000 (UTC) From: NeilBrown To: Ulf Hansson , Chaotian Jing Date: Tue, 16 Apr 2019 14:47:29 +1000 Subject: [PATCH 2/5] mmc: mtk-sd: don't hard-code interrupt trigger type Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, thirtythreeforty@gmail.com Message-ID: <155539004923.25108.12499096383277776864.stgit@noble.brown> In-Reply-To: <155538933003.25108.3338569916935462285.stgit@noble.brown> References: <155538933003.25108.3338569916935462285.stgit@noble.brown> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When using devicetree for configuration, interrupt trigger type should be described in the dts file, not hard-coded in the C code. The mtk-sd silicon in the mt7621 soc uses an active-high interrupt and so cannot be used with the current code. So remove the trigger and leave it to be set from devicetree. Signed-off-by: NeilBrown --- drivers/mmc/host/mtk-sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 4492a4465c0e..14e048239143 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -2243,7 +2243,7 @@ static int msdc_drv_probe(struct platform_device *pdev) msdc_init_hw(host); ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host); + 0, pdev->name, host); if (ret) goto release;