Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1555393364.9968.2.camel@mtksdccf07>
Subject: Re: [PATCH 03/14] [media] mtk-mipicsi: add color format support for
 mt2712
From:   Stu Hsieh <stu.hsieh@mediatek.com>
To:     CK Hu <ck.hu@mediatek.com>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        <srv_heupstream@mediatek.com>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>
Date:   Tue, 16 Apr 2019 13:42:44 +0800
In-Reply-To: <1554790709.10331.6.camel@mtksdaap41>
References: <1554724505-19882-1-git-send-email-stu.hsieh@mediatek.com>
         <1554724505-19882-4-git-send-email-stu.hsieh@mediatek.com>
         <1554790709.10331.6.camel@mtksdaap41>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, CK:

On Tue, 2019-04-09 at 14:18 +0800, CK Hu wrote:
> Hi, Stu:
> 
> On Mon, 2019-04-08 at 19:54 +0800, Stu Hsieh wrote:
> > This patch add color format support for mt2712
> 
> Without this patch, I think this driver still support these color
> format. In this patch, you just check for the non-supported color
> format.
> 
> > 
> > Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> > ---
> >  .../media/platform/mtk-mipicsi/mtk_mipicsi.c  | 25 +++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
> > index a5ed720df900..ccf2d18a3e74 100644
> > --- a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
> > +++ b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
> > @@ -139,6 +139,25 @@ static void mtk_mipicsi_remove_device(struct soc_camera_device *icd)
> >  	(void)pm_runtime_put_sync(icd->parent);
> >  }
> >  
> > +static bool is_supported(struct soc_camera_device *icd, const u32 pixformat)
> 
> icd is useless, so remove it.
> 
> > +{
> > +	bool ret = false;
> > +
> > +	switch (pixformat) {
> > +	/* YUV422 */
> > +	case V4L2_PIX_FMT_YUYV:
> > +	case V4L2_PIX_FMT_UYVY:
> > +	case V4L2_PIX_FMT_YVYU:
> > +	case V4L2_PIX_FMT_VYUY:
> > +		ret = true;
> 
> You could just return true.
> 
> > +		break;
> > +	default:
> > +		break;
> 
> You don't need the 'default' part.
> 
> > +	}
> > +
> > +	return ret;
> 
> You could just return false.
> 
> Regards,
> CK
> 

Ok, I would modify it in next version.

> > +}
> > +
> >  static int mtk_mipicsi_set_fmt(struct soc_camera_device *icd,
> >  				struct v4l2_format *f)
> >  {
> > @@ -154,6 +173,12 @@ static int mtk_mipicsi_set_fmt(struct soc_camera_device *icd,
> >  	struct v4l2_mbus_framefmt *mf = &format.format;
> >  	int ret = 0;
> >  
> > +	if (!is_supported(icd, pix->pixelformat)) {
> > +		dev_err(dev, "Format %x not support. set V4L2_PIX_FMT_YUYV as default\n",
> > +			pix->pixelformat);
> > +		pix->pixelformat = V4L2_PIX_FMT_YUYV;
> > +	}
> > +
> >  	xlate = soc_camera_xlate_by_fourcc(icd, pix->pixelformat);
> >  	if (xlate == NULL) {
> >  		dev_err(dev, "Format 0x%x not found\n", pix->pixelformat);
> 
>