Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2915722yba; Tue, 16 Apr 2019 00:15:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzS+G3ORAgh8a9wU5iJq309ArF6MsH4jMFKnW3ICdQMTvfxLvTrRCyIs0d0OfQ1StrxH/Rr X-Received: by 2002:a17:902:20c9:: with SMTP id v9mr59696389plg.239.1555398912980; Tue, 16 Apr 2019 00:15:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555398912; cv=none; d=google.com; s=arc-20160816; b=F+OnQzuS2bJhr01IgoId7AdhntW62hx84wMeZ1OKCiLcAPPTuBMhUEFY3IZZkXC7gE IPzS6zi+k0lTuJ4r8zrvirWjNhHHUQn5g3pg25V/VXOHDE1y2u6cIdBZHql8CjVN+GWg jGRAtYiZsNEfIgnmBZ2EKesWMn/pyuoZ45vyBrIZCC+kNUokPjyOZnrMJzNgRI9qtUeF TuhP4hwOMjO3bWncKKKJTIZqsolXCiB3fkdOJeF5QuZSIXDuYCcX8+J4XWIteZb6eR10 KeUsdg4WkFxDdWhRhkJC84NV14yfrLs7pl86A3IJCz91x6Btaif15mCt7PGL4QtVvC2H CWNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=WSXISRyRAkFabCGyvlchv58so6O8lXgedcJGqGu/lfE=; b=Z5Mnhdhgs/+AQRv4AL2jeSN+cKwkfZ4vMlO5TpQoxb4WMRYnB/k22OQVHXBalk4LMK purHxOwZ/NthN4Uz08cH4TA/5sP+AyHKFtqy9ZeiIS+1MGr8riS6nL+vlC+ZSGQLP2et curApl8QCx+MEbLuARCk792KM6bn10lZJA449GSOEf0VnWGaEhX2KbwSNzAE1Mwg3Ppt h9gZ94ednb3xU2E96nElVclGycErBeXgciHpgxS+yPm+1jOFXqVmFJCRHu6+7t2DayAY ToHzLuh4yediM8dS0gr7sQfIWh8wIN4Yl4IcAMHdn1lfCM5ELfJq8Otdb2nb9z0ydiMy uapA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3si48459990pfc.276.2019.04.16.00.14.56; Tue, 16 Apr 2019 00:15:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728181AbfDPHOX (ORCPT + 99 others); Tue, 16 Apr 2019 03:14:23 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35597 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726890AbfDPHOX (ORCPT ); Tue, 16 Apr 2019 03:14:23 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id A23BE80349; Tue, 16 Apr 2019 09:14:12 +0200 (CEST) Date: Tue, 16 Apr 2019 09:14:20 +0200 From: Pavel Machek To: Aaro Koskinen Cc: Tony Lindgren , linux-omap@vger.kernel.org, Janusz Krzysztofik , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP1: ams-delta: fix early boot crash when LED support is disabled Message-ID: <20190416071420.GA14538@amd> References: <20190415233732.3612-1-aaro.koskinen@iki.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <20190415233732.3612-1-aaro.koskinen@iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2019-04-16 02:37:32, Aaro Koskinen wrote: > When we boot with the LED support (CONFIG_NEW_LEDS) disabled, > gpio_led_register_device() will return a NULL pointer and we try > to dereference it. Fix by checking also for a NULL pointer. >=20 > Fixes: 19a2668a8ae3 ("ARM: OMAP1: ams-delta: Provide GPIO lookup table fo= r LED device") > Signed-off-by: Aaro Koskinen Acked-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAly1gMwACgkQMOfwapXb+vLNiACgtHM3J/eHilRjovPi/HsUecPJ 3sgAnAnEyk1CZ+d8gZTBslnBFEdng6lt =fEhN -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--