Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190409151100.16027-1-andriy.shevchenko@linux.intel.com> <CAE=gft7VK=7gV3PV1QdjRPOccEYmL-341fUNX+wXGUfrvzUDfw@mail.gmail.com>
In-Reply-To: <CAE=gft7VK=7gV3PV1QdjRPOccEYmL-341fUNX+wXGUfrvzUDfw@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 16 Apr 2019 10:55:50 +0300
Message-ID: <CAHp75Vfw8-jfzgOBwyTk6E5sqsSxh1NVPnLdQHyZJZneruT3uA@mail.gmail.com>
Subject: Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs
To:     Evan Green <evgreen@chromium.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lee Jones <lee.jones@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 16, 2019 at 6:10 AM Evan Green <evgreen@chromium.org> wrote:
> On Tue, Apr 9, 2019 at 11:11 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Intel Comet Lake has the same LPSS than Intel Cannon Lake.
> > Add the new IDs to the list of supported devices.

> >  static const struct pci_device_id intel_lpss_pci_ids[] = {
> > +       /* CML */
> > +       { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
> > +       { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
> > +       { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
> > +       { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info },
> > +       { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info },
> > +       { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info },
>
> How come it's not cnl_i2c_info?

This is a good question, that's why Jarkko asked Lee to hold on until
we have confirmation about i2c timings.

-- 
With Best Regards,
Andy Shevchenko