Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2944402yba; Tue, 16 Apr 2019 01:03:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqyw3AXQNpcg/HAzXyGzFGY/rp3oeVxC/H4n/aHj/XhkdqUWhCCcYgSoqGlFC/XPGDzrr+vS X-Received: by 2002:a63:1654:: with SMTP id 20mr75943975pgw.166.1555401784013; Tue, 16 Apr 2019 01:03:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555401784; cv=none; d=google.com; s=arc-20160816; b=WbjWQs6xgNPSa4eA0vO3OgLz6vaDfJBzfcJxCEhf+rRpEDHqqXHkmJVZFgwxghi3Lc N/aJPm4v6aMaBtL+KBggyGFVDJ+4aP2ghOWLmqd5Xl+9f5MJ5CVugcnDFtAZvDZzkCrt Fr8s/KJhaljyU3Sby+AU1bn4iOYBoy5WoJsolz6aDSKax3yI5ImofPrbeUTEV7KFZkvF s/ZYRUU9AlVkv9epJAeaQIuNCsDBLqLjANpVy0fIcjQcoylGMvGaGSYlJhtcyO6LU3e0 FxTYXuaKQZFmWUucZ9FVFU9xyCp7oXcnJ6ZqIKLA6DdbIWlfgqEOhND1AzQ4wNsRr4fS GlQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=XDJDaN/2ZDV9q6OXEER/klmZTstWUaYg5HnbFCd+fSU=; b=uytBM08jSZ2wDohmNZd20OQA/An2rS5xJTWMWHqUJKuxrLb3CVFciBZkMWUofDNA4N 15hXMNs8uPaW4U3u0GpuTV7YhPfMa0hP6wh79IxHNtrN04HwYNriGg1p43Rr2RXGwPcc tElrXTDSCafKWS4fHqcct4PcYbxciD/PNWmDaV/5CZ3c7sElrpvLdhCNm+M9NJGCTMbr wZdMvL4QJXA2JtImE0pz9zpGqftyRFNhx7p/1NC8gVFdzV+5BjLr8MG9FgSu4Henbjow zhyz/sPLLtOWK1ry9x1iS06v+26imQsHn5ay+KOEOZuJ7C1LKITRvIcydC42O6+Itma4 Ud0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j72si30543039pge.491.2019.04.16.01.02.47; Tue, 16 Apr 2019 01:03:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728543AbfDPIA5 (ORCPT + 99 others); Tue, 16 Apr 2019 04:00:57 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:63377 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726346AbfDPIA5 (ORCPT ); Tue, 16 Apr 2019 04:00:57 -0400 X-UUID: fb695c0618dd4dffbb3144602d453633-20190416 X-UUID: fb695c0618dd4dffbb3144602d453633-20190416 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1811725001; Tue, 16 Apr 2019 16:00:49 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 16 Apr 2019 16:00:47 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 16 Apr 2019 16:00:47 +0800 Message-ID: <1555401647.11519.2.camel@mtksdaap41> Subject: Re: [PATCH v2 18/25] drm/mediatek: add RDMA fifo size error handle From: CK Hu To: CC: , , , , , , , , , , , Date: Tue, 16 Apr 2019 16:00:47 +0800 In-Reply-To: <1553667561-25447-19-git-send-email-yongqiang.niu@mediatek.com> References: <1553667561-25447-1-git-send-email-yongqiang.niu@mediatek.com> <1553667561-25447-19-git-send-email-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-SNTS-SMTP: E900A9B331BE9A17B73B38784562106A167A14B97C92F255011EA9517FCE0B102000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang.niu@mediatek.com wrote: > From: Yongqiang Niu > > This patch add RDMA fifo size error handle > rdma fifo size will not always bigger than the calculated threshold > if that case happened, we need set fifo size as the threshold > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > index b0a5cff..ead38ba 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > @@ -137,11 +137,14 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > { > unsigned int threshold; > unsigned int reg; > + unsigned int rdma_fifo_size; > struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0, 0xfff, width); > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_1, 0xfffff, height); > > + rdma_fifo_size = RDMA_FIFO_SIZE(rdma); > + > /* > * Enable FIFO underflow since DSI and DPI can't be blocked. > * Keep the FIFO pseudo size reset default of 8 KiB. Set the > @@ -149,8 +152,12 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > * account for blanking, and with a pixel depth of 4 bytes: > */ > threshold = width * height * vrefresh * 4 * 7 / 1000000; > + > + if (threshold > rdma_fifo_size) > + threshold = rdma_fifo_size; I think this is a work around not a correct solution. Why MT8173 has no this problem but MT8183 has? Is the formula of threshold different in MT8173 and MT8183? Regards, CK > + > reg = RDMA_FIFO_UNDERFLOW_EN | > - RDMA_FIFO_PSEUDO_SIZE(RDMA_FIFO_SIZE(rdma)) | > + RDMA_FIFO_PSEUDO_SIZE(rdma_fifo_size) | > RDMA_OUTPUT_VALID_FIFO_THRESHOLD(threshold); > writel(reg, comp->regs + DISP_REG_RDMA_FIFO_CON); > }