Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2951489yba; Tue, 16 Apr 2019 01:12:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyVXLWCvqb90vMDPAKmjxePlPlLk72rcOSZpXCE1nnFSZaPzyL6CyWC1wiVIAYocTH3dC5p X-Received: by 2002:a17:902:aa91:: with SMTP id d17mr81864160plr.43.1555402370699; Tue, 16 Apr 2019 01:12:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555402370; cv=none; d=google.com; s=arc-20160816; b=nVNy6pnUjLFykwDKfDzzmCcuwWZc8wbgRWfwPeH3X0v3DGBpAgIDIN3jyGHtkIeqSV IOSE1zXlh+hrh4+q+RqEXhNbCV9ba7iaGg/my7zPBDDMelBxP9nhnqR2DbOWgQKQsh8e m7ozQewOowhF4AUMwtYrWH/Et4jS4D0j5LsPHj3nCULiQeINw3Ywh358zbn35eVdEzdF xv4gCzQhpTSdNrJ9Re6HdaltamheJHh20zxYR3BCqkrK3b3Z02BOwk2f7thTkuMWUTjn HqTGyb/xNMjSYdru0ijZrnWg6w5T/6X/DAaniRAPrYrIXAWs2N0tC+6NPEGXpAT9lNnL lYgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=u6qJ/hIOxZtS4UTlDgFgr86eIeEMyLDD+6opHT5blCo=; b=0ptJFSK2RWVeLOYevq3HA5l7p6WKHkyZ7QNBFkLEyYWRbAaE+3XNvFEj9j6W92x8/w PIgcE7yMUOUvO6GssonnczL+qe4V+FvTfbrdu3RKPUBw4CtZDrGtTum97WutJfF8OvfU SIQBa2jca3GS3o7P7wdOwQvCo+WDC8zs+eYYGddlMwdTyl8e3mf3oZugevtz4hcreWA1 iYsNTDv42GP0Bgrcst86p1mevrYe5Vf5ZIwJ6hriF/5AyPTNIWJWsspLvPPDTziSq/wI SWZzmA/IPoXDeFC3xo+u8szs+PhMU+FsCj75Va8EiQFqgyj/gP+Pw0YRWOW6+41SMLlb EEaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si22187717plv.293.2019.04.16.01.12.35; Tue, 16 Apr 2019 01:12:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728491AbfDPILz (ORCPT + 99 others); Tue, 16 Apr 2019 04:11:55 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:53391 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726346AbfDPILz (ORCPT ); Tue, 16 Apr 2019 04:11:55 -0400 X-UUID: 85fb53ff82c14d0abe05358bcba75402-20190416 X-UUID: 85fb53ff82c14d0abe05358bcba75402-20190416 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1486577775; Tue, 16 Apr 2019 16:11:45 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N1.mediatek.inc (172.27.4.71) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 16 Apr 2019 16:11:43 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 16 Apr 2019 16:11:42 +0800 Message-ID: <1555402302.18628.17.camel@mhfsdcap03> Subject: Re: [PATCH 2/5] mmc: mtk-sd: don't hard-code interrupt trigger type From: Chaotian Jing To: NeilBrown CC: Ulf Hansson , , , Date: Tue, 16 Apr 2019 16:11:42 +0800 In-Reply-To: <155539004923.25108.12499096383277776864.stgit@noble.brown> References: <155538933003.25108.3338569916935462285.stgit@noble.brown> <155539004923.25108.12499096383277776864.stgit@noble.brown> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-TM-SNTS-SMTP: 80F027BB97EB7CC69DBCF5923481919832701100AB31F82F878E200E23CCF39A2000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-04-16 at 14:47 +1000, NeilBrown wrote: > When using devicetree for configuration, interrupt trigger type > should be described in the dts file, not hard-coded in the C code. > > The mtk-sd silicon in the mt7621 soc uses an active-high interrupt > and so cannot be used with the current code. > > So remove the trigger and leave it to be set from devicetree. > > Signed-off-by: NeilBrown > --- > drivers/mmc/host/mtk-sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 4492a4465c0e..14e048239143 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -2243,7 +2243,7 @@ static int msdc_drv_probe(struct platform_device *pdev) > msdc_init_hw(host); > > ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq, > - IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host); > + change it to IRQF_TRIGGER_NONE | IRQF_ONESHOT > 0, pdev->name, host); > if (ret) > goto release; > > >