Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2994435yba; Tue, 16 Apr 2019 02:19:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5UkmXYfEDeIRwqtJdX2pMq9CxCvZsFFojvg3l1Lzi4I8H5lW+JtyJRoGuqVbPVa7LQGeO X-Received: by 2002:a62:184a:: with SMTP id 71mr62457970pfy.1.1555406384389; Tue, 16 Apr 2019 02:19:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555406384; cv=none; d=google.com; s=arc-20160816; b=ybzAEPSL9aj75ojv4s/1SU489PW4eBG1VXmEGwixcAiyHn8q44Cd/kJt/Mtcy6YNDL yX8OQPlYt6kZJMxVz/YGSDSn438Yj4mrLQhPEvb0xvttda4/iFJp6OsnIEvFFZj99L3P jRQ6NYQc9N6NwQmSyq5EeMCjim6UmCEMZaqIRBJ2qrUgLov8RbehI3BNb92eB/GH4yyA JGT9pQa40Pyyi9mJQCXQMpTlQJ15S5I7wxvEWW4cvwJTbQ8Qzf58zQUomKJcsVrFh83Q McCisoPK3OcuCwLxodV91FAIJpkujNDjz7KucrYqGyi/Al0UqUPXtf4WDtMgHOZ7Sfyq JTRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=V4GoJaaDljp6IS1ceyTtzT2LRIbcWeKTCKXks4Mykx0=; b=tMc4o3Eg3uoGswZX0/W4mosVd+bbraGcqykoUYVi9xNWyx7Abme0R7PywwXbhviM29 x+3e4W7ins1JnaqXd9xMaFcIGu5rnc76Ex6vg0rm0VtttErXNbmQZTAELdL9nWnykae6 K2e1BGBoTr2PMr1OvyiGTCppWgaR0xl180/8f3VQOQVuc7925XdNEF4Tu93tlnX+zdWe UtVIkxQOdC+h9F6HMGUrky+ZGEJgZ42/e1H67PMD9OqXjNAr2nvyQesTe2idvWKoPo0e Pr5308x2m2jK6qZ3WmtTZjMhHbvxAearFzscpi7Mcp8IHKavP96786lQFzCXwV/LBUKx CV9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2si46626587pgl.527.2019.04.16.02.19.28; Tue, 16 Apr 2019 02:19:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728328AbfDPJSy (ORCPT + 99 others); Tue, 16 Apr 2019 05:18:54 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:53673 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726749AbfDPJSx (ORCPT ); Tue, 16 Apr 2019 05:18:53 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hGKEt-0007t2-0W; Tue, 16 Apr 2019 09:18:51 +0000 Subject: Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication" To: Florian Westphal , Mukesh Ojha Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S . Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190415114414.24600-1-colin.king@canonical.com> <90e0d4af-77c5-6e4b-a364-5b9e342c83be@codeaurora.org> <20190416091214.vjydcg3xblxtvosk@breakpoint.cc> From: Colin Ian King Openpgp: preference=signencrypt Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= mQINBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABtCVDb2xpbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+iQI2BBMBCAAhBQJOkyQoAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEGjCh9/GqAImsBcP9i6C/qLewfi7iVcOwqF9avfGzOPf7CVr n8CayQnlWQPchmGKk6W2qgnWI2YLIkADh53TS0VeSQ7Tetj8f1gV75eP0Sr/oT/9ovn38QZ2 vN8hpZp0GxOUrzkvvPjpH+zdmKSaUsHGp8idfPpZX7XeBO0yojAs669+3BrnBcU5wW45SjSV nfmVj1ZZj3/yBunb+hgNH1QRcm8ZPICpjvSsGFClTdB4xu2AR28eMiL/TTg9k8Gt72mOvhf0 fS0/BUwcP8qp1TdgOFyiYpI8CGyzbfwwuGANPSupGaqtIRVf+/KaOdYUM3dx/wFozZb93Kws gXR4z6tyvYCkEg3x0Xl9BoUUyn9Jp5e6FOph2t7TgUvv9dgQOsZ+V9jFJplMhN1HPhuSnkvP 5/PrX8hNOIYuT/o1AC7K5KXQmr6hkkxasjx16PnCPLpbCF5pFwcXc907eQ4+b/42k+7E3fDA Erm9blEPINtt2yG2UeqEkL+qoebjFJxY9d4r8PFbEUWMT+t3+dmhr/62NfZxrB0nTHxDVIia u8xM+23iDRsymnI1w0R78yaa0Eea3+f79QsoRW27Kvu191cU7QdW1eZm05wO8QUvdFagVVdW Zg2DE63Fiin1AkGpaeZG9Dw8HL3pJAJiDe0KOpuq9lndHoGHs3MSa3iyQqpQKzxM6sBXWGfk EkK5Ag0ETpMkKAEQAMX6HP5zSoXRHnwPCIzwz8+inMW7mJ60GmXSNTOCVoqExkopbuUCvinN 4Tg+AnhnBB3R1KTHreFGoz3rcV7fmJeut6CWnBnGBtsaW5Emmh6gZbO5SlcTpl7QDacgIUuT v1pgewVHCcrKiX0zQDJkcK8FeLUcB2PXuJd6sJg39kgsPlI7R0OJCXnvT/VGnd3XPSXXoO4K cr5fcjsZPxn0HdYCvooJGI/Qau+imPHCSPhnX3WY/9q5/WqlY9cQA8tUC+7mgzt2VMjFft1h rp/CVybW6htm+a1d4MS4cndORsWBEetnC6HnQYwuC4bVCOEg9eXMTv88FCzOHnMbE+PxxHzW 3Gzor/QYZGcis+EIiU6hNTwv4F6fFkXfW6611JwfDUQCAHoCxF3B13xr0BH5d2EcbNB6XyQb IGngwDvnTyKHQv34wE+4KtKxxyPBX36Z+xOzOttmiwiFWkFp4c2tQymHAV70dsZTBB5Lq06v 6nJs601Qd6InlpTc2mjd5mRZUZ48/Y7i+vyuNVDXFkwhYDXzFRotO9VJqtXv8iqMtvS4xPPo 2DtJx6qOyDE7gnfmk84IbyDLzlOZ3k0p7jorXEaw0bbPN9dDpw2Sh9TJAUZVssK119DJZXv5 2BSc6c+GtMqkV8nmWdakunN7Qt/JbTcKlbH3HjIyXBy8gXDaEto5ABEBAAGJAh8EGAEIAAkF Ak6TJCgCGwwACgkQaMKH38aoAiZ4lg/+N2mkx5vsBmcsZVd3ys3sIsG18w6RcJZo5SGMxEBj t1UgyIXWI9lzpKCKIxKx0bskmEyMy4tPEDSRfZno/T7p1mU7hsM4owi/ic0aGBKP025Iok9G LKJcooP/A2c9dUV0FmygecRcbIAUaeJ27gotQkiJKbi0cl2gyTRlolKbC3R23K24LUhYfx4h pWj8CHoXEJrOdHO8Y0XH7059xzv5oxnXl2SD1dqA66INnX+vpW4TD2i+eQNPgfkECzKzGj+r KRfhdDZFBJj8/e131Y0t5cu+3Vok1FzBwgQqBnkA7dhBsQm3V0R8JTtMAqJGmyOcL+JCJAca 3Yi81yLyhmYzcRASLvJmoPTsDp2kZOdGr05Dt8aGPRJL33Jm+igfd8EgcDYtG6+F8MCBOult TTAu+QAijRPZv1KhEJXwUSke9HZvzo1tNTlY3h6plBsBufELu0mnqQvHZmfa5Ay99dF+dL1H WNp62+mTeHsX6v9EACH4S+Cw9Q1qJElFEu9/1vFNBmGY2vDv14gU2xEiS2eIvKiYl/b5Y85Q QLOHWV8up73KK5Qq/6bm4BqVd1rKGI9un8kezUQNGBKre2KKs6wquH8oynDP/baoYxEGMXBg GF/qjOC6OY+U7kNUW3N/A7J3M2VdOTLu3hVTzJMZdlMmmsg74azvZDV75dUigqXcwjE= Message-ID: <03212014-88b1-44c6-4cc1-562f2664680a@canonical.com> Date: Tue, 16 Apr 2019 10:18:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190416091214.vjydcg3xblxtvosk@breakpoint.cc> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2019 10:12, Florian Westphal wrote: > On 4/15/2019 5:14 PM, Colin King wrote: >>> diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c >>> index d880f3523c1d..95a0b3d6b24d 100644 >>> --- a/net/netfilter/nf_conntrack_h323_types.c >>> +++ b/net/netfilter/nf_conntrack_h323_types.c >>> @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */ >>> _NonStandardParameter}, >>> {FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0, >>> _SecurityServiceMode}, >>> - {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0, >>> + {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0, >>> _SecurityServiceMode}, >>> {FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0, >>> _SecurityServiceMode}, > > https://www.itu.int/ITU-T/formal-language/itu-t/h/h225-0/2009/H323-MESSAGES.html says: > ... > SecurityCapabilities ::= SEQUENCE { > nonStandard NonStandardParameter OPTIONAL, > encryption SecurityServiceMode, > authenticaton SecurityServiceMode, > integrity SecurityServiceMode, > ... > } > > so this spelling seems intentional. > Ah, thanks for spotting that, my bad.