Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3004492yba; Tue, 16 Apr 2019 02:35:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqyw2im626xxma1Rt8YUhxMTqWJgpAVEwxDNez+EVX+QnltVZUeFMKNqrGfU7g79ugEY5BLT X-Received: by 2002:a62:6f47:: with SMTP id k68mr65028050pfc.196.1555407317667; Tue, 16 Apr 2019 02:35:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555407317; cv=none; d=google.com; s=arc-20160816; b=JcLx3USUc2TXc0LCGW1nenT/tizGdUGUONnZVVs6dM5zNPRBljlnFTKpdQTI+bHidf X9wcgGR5mCUzpe4eypHMED3E4AvimhSJ0Tw7jFA2d4y7+vJQqXuBm/jVYQOBgV7/OFyX ioi5B7eWa2gTVvOYEwF99eb1BULgybXUJPHVnMr3oSE+NUeOJv1uVMQI1PbrtE0sSG3s Bi4Y6WnQVk5hc+3AO6iqjjXXjwItkYZA0Xy03xbqJFWNwYItnSgmtzInNCBdrULQatiN z3ZwsiwD0q/hA2y4NlouPtSxtIAvr3tltXmu6KIsVNqMgQIHdDGaapOdchXC+fnzMczm 0vyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from; bh=DNM0AToFUP5nBaEN8zfE1hHo6/yRYF0WM+A5y7WHZTo=; b=iLNs0DXduMM6nC4k9HEC3B085FCaqzKUdCqjZgVeU29oq3XY0pVePdtoXdqWRSulJV ECSl0N5cn3xIQLCJffw0I0A31wJQMSOMchqCgtE6e0fwqldHpVGE8nkEtp0UJUnsJgTu Lsz80di0YCWVg3UJ+tNuMPp4oxzLvuifUz4wbEYH79IvNLrJ53zBveiiv1usdtQAhxFm 3HmYqCQ8oAA3sttVAZqDYRC59nmbuIuhohMY98AxHsyoiVZahVwrUupOQ8oJXC56xqBS ArpatsEYw/0KQkoXk6Ex1veE8eKDcsMptYd1cuIRCIrUnuayx+RvoybL8dD69Bwmrvqt gJ6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o70si21027812pfa.33.2019.04.16.02.35.01; Tue, 16 Apr 2019 02:35:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728702AbfDPJeN (ORCPT + 99 others); Tue, 16 Apr 2019 05:34:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:41622 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726739AbfDPJeN (ORCPT ); Tue, 16 Apr 2019 05:34:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C893BAE12; Tue, 16 Apr 2019 09:34:11 +0000 (UTC) From: Thomas Bogendoerfer To: Joshua Kinard , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] rtc: ds1685: remove dead code Date: Tue, 16 Apr 2019 11:34:03 +0200 Message-Id: <20190416093404.6785-1-tbogendoerfer@suse.de> X-Mailer: git-send-email 2.13.7 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ds1685_rtc_begin_ctrl_access/ds1685_rtc_end_ctrl_access aren't used, so get rid of it. Signed-off-by: Thomas Bogendoerfer --- drivers/rtc/rtc-ds1685.c | 36 ------------------------------------ 1 file changed, 36 deletions(-) diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c index 2f5194df239e..33781be58f16 100644 --- a/drivers/rtc/rtc-ds1685.c +++ b/drivers/rtc/rtc-ds1685.c @@ -192,42 +192,6 @@ ds1685_rtc_end_data_access(struct ds1685_priv *rtc) } /** - * ds1685_rtc_begin_ctrl_access - prepare the rtc for ctrl access. - * @rtc: pointer to the ds1685 rtc structure. - * @flags: irq flags variable for spin_lock_irqsave. - * - * This takes several steps to prepare the rtc for access to read just the - * control registers: - * - Sets a spinlock on the rtc IRQ. - * - Switches the rtc to bank 1. This allows access to the two extended - * control registers. - * - * Only use this where you are certain another lock will not be held. - */ -static inline void -ds1685_rtc_begin_ctrl_access(struct ds1685_priv *rtc, unsigned long *flags) -{ - spin_lock_irqsave(&rtc->lock, *flags); - ds1685_rtc_switch_to_bank1(rtc); -} - -/** - * ds1685_rtc_end_ctrl_access - end ctrl access on the rtc. - * @rtc: pointer to the ds1685 rtc structure. - * @flags: irq flags variable for spin_unlock_irqrestore. - * - * This ends what was started by ds1685_rtc_begin_ctrl_access: - * - Switches the rtc back to bank 0. - * - Unsets the spinlock on the rtc IRQ. - */ -static inline void -ds1685_rtc_end_ctrl_access(struct ds1685_priv *rtc, unsigned long flags) -{ - ds1685_rtc_switch_to_bank0(rtc); - spin_unlock_irqrestore(&rtc->lock, flags); -} - -/** * ds1685_rtc_get_ssn - retrieve the silicon serial number. * @rtc: pointer to the ds1685 rtc structure. * @ssn: u8 array to hold the bits of the silicon serial number. -- 2.13.7